mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 11:00:43 +00:00
VariableVince
a71ac7a218
## Description: **--Fix oversight in v24--** In v24, alliance renewal was introduced. But a Bot or Nation never answers to it. So the Event Panel expiration message + clicking to Renew and waiting, is all in vain if the other player is not a human. Like in Single player in all cases. The message after ~30 seconds is always "Alliance with xxx expired". This feels illogical and there's no purpose for showing a Request to Renew button if it then always expires. Also reported by players like here: https://discord.com/channels/1284581928254701718/1284581928833388619/1398249123093676094 This PR fixes it by having the non-human reciever of the request, say yes to depending on attiude towards the human and chance. This feels more realistic. The requestor is always the human player because they click a button in EventsDisplay. So there is always already an extension request which the bot can react to with another extension request to have the alliance be extended. **--Add tests--** It adds tests for extending alliance between human and non-human player. One for AllianceExtensionExecution simply testing if alliance between human and non-human can be extended. And one in BotBehavior, testing if it correctly handles an extension request by adding a new AllianceExtensionExecution. **--Fix silent bug in existing test--** Adding the new test for human and non-human for AllianceExtensionExecution, i ran into a bug in the existing test for extending alliance between humans. Which made the test always pass because expirationAt wasn't fetched correctly. Had to fix that too, without intending that for this PR beforehand. And then had to include the bugfix from PR #1582 (v25) in it too to have the alliance actually extended. More details below: (-- The existing test would always return 'all passed' because it did not get the expiresAt() but got the createdAt + config.AllianceDuration() for both expirationBefore and expirationAfter. createdAt is immutable so before and after would be the same. And then it did not test for toBeGreaterThan, which would have failed. But it tested wrongfully for toBeGreaterThanOrEqual which was a pass even when the expirationBefore and expirationAfter would be the same and no extension had taken place. -- The bugfix from PR 1582 needed to be included now too. Because only with those changes, the existing test has its alliance truly extended and only with that the expirationAt actually changed. Actually, checking if extend() was called isn't needed anymore, since we now check the expirationAt correctly which on its own tells us if extend() was succesful. But left this addition from PR 1582 in since it can't do any harm.) ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced - [ ] I have read and accepted the CLA agreement (only required once). ## Please put your Discord username so you can be contacted if a bug or regression is found: tryout33 --------- Co-authored-by: evanpelle <openfrontio@gmail.com> Co-authored-by: Drills Kibo <59177241+drillskibo@users.noreply.github.com>
OpenFront.io is an online real-time strategy game focused on territorial control and alliance building. Players compete to expand their territory, build structures, and form strategic alliances in various maps based on real-world geography.
This is a fork/rewrite of WarFront.io. Credit to https://github.com/WarFrontIO.
OpenFront - Licensing
OpenFront Contributor License Agreement (CLA) can be found here. This is to help us transition to AGPL, a stricter open source license. After creating a pull request you will be prompted to sign.
This project uses a multi-licensing approach:
- Code in the
server/andcore/directory is licensed under MIT - Client code (in the
client/directory) is licensed under GPL v3 - Assets in resources/non-commercial are under CC BY-NC 4.0 with OpenFront LLC Commercial Exemption. By contributing assets to /non-commercial/, contributors agree that OpenFront LLC may use their contributions for commercial purposes while the contributions remain CC BY-NC 4.0 for all other parties.
See LICENSE file for more details.
🌟 Features
- Real-time Strategy Gameplay: Expand your territory and engage in strategic battles
- Alliance System: Form alliances with other players for mutual defense
- Multiple Maps: Play across various geographical regions including Europe, Asia, Africa, and more
- Resource Management: Balance your expansion with defensive capabilities
- Cross-platform: Play in any modern web browser
📋 Prerequisites
- npm (v10.9.2 or higher)
- A modern web browser (Chrome, Firefox, Edge, etc.)
🚀 Installation
-
Clone the repository
git clone https://github.com/openfrontio/OpenFrontIO.git cd OpenFrontIO -
Install dependencies
npm i
🎮 Running the Game
Development Mode
Run both the client and server in development mode with live reloading:
npm run dev
This will:
- Start the webpack dev server for the client
- Launch the game server with development settings
- Open the game in your default browser
Client Only
To run just the client with hot reloading:
npm run start:client
Server Only
To run just the server with development settings:
npm run start:server-dev
🛠️ Development Tools
-
Format code:
npm run format -
Lint code:
npm run lint -
Lint and fix code:
npm run lint:fix -
Testing
npm test
🏗️ Project Structure
/src/client- Frontend game client/src/core- Shared game logic/src/server- Backend game server/resources- Static assets (images, maps, etc.)
📝 License
This project is licensed under the terms found in the LICENSE file.
🤝 Contributing
Contributions are welcome! Please feel free to submit a Pull Request.
- Request to join the development Discord.
- Fork the repository
- Create your feature branch (
git checkout -b amazing-feature) - Commit your changes (
git commit -m 'Add some amazing feature') - Push to the branch (
git push origin amazing-feature) - Open a Pull Request
🌐 Translation
Translators are welcome! Please feel free to help translate into your language. How to help?
- Request to join the translation Discord
- Go to the project's Crowdin translation page: https://crowdin.com/project/openfront-mls
- Login if you already have an account/ Sign up if you don't have one
- Select the language you want to translate in/ If your language isn't on the list, click the "Request New Language" button and enter the language you want added there.
- Translate the strings
Project Governance
- The project maintainer (evan) has final authority on all code changes and design decisions
- All pull requests require maintainer approval before merging
- The maintainer reserves the right to reject contributions that don't align with the project's vision or quality standards
Contribution Path for New Contributors
To ensure code quality and project stability, we use a progressive contribution system:
-
New Contributors: Limited to UI improvements and small bug fixes only
- This helps you become familiar with the codebase
- UI changes are easier to review and less likely to break core functionality
- Small, focused PRs have a higher chance of being accepted
-
Established Contributors: After several successful PRs and demonstrating understanding of the codebase, you may work on more complex features
-
Core Contributors: Only those with extensive experience with the project may modify critical game systems
How to Contribute Successfully
-
Before Starting Work:
- Open an issue describing what you want to contribute
- Wait for maintainer feedback before investing significant time
- Small improvements can proceed directly to PR stage
-
Code Quality Requirements:
- All code must be well-commented and follow existing style patterns
- New features should not break existing functionality
- Code should be thoroughly tested before submission
- All code changes in src/core MUST be tested.
-
Pull Request Process:
- Keep PRs focused on a single feature or bug fix
- Include screenshots for UI changes
- Describe what testing you've performed
- Be responsive to feedback and requested changes
-
Testing Requirements:
- Verify your changes work as expected
- Test on multiple systems/browsers if applicable
- Document your testing process in the PR
Communication
- Be respectful and constructive in all project interactions
- Questions are welcome, but please search existing issues first
- For major changes, discuss in an issue before starting work
Final Notes
Remember that maintaining this project requires significant effort. The maintainer appreciates your contributions but must prioritize long-term project health and stability. Not all contributions will be accepted, and that's okay.
Thank you for helping make OpenFront better!