Commit Graph

9 Commits

Author SHA1 Message Date
Scott Anderson 70745faac4 Enable strictNullChecks, eqeqeq (#436)
## Description:

Improve type safety and runtime correctness by:
1. Enabling TypeScript's
[strictNullChecks](https://www.typescriptlang.org/tsconfig/#strictNullChecks)
compiler option.
2. Replacing all loose equality operators (`==` and `!=`) with strict
equality operators (`===` and `!==`).
3. Cleaning up of type declarations, null handling logic, and equality
expressions throughout the project.

Currently, the code allows implicit assumptions that `null` and
`undefined` are interchangeable, and relies on type-coercing equality
checks that can introduce subtle bugs. These practices make it difficult
to reason about when values may be absent and hinder the effectiveness
of static analysis.

Migrating to strict null checks and enforcing strict equality
comparisons will clarify intent, reduce bugs, and make the codebase
safer and easier to maintain.

Fixes #466 

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

---------

Co-authored-by: Scott Anderson <662325+scottanderson@users.noreply.github.com>
Co-authored-by: evanpelle <openfrontio@gmail.com>
2025-05-15 16:39:40 -07:00
Evan 8b6895d745 add prettier import plugin 2025-03-31 13:09:27 -07:00
NewHappyRabbit 9b85651ad8 Fixed dark mode class being added in different places (body and html elements).
Fixed flag "None" (xx.svg) being able to be set and used ingame.

All menu modals will now close if you click outside of them.

Fixed info icon in instructions.

Added an icon to show the number of new events that happened while the events panel is hidden.

Removed opacity from the svg icons files and added it to the player-icons div, making them have the same opacity and being more visible.
2025-03-02 09:39:36 -08:00
NewHappyRabbit aa24d317c8 Added PWA and mobile improvements to the UI 2025-02-24 11:49:58 +02:00
NewHappyRabbit ec2ba4eece Changed flag search input text to black when in light mode 2025-02-22 01:54:23 +02:00
NewHappyRabbit e9eb006cea Added dark mode 2025-02-20 00:48:45 +02:00
NewHappyRabbit 42ca32d390 Fixed flag modal CSS for mobile 2025-02-14 10:54:29 +02:00
NewHappyRabbit 115e40916b Flag button turned into toggle to show/hide flags modal. 2025-02-13 18:11:18 +02:00
NewHappyRabbit 27173092cf Changed the flags to a more cartoony/emojiy? version (Thanks Nour!).
Removed coalitions from the countries.json file.
Seperated the flag from the name input.
2025-02-12 22:53:33 +02:00