added comment about query memory usage for toArray
This commit is contained in:
committed by
Brian Gough
parent
0532a4daaa
commit
f64969c784
@@ -88,6 +88,10 @@ module.exports = PackManager =
|
||||
|
||||
needMore = false # keep track of whether we need to load more data
|
||||
updates = [] # used to accumulate the set of results
|
||||
|
||||
# FIXME: packs are big so we should accumulate the results
|
||||
# incrementally instead of using .toArray() to avoid reading all
|
||||
# of the changes into memory
|
||||
cursor.toArray (err, result) ->
|
||||
unpackedSet = PackManager._unpackResults(result)
|
||||
updates = PackManager._filterAndLimit(updates, unpackedSet, filterFn, limit)
|
||||
@@ -141,6 +145,9 @@ module.exports = PackManager =
|
||||
|
||||
updates = [] # used to accumulate the set of results
|
||||
|
||||
# FIXME: packs are big so we should accumulate the results
|
||||
# incrementally instead of using .toArray() to avoid reading all
|
||||
# of the changes into memory
|
||||
cursor.toArray (err, result) ->
|
||||
if err?
|
||||
return callback err, result
|
||||
|
||||
Reference in New Issue
Block a user