babyboucher 94bab78d24 Fix off by one error (#3827) ...

## Description:

Currently it is impossible to search for 2 letter clan tags (UN, FR,
EU), this is because of an off by one error present in the API

## Please complete the following:

- [X] I have added screenshots for all UI updates
- [X] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [X] I have added relevant tests to the test directory
- [X] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced

## Please put your Discord username so you can be contacted if a bug or
regression is found:

Babyboucher

2026-05-05 22:15:47 -06:00

..

client

Fix off by one error (#3827)

2026-05-05 22:15:47 -06:00

core

bugfix: SAM was only reloading when not in cooldown (#3817)

2026-05-02 09:05:10 -06:00

economy

Improve random spawn (#2503)

2025-12-20 13:35:30 -08:00

nukes

Trading in lakes 🚤 (#3653)

2026-04-12 17:18:52 -07:00

pathfinding

Water-Nukes 💧 (#3604)

2026-04-08 20:56:02 -07:00

perf

TypeScript update to 6.0.3 (#3806)

2026-04-30 15:49:24 -06:00

server

Increase max intent size to 2kb (#3852)

2026-05-05 14:59:09 -06:00

testdata/maps

Remove small islands on compact maps with half threshold 🏝️ (#3762)

2026-04-25 11:51:02 -06:00

util

Move turnstile check to api (#3845)

2026-05-04 12:53:02 -06:00

AiAttackBehavior.test.ts

Cleanup nations (Part 1) 🧹 (#2637)

2025-12-18 16:20:23 -08:00

AllianceAcceptNukes.test.ts

Cancel nukes when accepting alliance via radial menu (#3155)

2026-02-16 11:10:26 -08:00

AllianceDonation.test.ts

Cancel nukes when accepting alliance via radial menu (#3155)

2026-02-16 11:10:26 -08:00

AllianceExtensionExecution.test.ts

Cancel nukes when accepting alliance via radial menu (#3155)

2026-02-16 11:10:26 -08:00

AllianceRequestExecution.test.ts

Cancel nukes when accepting alliance via radial menu (#3155)

2026-02-16 11:10:26 -08:00

AssetUrls.test.ts

Serve hashed assets from R2 via CDN_BASE (#3773)

2026-04-27 11:27:54 -06:00

Attack.test.ts

2661 PR 3/3 Warship Manual Override, Aggro Override, and Heal-at-Port Command (#3501)

2026-04-30 13:54:28 -06:00

AttackStats.test.ts

fix(tests): update AttackStats to expect 50% war gold for human conquests

2026-05-02 09:33:14 -06:00

AutoUpgrade.test.ts

build: migrate build system to Vite and test runner to Vitest & Remove depracated husky usage (#2703)

2025-12-28 22:10:26 -08:00

Censor.test.ts

Clan System Part 1 (#3276)

2026-03-17 15:55:47 -07:00

Colors.test.ts

Add Nations Vs Players Game Mode (#2233)

2025-10-28 16:40:30 -07:00

ConquerGold.test.ts

conqueror receives 50% of gold when conquering a human player (#3818)

2026-05-02 09:23:49 -06:00

CosmeticRelationship.test.ts

Add support to purchase cosmetics with in-game currency (#3648)

2026-04-13 10:19:43 -07:00

DeleteUnitExecution.test.ts

build: migrate build system to Vite and test runner to Vitest & Remove depracated husky usage (#2703)

2025-12-28 22:10:26 -08:00

Disconnected.test.ts

2661 PR 3/3 Warship Manual Override, Aggro Override, and Heal-at-Port Command (#3501)

2026-04-30 13:54:28 -06:00

Donate.test.ts

Improve random spawn (#2503)

2025-12-20 13:35:30 -08:00

FindAndUpgradeNearestBuilding.test.ts

Fix middle-click SAM not upgrading other buildings when SAM is unaffo… (#3670)

2026-04-18 21:35:23 -07:00

GameInfoRanking.test.ts

Clan System Part 1 (#3276)

2026-03-17 15:55:47 -07:00

InputHandler.test.ts

feat: multi-warship selection with Shift+drag box (#3677)

2026-04-21 14:06:07 -07:00

MapConsistency.test.ts

Update Britannia and take its Classic version off rotation (#3710)

2026-04-18 21:36:49 -07:00

MapManifestFlags.test.ts

fix: add validation for unknown flags in manifest.json (#3044)

2026-01-27 15:54:01 -08:00

MessageTypeClasses.test.ts

build: migrate build system to Vite and test runner to Vitest & Remove depracated husky usage (#2703)

2025-12-28 22:10:26 -08:00

MissileSilo.test.ts

Improve random spawn (#2503)

2025-12-20 13:35:30 -08:00

NameLayer.test.ts

Fading handshake (#2474)

2025-11-19 12:32:01 -08:00

NationAllianceBehavior.test.ts

Massive nation improvement 🤖 (#3761)

2026-04-26 18:43:45 -06:00

NationCounterWarshipInfestation.test.ts

Clan System Part 1 (#3276)

2026-03-17 15:55:47 -07:00

NationMIRV.test.ts

Clan System Part 1 (#3276)

2026-03-17 15:55:47 -07:00

NationNameLength.test.ts

fix failing nationNameLength test (#2556)

2025-12-03 15:40:53 -08:00

NationNukeSamOverwhelm.test.ts

Nations can overwhelm SAMs now 💥 (+ 3 little nation improvements) (#3246)

2026-02-20 23:16:03 -06:00

NationStructureBehavior.test.ts

Nations: Fix city farming + reactive defense posts + fix nuked territory capture 🛡️ (#3814)

2026-05-03 09:33:44 -06:00

PlayerImpl.test.ts

Fix/Perf/Refactor: playerActions and buildableUnits, their callers and related types (#3220)

2026-03-04 11:32:45 -08:00

PlayerInfo.test.ts

Clan System Part 1 (#3276)

2026-03-17 15:55:47 -07:00

PortExecution.test.ts

BUG FIX: Gold double deduction + Rmoval of UnitType.Construction (#2378)

2025-11-26 14:45:14 -08:00

Privilege.test.ts

fix: catch punctuation-separated slurs in username censor

2026-05-04 18:18:36 -06:00

radialMenuElements.test.ts

Orange betrayal button for no-debuff-betrayals 🖌️ (#3161)

2026-02-09 23:23:20 +00:00

ResolveCosmetics.test.ts

Fix build: add missing adfree field to ResolveCosmetics test mock 🔧 (#3816)

2026-05-02 08:32:10 -06:00

setup.ts

test: add vitest-canvas-mock for local canvas support

2026-02-24 15:59:14 -06:00

ShellRandom.test.ts

BUG FIX: Gold double deduction + Rmoval of UnitType.Construction (#2378)

2025-11-26 14:45:14 -08:00

Stats.test.ts

Fix external train trade attribution in match results (#3589)

2026-04-15 02:35:32 +00:00

StatsSchema.test.ts

Account Modal Bugfix (#3687)

2026-04-16 13:18:55 -07:00

Team.test.ts

Move maps generation out of repo, new map structure (#1256)

2025-06-23 11:23:56 -07:00

TeamAssignment.test.ts

Clan System Part 1 (#3276)

2026-03-17 15:55:47 -07:00

TerritoryCapture.test.ts

Improve random spawn (#2503)

2025-12-20 13:35:30 -08:00

TranslationSystem.test.ts

feat: add warning news type and Firefox performance notice (#3680)

2026-04-16 16:53:38 -07:00

UnitGrid.test.ts

Fix remaining errors and enable strict mode (#1628)

2025-08-03 23:06:31 +00:00

Warship.test.ts

Fix warship diagonal chase and improve trade ship capture reliability (#3807)

2026-04-30 16:37:44 -06:00

WarshipMultiSelection.test.ts

2661 PR 3/3 Warship Manual Override, Aggro Override, and Heal-at-Port Command (#3501)

2026-04-30 13:54:28 -06:00