mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-07-01 09:53:24 +00:00
Arkadiusz Sygulski
297e1f579e
Resolves pathfinding issue: https://discord.com/channels/1359946986937258015/1458870041964445706 ## Description: BucketQueue requires `maxF` to be defined. Estimating it is much more complicated than the code assumed. This caused the bucket to overflow on certain paths, mostly (a) twisty paths - defined as one which must traverse both ways along the same axis, (b) maps where height > width, because we used `width ** 2` to estimate size instead of `width * height` (iirc height was not easily accessible). This PR replcaes BucketQueue with already existing MinHeap. `AStar.AbstractGraph` is already specialized in traversing `AbstractGraph`, so I have dropped the `useMinHeap` option and instead made it the default path. Otherwise we'd be leaving dead code. The max priority was also fixed to account for duplicate connections, abstract graph is already very small so it should not affect (and in my testing does not) affect performance. **Before** <img width="1813" height="1781" alt="image" src="https://github.com/user-attachments/assets/63648db1-a293-441d-8ea8-eaf98694f04a" /> **After** <img width="1734" height="1702" alt="image" src="https://github.com/user-attachments/assets/b4ec2f68-b945-42e1-bab4-53ba19fa2bbf" /> ## Please complete the following: - [ ] I have added screenshots for all UI updates - [ ] I process any text displayed to the user through translateText() and I've added it to the en.json file - [ ] I have added relevant tests to the test directory ## Please put your Discord username so you can be contacted if a bug or regression is found: moleole