mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 08:11:54 +00:00
Evan
3de5fb4204
**Add approved & assigned issue number here:** N/A — maintainer refactor. ## Description: Makes each map's `info.json` the single source of truth for map metadata — adding a map is now a folder with `image.png` + `info.json`, a `gen-maps` run, and an en.json display name. **info.json / manifest.json carry full map metadata.** Every `map-generator/assets/maps/<map>/info.json` declares `id` (the `GameMapType` enum key), `name` (the enum value — wire format, unchanged for all 94 maps), `translation_key`, `categories`, and `multiplayer_frequency` (the public-playlist weight that used to be the `FREQUENCY` record in MapPlaylist.ts). The generator validates everything and mirrors it into `resources/maps/<map>/manifest.json`. 23 stale info.json `name` values were normalized to the canonical enum value; enum values are byte-identical, so replays and stored game configs are unaffected. **The generator emits the TypeScript and discovers maps itself.** New `map-generator/codegen.go` generates `src/core/game/Maps.gen.ts` (`GameMapType`, `GameMapName`, `mapCategories`, `mapTranslationKeys`, `multiplayerFrequency` — now a full `Record<GameMapName, number>`, killing the old `Partial`) on every run; `Game.ts` re-exports it. The hardcoded map registry in `main.go` is gone — maps are auto-discovered from the `assets/maps` / `assets/test_maps` directories. MapConsistency tests fail with a "run `npm run gen-maps`" message if info.json, manifest.json, and Maps.gen.ts drift. The tracked `map-generator/map-generator` binary is rebuilt to match. **New categories: continents + world/cosmic/tournament/other, multi-category support.** `continental`/`regional`/`fantasy`/`arcade` are replaced by `featured`, `world`, `europe`, `asia`, `north_america`, `africa`, `south_america`, `oceania`, `antarctica`, `cosmic`, `tournament`, and `other`. Maps can list multiple categories, so straddlers (Black Sea, Bosphorus, Caucasus, Between Two Seas, Bering Sea/Strait, Mena, Strait of Gibraltar, Hawaii, Arctic) appear under both regions. Featured is itself a category (same 7 maps as before). MapPlaylist keeps its arcade exclusion via an explicit set. **Map picker UI.** Two tabs: **Featured** (default — featured maps plus a Favorites section when maps are starred) and **All** (one prominent collapsible bar per category with a map count, collapsed by default). The selected map is prepended to the featured grid when it lives elsewhere. `getMapName()` resolves through the generated `mapTranslationKeys`, which also fixes tourney maps never resolving a valid translation key. ## Please complete the following: - [ ] I have added screenshots for all UI updates (maintainer change — picker described above) - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory ## Please put your Discord username so you can be contacted if a bug or regression is found: evanpelle 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
99 lines
1.9 KiB
JSON
99 lines
1.9 KiB
JSON
{
|
|
"id": "NewYorkCity",
|
|
"name": "New York City",
|
|
"translation_key": "map.newyorkcity",
|
|
"categories": ["north_america"],
|
|
"multiplayer_frequency": 3,
|
|
"nations": [
|
|
{
|
|
"coordinates": [127, 1323],
|
|
"name": "Unami Tribe"
|
|
},
|
|
{
|
|
"coordinates": [116, 765],
|
|
"name": "Unalachtigo"
|
|
},
|
|
{
|
|
"coordinates": [163, 135],
|
|
"name": "Munsee Tribe"
|
|
},
|
|
{
|
|
"coordinates": [661, 531],
|
|
"name": "Mannahatta Village"
|
|
},
|
|
{
|
|
"coordinates": [558, 760],
|
|
"name": "New Netherland Colony",
|
|
"flag": "nl"
|
|
},
|
|
{
|
|
"coordinates": [756, 833],
|
|
"name": "New York Colony",
|
|
"flag": "gb-eng"
|
|
},
|
|
{
|
|
"coordinates": [240, 1818],
|
|
"name": "New Jersey Colony",
|
|
"flag": "gb-eng"
|
|
},
|
|
{
|
|
"coordinates": [1065, 1085],
|
|
"name": "Long Island Territory",
|
|
"flag": "gb-eng"
|
|
},
|
|
{
|
|
"coordinates": [1454, 989],
|
|
"name": "Montaukett Nation"
|
|
},
|
|
{
|
|
"coordinates": [1367, 762],
|
|
"name": "Unkechaug Nation"
|
|
},
|
|
{
|
|
"coordinates": [1109, 824],
|
|
"name": "Shinnecock Nation"
|
|
},
|
|
{
|
|
"coordinates": [969, 269],
|
|
"name": "Weckquaesgeek"
|
|
},
|
|
{
|
|
"coordinates": [746, 1172],
|
|
"name": "Siwanoy"
|
|
},
|
|
{
|
|
"coordinates": [927, 86],
|
|
"name": "Colen Donck",
|
|
"flag": "nl"
|
|
},
|
|
{
|
|
"coordinates": [849, 1043],
|
|
"name": "Canarsie"
|
|
},
|
|
{
|
|
"coordinates": [991, 1247],
|
|
"name": "Rockaway"
|
|
},
|
|
{
|
|
"coordinates": [929, 642],
|
|
"name": "Maspeth",
|
|
"flag": "gb-eng"
|
|
},
|
|
{
|
|
"coordinates": [647, 1018],
|
|
"name": "Breukelen",
|
|
"flag": "nl"
|
|
},
|
|
{
|
|
"coordinates": [1150, 532],
|
|
"name": "Vlissingen",
|
|
"flag": "nl"
|
|
},
|
|
{
|
|
"coordinates": [629, 690],
|
|
"name": "Gravesend",
|
|
"flag": "gb-eng"
|
|
}
|
|
]
|
|
}
|