Files
OpenFrontIO/tests/PlayerUpdateDiff.test.ts
T
Evan 2e6f70c098 Speed up the core sim: inline sfc32 PRNG and allocation-free player updates (#4233)
## Summary

Follow-up to #4230. Two more core-sim optimizations — these are
**behavior-affecting in controlled ways** (unlike #4230, which was
hash-identical), so both come with dedicated test coverage written
before the change.

Combined results (`npm run perf:game`, same machine, before → after):

| run | mean tick | ticks/sec | p99 | peak heap |
|---|---|---|---|---|
| default (world, 400 bots, 1800 ticks) | 7.98 → **6.96 ms** | 125 →
**144** | 21.2 → **19.0 ms** | 438 → **294 MB** |
| giantworldmap, 600 ticks | 17.4 → **15.2 ms** | 58 → **66** | 32.6 →
30.5 ms | |

Cumulative with #4230 vs. the original baseline: default run mean 9.04 →
6.96 ms (111 → 144 ticks/sec); giantworldmap 22.5 → 15.2 ms (44 → 66
ticks/sec, max tick 52.8 → 40.1 ms).

### 1. `PseudoRandom`: seedrandom ARC4 → inline sfc32

- ARC4 was ~4% of profiled self time. The new engine is sfc32 with
splitmix32 seed expansion and a warmup, using only 32-bit integer ops —
sequences are identical across platforms. The class API is unchanged.
- This **removes the `seedrandom` dependency entirely**, making
`src/core` actually dependency-free (the import was the only violation
of that rule).
- ⚠️ **The random stream differs, so the deterministic game-state hash
changes.** All clients run the same code, so cross-client sync is
unaffected; the harness reproduces the same hash on repeated runs per
seed. New reference hashes:
  - `--map world --ticks 200 --bots 100` → `5607618202213430`
  - default run → `29309648281599524`
  - `--map giantworldmap --ticks 600` → `39945089450032050`
- New `tests/PseudoRandom.test.ts` (15 tests) pins the engine-agnostic
contract: per-seed determinism, ranges, uniformity, adjacent-seed
decorrelation, and every API method. The tests were verified green
against the old engine first, then the swap.
- The stream change exposed a test that passed **by RNG luck**: in
`AiAttackBehavior.test.ts`, "nation cannot attack allied player" was
actually being blocked by the difficulty dice gate in `shouldAttack`,
not the alliance check — hiding that the test's `AiAttackBehavior` was
constructed without its `NationEmojiBehavior`. The test now supplies one
and verifies the real protection layer (`AttackExecution`'s alliance
check), robust to any dice outcome.

### 2. `PlayerImpl.toFullUpdate`: allocation-free empty collections

- `toFullUpdate` runs for every player every tick and allocated ~10
collections each (allies, embargoes Set, attacks, alliance views, …)
even when all were empty — the common case for most of 472 players.
Because `lastSentUpdate` retains each snapshot for a full tick, these
objects survived minor GC, got promoted, and accumulated as old-space
garbage between major GCs — that's the peak-heap drop.
- Empty collections now reuse shared **frozen** module-level singletons,
so `diffPlayerUpdate`'s existing `a === b` fast paths skip structural
comparison entirely. Non-empty collections build in single passes.
Freezing makes accidental in-worker mutation throw loudly instead of
silently corrupting every player; consumers across the worker boundary
get mutable structured clones as before. (`Set` cannot be frozen —
`EMPTY_EMBARGOES` is documented as never-mutate.)
- Value-identical: the game-state hash is unchanged by this part
(verified against the post-PRNG baseline).
- New `tests/PlayerUpdateDiff.test.ts` (8 tests): full-snapshot shape,
null-when-unchanged, embargo/alliance/target/attack diffs through the
real tick pipeline, and the freeze contract.

### Verification

- Full suite passes: 124 files / 1408 tests (23 new) + server tests;
lint and prettier clean.
- Hash reproducibility confirmed: repeated runs with identical args
produce identical hashes on all three configs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-06-12 08:15:01 -07:00

192 lines
6.7 KiB
TypeScript

import { AttackExecution } from "../src/core/execution/AttackExecution";
import { SpawnExecution } from "../src/core/execution/SpawnExecution";
import { Game, Player, PlayerInfo, PlayerType } from "../src/core/game/Game";
import { GameUpdateType, PlayerUpdate } from "../src/core/game/GameUpdates";
import { GameID } from "../src/core/Schemas";
import { setup } from "./util/Setup";
let game: Game;
const gameID: GameID = "game_id";
let alice: Player;
let bob: Player;
describe("Player update diffing (toUpdate)", () => {
beforeEach(async () => {
game = await setup("plains", { infiniteTroops: true });
const aliceInfo = new PlayerInfo(
"alice",
PlayerType.Human,
"alice_client",
"alice_id",
);
const bobInfo = new PlayerInfo(
"bob",
PlayerType.Human,
"bob_client",
"bob_id",
);
game.addPlayer(aliceInfo);
game.addPlayer(bobInfo);
game.addExecution(
new SpawnExecution(gameID, aliceInfo, game.ref(10, 10)),
new SpawnExecution(gameID, bobInfo, game.ref(16, 10)),
);
game.executeNextTick();
game.executeNextTick();
alice = game.player("alice_id");
bob = game.player("bob_id");
});
test("first toUpdate returns a full snapshot with empty collections", () => {
// executeNextTick calls toUpdate() for every player, so use a freshly
// added player whose update has never been built.
const charlieInfo = new PlayerInfo(
"charlie",
PlayerType.Human,
"charlie_client",
"charlie_id",
);
game.addPlayer(charlieInfo);
const charlie = game.player("charlie_id");
const full = charlie.toUpdate();
expect(full).not.toBeNull();
expect(full!.id).toBe("charlie_id");
expect(full!.name).toBe("charlie");
expect(full!.smallID).toBe(charlie.smallID());
expect(full!.allies).toEqual([]);
expect(full!.targets).toEqual([]);
expect(full!.embargoes).toEqual(new Set());
expect(full!.outgoingAttacks).toEqual([]);
expect(full!.incomingAttacks).toEqual([]);
expect(full!.outgoingAllianceRequests).toEqual([]);
expect(full!.alliances).toEqual([]);
expect(full!.outgoingEmojis).toEqual([]);
});
test("toUpdate returns null when nothing changed", () => {
alice.toUpdate(); // first full snapshot
expect(alice.toUpdate()).toBeNull();
expect(alice.toUpdate()).toBeNull();
});
test("primitive changes appear in the diff without unchanged collections", () => {
alice.toUpdate();
alice.addGold(123n);
const diff = alice.toUpdate();
expect(diff).not.toBeNull();
expect(diff!.gold).toBe(alice.gold());
// Unchanged collection fields must be absent from the diff.
expect(diff!.allies).toBeUndefined();
expect(diff!.embargoes).toBeUndefined();
expect(diff!.outgoingAttacks).toBeUndefined();
expect(diff!.alliances).toBeUndefined();
});
test("adding and removing an embargo shows up in consecutive diffs", () => {
alice.toUpdate();
alice.addEmbargo(bob, false);
let diff = alice.toUpdate();
expect(diff).not.toBeNull();
expect(diff!.embargoes).toEqual(new Set(["bob_id"]));
expect(alice.toUpdate()).toBeNull(); // stable until something changes
alice.stopEmbargo(bob);
diff = alice.toUpdate();
expect(diff).not.toBeNull();
expect(diff!.embargoes).toEqual(new Set());
});
test("an alliance shows up in allies and alliance views", () => {
alice.toUpdate();
bob.toUpdate();
const request = alice.createAllianceRequest(bob);
expect(request).not.toBeNull();
request!.accept();
const aliceDiff = alice.toUpdate();
expect(aliceDiff).not.toBeNull();
expect(aliceDiff!.allies).toEqual([bob.smallID()]);
expect(aliceDiff!.alliances).toHaveLength(1);
expect(aliceDiff!.alliances![0].other).toBe("bob_id");
const bobDiff = bob.toUpdate();
expect(bobDiff).not.toBeNull();
expect(bobDiff!.allies).toEqual([alice.smallID()]);
});
test("targeting a player appears in the diff", () => {
alice.toUpdate();
alice.target(bob);
const diff = alice.toUpdate();
expect(diff).not.toBeNull();
expect(diff!.targets).toEqual([bob.smallID()]);
});
test("attacks appear for attacker and defender through the tick pipeline", () => {
// Expand alice into terra nullius until she borders bob — a land attack
// on a non-adjacent player retreats immediately.
game.addExecution(
new AttackExecution(2000, alice, game.terraNullius().id()),
);
for (let i = 0; i < 30 && !alice.sharesBorderWith(bob); i++) {
game.executeNextTick();
}
expect(alice.sharesBorderWith(bob)).toBe(true);
game.addExecution(new AttackExecution(5000, alice, bob.id()));
// executeNextTick integrates toUpdate(), so read the emitted updates.
const updates = game.executeNextTick(); // attack initializes
const playerUpdates = updates[GameUpdateType.Player] as PlayerUpdate[];
const attackerUpdate = playerUpdates.find((u) => u.id === "alice_id");
expect(attackerUpdate).toBeDefined();
// The terra nullius expansion attack may still be running; assert on the
// attack against bob specifically.
const bobAttack = attackerUpdate!.outgoingAttacks!.find(
(a) => a.targetID === bob.smallID(),
);
expect(bobAttack).toBeDefined();
const defenderUpdate = playerUpdates.find((u) => u.id === "bob_id");
expect(defenderUpdate).toBeDefined();
expect(defenderUpdate!.incomingAttacks).toHaveLength(1);
expect(defenderUpdate!.incomingAttacks![0].attackerID).toBe(
alice.smallID(),
);
// As the attack progresses, troop counts change and must keep flowing
// through subsequent diffs.
const nextUpdates = game.executeNextTick();
const nextPlayerUpdates = nextUpdates[
GameUpdateType.Player
] as PlayerUpdate[];
const next = nextPlayerUpdates.find((u) => u.id === "alice_id");
expect(next).toBeDefined();
expect(
next!.outgoingAttacks!.some((a) => a.targetID === bob.smallID()),
).toBe(true);
});
test("in-worker mutation of shared empty collections fails loudly", () => {
const charlieInfo = new PlayerInfo(
"charlie2",
PlayerType.Human,
"charlie2_client",
"charlie2_id",
);
game.addPlayer(charlieInfo);
const full = game.player("charlie2_id").toUpdate()!;
// Empty collections are shared frozen singletons; a sloppy in-worker
// consumer must throw instead of silently corrupting every player's
// updates. (Updates crossing to the main thread are structured-cloned,
// so real consumers get mutable copies.)
expect(() => full.allies!.push(999)).toThrow();
expect(() => full.outgoingAttacks!.pop()).toThrow();
// And other players see no spurious changes.
expect(bob.toUpdate()).toBeNull();
});
});