mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 12:00:44 +00:00
Kyriakos Dimitriou
28e22c9ca8
## Description: This PR improves the public lobby join button UI by providing clearer, state-aware feedback while a player is waiting to enter a match. The button text now reflects two distinct phases of the join flow: - **Waiting for players** while the lobby is filling - **Starting game…** when the match is about to begin This removes ambiguity caused by relying only on button color changes and makes it immediately clear whether the join action has registered and what stage the lobby is currently in. ### Demo  ## How - Replaces the static **“Join next game”** label with dynamic text based on lobby state - Shows **“Waiting for players”** with an animated three-dot indicator while the lobby fills - Switches to **“Starting game…”** shortly before the match begins - Animation and state reset cleanly when leaving or cancelling - Uses existing lobby timing and state, with no additional network calls ## Notes - No CSS changes - No behavioral changes to matchmaking logic - Fully contained within `PublicLobby.ts` - Added translation keys for the updated indicators to `en.json` (Rest of language files will need to be updated) ## Testing notes During local testing (single-player, local server), the button text transitions as follows: - Initial state (not clicked): **“Join next game”** - After first click, the text briefly shows **“Starting game…”** - It then switches to **“Waiting for players”** with the animated dots - Shortly before the match starts, it switches back to **“Starting game…”** and proceeds to start a solo game Not sure why this flow happens in the testing environment: **“Join next game”** ->**“Starting game…”** (brief) -> **“Waiting for **players...”**** -> **“Starting game…”** (brief) instead of just: **“Join next game”** -> **“Waiting for **players...”**** -> **“Starting game…”** (brief) More testing is needed. ## Checklist - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [ ] I have added relevant tests to the test directory - [ ] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
