3 Commits

Include renames

Author	SHA1	Message	Date
evanpelle	e960b5130a	run formatter	2026-05-06 21:08:42 -06:00
3 people	eca5794ebb	Chore(deps): Update and remove dependencies (#3819) ... ## Description: Only mentioning removals/major updates/notable changes below, not all minor upgrades. ### Removed: - "@aws-sdk/client-s3": not used anywhere (was used in Archive.ts previously) - chai, "@types/chai", sinon-chai: not used anywhere, probably leftover. Vitest uses a bundled version of Chai for its expect asserations under the hood too. - protobufjs, "@types/google-protobuf": not used anywhere, probably left from evan's experiment with it? Removed from vite.config.ts too. - "@types/jquery": not used anywhere, probably leftover - sinon, "@types/sinon": not used anywhere just like chai, probably leftover. And Vitest provides us with the same functionality. - "@types/systeminformation": dependency systeminformation was removed last year, this is an unneeded, deprecated and unmaintained remainder. - vite-tsconfig-paths: removed, and removed the import and usage in vite.config.ts and replaced it by adding `tsconfigPaths: true` to the `resolve` block. Because of this message displayed on running the tests: "The plugin "vite-tsconfig-paths" is detected. Vite now supports tsconfig paths resolution natively via the resolve.tsconfigPaths option. You can remove the plugin and set resolve.tsconfigPaths: true in your Vite config instead." - vite-plugin-static-copy: removed, we don't use it anymore (was used in our vite.config.ts once,, probably before Vite natively supported copying static assets via its publicDir configuration) ### Updated: - color.js: v0.5 > v0.6, no breaking change affecting us - cross-env: v7 > v10. It's a publicly archived repo since Nov 2025. But before that he got it up-to-date from June 2025, porting to TS, dropping old Node versions, dependencies etc. Seems still good to use for some amount of time to come. - dotenv: v16 > v17, now logs an informational message by default when it loads an environment file. Can be disabled by using dotenv.config({quite: true}) if needed. - ejs: v3 > v5: security patches mostly. Vite still uses v3 btw. - eslint: v9 > v10. Newly enabled rules by default: 'no-unassigned-vars', 'no-useless-assignment' and 'preserve-caught-error'. Mostly faster and minimum support moved to higher node versions, which shouldn't be a problem. - "@eslint/compat": v1 > v2. Minimum supported Node versions, which should not be a problem. - intl-messageformat: v10 > v11 no breaking changes that affect us - jdom: v27 > v29. Faster. Most notably minimum support moved to higher node v22 version, which should not be a problem. Also, see types/node, kind of expecting v24 to be installed now. - nanoid: from v3 to v5, no breaking changes that affect us - "@opentelemetry/sdk-logs": now that addLogRecordProcessor is removed, changed Logger.ts to pass an (empty) provider array directly to the LoggerProvider constructor. Follows the changes in https://github.com/open-telemetry/opentelemetry-js/pull/5588 - "@tailwindcss/vite": supports vite v8 from 4.2.2, and a fix for it in 4.2.4 - tailwindcss: supports vite v8 from 4.2.2 -- in 4.1.15 (we were already above this version) break-words was deprecated in favor of wrap-break-word. But break-words, which we use in 15 places, will still work as expected (https://github.com/tailwindlabs/tailwindcss/pull/19157). Same goes for also deprecated "order-none". - "@types/node": from v22 to v24, assuming most now use node 24 - vite v7 > v8: -- is now on 8.0.10 so first bugs are out of it, while v8 itself also fixed a big number of bugs. -- in vite.config.ts, fixed Ts error/compilation issue by changing the manualChunks option in build.rollupOptions.output to use the function syntax, which is required by the updated types instead of the object syntax. - zod: no changes that affect us ### Prettier: Updated only because of (new because of update?) Prettier errors for files untouched in this PR originally: - PathFinder.Parabola.ts - WorkerMessages.ts - ClanModal.handlers.test.ts - ClanModal.rendering.test.ts‎ - CONTRIBUTING.md - README.md ### ESLint: Fixes needed to silence errors coming from newly enabled recommended rules 'no-useless-assignment' and 'preserve-caught-error': For 'no-useless-assignment' (default assignment never used because of unreachable code or they are guaranteed to get a value, so they can be undefinedat the start. Exception was AttackExecution, so made the default value of 0 the default case in the switch statement): - ClientGameRunner - GameModeSelector - NameBoxCalculator - StructureDrawingUtils - TerritoryLayer - Diagnostics - GameRunner - ColorAllocator - DefaultConfig - AttackExecution - AiAttackBehavior - Worker.worker - GamePreviewBuilder For 'preserve-caught-error', disabled the rule here because the possible fix `{cause: error}` was introduced in ES2022 while we're still on target ES2020 currently: - GameServer - Privilege _Error: The value assigned to 'gameMap' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'timeDisplay' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'scalingFactor' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'radius' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'teamColor' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'gl' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'power' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'tickExecutionDuration' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'selectedIndex' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'mag' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'speed' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'matchesCriteria' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'shouldContinue' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'description' is not used in subsequent statements. (no-useless-assignment) Error: There is no `cause` attached to the symptom error being thrown. (preserve-caught-error) Error: There is no `cause` attached to the symptom error being thrown. (preserve-caught-error)_ All tests pass. TypeScript and ESLint errors resolved. ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: tryout33 --------- Co-authored-by: Copilot <copilot@github.com>	2026-05-06 09:12:27 -06:00
Arkadiusz SygulskiandGitHub	0e3ced3bfa	Pathfinding Refactor pt. 2 (#2866) ... ## Playtest https://pf-pt-2.openfront.dev/ ## Pathfinding Refactor pt. 2 <img width="1536" height="1024" alt="image" src="https://github.com/user-attachments/assets/9477958e-54b7-4c83-b317-ba789e809e9e" /> This is a follow-up to a previous PR introducing pathfinding changes. This time, it introduces a complete refactor of `pathfinding` directory and breakdown into composable pieces. ### Unified PathFinder interface `PathFinder<T>` and `SteppingPathFinder<T>` are introduced to unify **all** pathfinding across the application. First one exposes complete path, while stepping variant allows the callee to iterate over the path by calling `.next`. All pathfinders share this one common interface, which makes them easy to use in any scenario - `PathFinding.Water(game).search(from, to)`. `SteppingPathFinder<T>` extends `PathFinder<T>` with an ability to iterate over the path. It handles caching, storing current index and invalidation. This allows the units to not care about the inner workings of the pathfinder and just call `pf.next(current, target)` and receive instructions on what to do next. ### Common entry point All pathfinders are now exposed from common `PathFinding` entrypoint: - `PathFinding.Water` - `PathFinding.Rail` - `PathFinding.Stations` - `PathFinding.Rail` Additional entry point is introduced for pathfinders which need to work both in the worker, but also on the frontend, which lacks `Game` interface. Currently only `UniversalPathFinding.Parabola` is available. ### Spatial Query New module has been introduced close to `pathfinding` - `SpatialQuery`. It aims to resolve any questions game may have about finding tiles meeting criteria. Currently `SpatialQuery.closestShore(player, target)` and `SpatialQuery.closestShoreByWater(player, target)` are available - they help answering questions about naval invasion: "What is the best landing location from user's click?" and "Which our tile should be used to launch the transport ship?". Under the hood they use very similar mechanics to pathfinding, so it felt right to put them close by. ### Modular architecture Pathfinders now support transformers: `MiniMapTransformer`, `ShoreCoercingTransformer`, `ComponentCheckTransformer`, `SmoothingTransformer`. Transformers functions like a middleware in the pathfinding chain. They wrap around the pathfinder and provide additional functionality. This allows the pathfinder to focus on actually finding the path instead of doing unrelated things. Example chain for simple (A*) water pathfinding: ```ts static WaterSimple(game: Game): SteppingPathFinder<TileRef> { const miniMap = game.miniMap(); const pf = new AStarWater(miniMap); return PathFinderBuilder.create(pf) .wrap((pf) => new ShoreCoercingTransformer(pf, miniMap)) .wrap((pf) => new MiniMapTransformer(pf, game.map(), miniMap)) .buildWithStepper(tileStepperConfig(game)); } ``` The Pathfinder - here `AStarWater` - does not care about the conversion between minimap and main map tiles. It also does not care if the source or destination is a land tile. The transformers take care of that. The pathfinder gets a set of valid coordinates and produces the path - that's it. Modular approach makes working on a particular set of utilities much easier - for example map upscaling is handled consistently across all pathfinders. Additionally, the pathfinders are not tied to the particular map resolution used. Pass them a different map and they will work the same. ### Algorithms Algorithms used are neatly organized inside `src/core/pathfinding/algorithms`. They are prefixed with the algorithm name and suffixed with the use case. File without suffix exposes generic version ready to traverse any graph with adapters. Specialized versions either use an adapter or inline logic when performance is critical - using adapters leads to 20-30% performance loss. The directory includes `A*` and `BFS` but also other useful utils, such as `AbstractGraph` used to generate... an abstract graph on top of the tile map and `ConnectedComponents` helping to identify whether two tiles are connected by a path without actually computing the path. ### Playground The playground have been updated with new algorithms, including tweaked very greedy `A*`. <img width="2175" height="1424" alt="image" src="https://github.com/user-attachments/assets/1f833651-0024-4299-bf86-882f5368358c" /> ### Tests Yeah, there are some, a little too many if I say so myself. But there are no useless tests. I had to ensure refactored code works somehow reliably. This PR comes with trust me bro guarantee, but I would appreciate someone confirming **naval invasions, nukes (esp. MIRV) and warships**. ### Discord `moleole` GL & HF	2026-01-11 20:11:14 -08:00