5 Commits

Author	SHA1	Message	Date
Evan	275fd0dccc	refactor: collapse per-env Configs into ClientEnv + ServerEnv (#3906) ... ## Description: This is a refactor to simplify config handling. Replaces the per-environment DevConfig/PreprodConfig/ProdConfig class hierarchy with two static classes: ClientEnv (browser main thread, reads from window.BOOTSTRAP_CONFIG) and ServerEnv (Node server, reads from process.env). The four config classes are deleted, the abstract DefaultServerConfig is gone, and DefaultConfig is renamed to Config. The values that flow server → client (gameEnv, numWorkers, turnstileSiteKey, jwtAudience, instanceId) used to be baked into the hardcoded per-env classes. They're now real env vars on the server, embedded into a single window.BOOTSTRAP_CONFIG object in index.html at request time (alongside the existing gitCommit/assetManifest/cdnBase globals, which moved into the same object), and read back by ClientEnv on the client. The dev defaults previously hidden inside DevServerConfig are now explicit in start:server-dev (NUM_WORKERS=2, TURNSTILE_SITE_KEY=1x..., JWT_AUDIENCE=localhost, etc.) and in vite.config.ts's html plugin inject.data. Production deploys plumb NUM_WORKERS and TURNSTILE_SITE_KEY through deploy.yml (GitHub vars) into the remote env file; JWT_AUDIENCE is derived from DOMAIN in deploy.sh. The dynamic /api/instance endpoint is gone — INSTANCE_ID rides along in BOOTSTRAP_CONFIG now. ServerEnv is the only thing server code touches; ClientEnv is browser-only. The two classes have intentional overlap (env, numWorkers, jwtIssuer, gameCreationRate, workerIndex, etc.) since they derive identical logic from different sources — there's a TODO in each to consolidate via a shared helper later. The game-logic Config no longer stores a ServerConfig/ClientEnv reference and its serverConfig() getter is gone; the one caller (MultiTabModal) now reads ClientEnv.env() directly. Worker init no longer carries server-config values since nothing in the worker actually reads them. ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: evan	2026-05-11 19:24:01 -07:00
evanpelle	4d0324c5cc	run formatter	2026-05-06 21:43:03 -06:00
evanpelle	e960b5130a	run formatter	2026-05-06 21:08:42 -06:00
VariableVince	eca5794ebb	Chore(deps): Update and remove dependencies (#3819) ... ## Description: Only mentioning removals/major updates/notable changes below, not all minor upgrades. ### Removed: - "@aws-sdk/client-s3": not used anywhere (was used in Archive.ts previously) - chai, "@types/chai", sinon-chai: not used anywhere, probably leftover. Vitest uses a bundled version of Chai for its expect asserations under the hood too. - protobufjs, "@types/google-protobuf": not used anywhere, probably left from evan's experiment with it? Removed from vite.config.ts too. - "@types/jquery": not used anywhere, probably leftover - sinon, "@types/sinon": not used anywhere just like chai, probably leftover. And Vitest provides us with the same functionality. - "@types/systeminformation": dependency systeminformation was removed last year, this is an unneeded, deprecated and unmaintained remainder. - vite-tsconfig-paths: removed, and removed the import and usage in vite.config.ts and replaced it by adding `tsconfigPaths: true` to the `resolve` block. Because of this message displayed on running the tests: "The plugin "vite-tsconfig-paths" is detected. Vite now supports tsconfig paths resolution natively via the resolve.tsconfigPaths option. You can remove the plugin and set resolve.tsconfigPaths: true in your Vite config instead." - vite-plugin-static-copy: removed, we don't use it anymore (was used in our vite.config.ts once,, probably before Vite natively supported copying static assets via its publicDir configuration) ### Updated: - color.js: v0.5 > v0.6, no breaking change affecting us - cross-env: v7 > v10. It's a publicly archived repo since Nov 2025. But before that he got it up-to-date from June 2025, porting to TS, dropping old Node versions, dependencies etc. Seems still good to use for some amount of time to come. - dotenv: v16 > v17, now logs an informational message by default when it loads an environment file. Can be disabled by using dotenv.config({quite: true}) if needed. - ejs: v3 > v5: security patches mostly. Vite still uses v3 btw. - eslint: v9 > v10. Newly enabled rules by default: 'no-unassigned-vars', 'no-useless-assignment' and 'preserve-caught-error'. Mostly faster and minimum support moved to higher node versions, which shouldn't be a problem. - "@eslint/compat": v1 > v2. Minimum supported Node versions, which should not be a problem. - intl-messageformat: v10 > v11 no breaking changes that affect us - jdom: v27 > v29. Faster. Most notably minimum support moved to higher node v22 version, which should not be a problem. Also, see types/node, kind of expecting v24 to be installed now. - nanoid: from v3 to v5, no breaking changes that affect us - "@opentelemetry/sdk-logs": now that addLogRecordProcessor is removed, changed Logger.ts to pass an (empty) provider array directly to the LoggerProvider constructor. Follows the changes in https://github.com/open-telemetry/opentelemetry-js/pull/5588 - "@tailwindcss/vite": supports vite v8 from 4.2.2, and a fix for it in 4.2.4 - tailwindcss: supports vite v8 from 4.2.2 -- in 4.1.15 (we were already above this version) break-words was deprecated in favor of wrap-break-word. But break-words, which we use in 15 places, will still work as expected (https://github.com/tailwindlabs/tailwindcss/pull/19157). Same goes for also deprecated "order-none". - "@types/node": from v22 to v24, assuming most now use node 24 - vite v7 > v8: -- is now on 8.0.10 so first bugs are out of it, while v8 itself also fixed a big number of bugs. -- in vite.config.ts, fixed Ts error/compilation issue by changing the manualChunks option in build.rollupOptions.output to use the function syntax, which is required by the updated types instead of the object syntax. - zod: no changes that affect us ### Prettier: Updated only because of (new because of update?) Prettier errors for files untouched in this PR originally: - PathFinder.Parabola.ts - WorkerMessages.ts - ClanModal.handlers.test.ts - ClanModal.rendering.test.ts‎ - CONTRIBUTING.md - README.md ### ESLint: Fixes needed to silence errors coming from newly enabled recommended rules 'no-useless-assignment' and 'preserve-caught-error': For 'no-useless-assignment' (default assignment never used because of unreachable code or they are guaranteed to get a value, so they can be undefinedat the start. Exception was AttackExecution, so made the default value of 0 the default case in the switch statement): - ClientGameRunner - GameModeSelector - NameBoxCalculator - StructureDrawingUtils - TerritoryLayer - Diagnostics - GameRunner - ColorAllocator - DefaultConfig - AttackExecution - AiAttackBehavior - Worker.worker - GamePreviewBuilder For 'preserve-caught-error', disabled the rule here because the possible fix `{cause: error}` was introduced in ES2022 while we're still on target ES2020 currently: - GameServer - Privilege _Error: The value assigned to 'gameMap' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'timeDisplay' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'scalingFactor' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'radius' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'teamColor' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'gl' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'power' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'tickExecutionDuration' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'selectedIndex' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'mag' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'speed' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'matchesCriteria' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'shouldContinue' is not used in subsequent statements. (no-useless-assignment) Error: The value assigned to 'description' is not used in subsequent statements. (no-useless-assignment) Error: There is no `cause` attached to the symptom error being thrown. (preserve-caught-error) Error: There is no `cause` attached to the symptom error being thrown. (preserve-caught-error)_ All tests pass. TypeScript and ESLint errors resolved. ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: tryout33 --------- Co-authored-by: Copilot <copilot@github.com>	2026-05-06 09:12:27 -06:00
Ryan	df05d21fc2	Clan System Part 2 - UI (#3625) ... ## Description: Continuation from #3276 Adds the complete client-side clan UI as a Lit web component (`<clan-modal>`), a typed API client with Zod-validated responses, shared response schemas, and a reusable `<confirm-dialog>` component. ### New: `ClanModal.ts` | View | What it does | |------|-------------| | **My Clans** | Lists joined clans + pending join requests (built from `/users/@me`, no extra fetches) | | **Browse** | Search by tag (min 3 chars), paginated results, configurable per-page (10/25/50) | | **Clan Detail** | Stats, paginated + searchable member list, role badges, join/leave/request actions | | **Manage** | Edit name (max 35 chars) + description, toggle open/invite-only, disband | | **Transfer** | Leadership transfer with member selector + confirmation | | **Requests** | Approve/deny join requests (leader/officer) | | **Bans** | View and unban (leader/officer) | | **My Requests** | View and withdraw outgoing requests | ### New: `ConfirmDialog.ts` Reusable `<confirm-dialog>` Lit component — replaces native `confirm()`/`prompt()` which are blocked or broken on mobile and CrazyGames iframes. Supports danger/warning variants and an optional textarea (used for ban reasons). Fires `confirm`/`cancel` events. ### New: `ClanApi.ts` Typed API client covering all clan endpoints. Every response is Zod-validated. Auth header is always last in the spread (can't be overridden by callers). Unknown server error messages always fall back to a generic client-side string — never displayed verbatim. ### New: `ClanApiSchemas.ts` (in `src/core/`) Shared Zod schemas for clan API responses with max-length constraints on `name` (35) and `description` (200). Lives in `core/` so it can be consumed by both client code and the leaderboard table. ### Modified: `ApiSchemas.ts` - Added `clans` and `clanRequests` arrays to `UserMeResponseSchema` - Moved clan leaderboard schemas out to `ClanApiSchemas.ts` - Renamed `LeaderboardClanTagSchema` → `RequiredClanTagSchema` ### Modified: `Api.ts` - Added `invalidateUserMe()` to bust the cached `/users/me` response after mutations - Removed `fetchClanLeaderboard` (moved to `ClanApi.ts`) ### Tests - `ClanModal.test.ts` — rendering, view navigation, user actions - `ClanApiQueries.test.ts` — fetch functions, error handling, pagination - `ClanApiMutations.test.ts` — join, leave, kick, ban, promote, transfer, etc. - `ClanApiBans.test.ts` — ban/unban calls and error paths - `ClanApiSchemas.test.ts` — Zod schema validation edge cases - `LeaderboardModal.test.ts` — updated imports ## Notable design decisions - **Not-logged-in state** — shows "Sign in to join clans" instead of false "no clans" empty state - **Rate limit feedback** — reads `Retry-After` header and surfaces wait time to the user ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: w.o.n --------- Co-authored-by: evanpelle <evanpelle@gmail.com>	2026-04-30 21:27:35 -06:00