Resolves#4450
## Description:
- Cosmetic updates to some existing maps using the new impassable
feature. This PR is focused on maps that require no resizing (no
increase in size) to accommodate decorative impassable map outlines. A
future PR will focus on maps that require resizing.
- Form follows function. Established "metro" map style by removing
excessive water off of maps, but going no further. Edits are simple and
repeatable, but also flow with the terrain of the map. This is NOT about
the removal of rectangular maps.
- Show off impassable feature on existing maps without changing game
play.
https://youtu.be/e1gsvjl-CGE
Maps Updated
baja
bosphoruss
didier
gateway
golfofstlawrence
iceland
juandefuca
lisbon
newyork
niledelta
northwestpass
oceania
san fran
south america
straitofmalacca
surrounded
tourney 1-4
## Please complete the following:
- [X] I have added screenshots for all UI updates
- [X] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [X] I have added relevant tests to the test directory
## Please put your Discord username so you can be contacted if a bug or
regression is found:
PlaysBadly
---------
Co-authored-by: RickD004 <realtacoco@gmail.com>
## Description:
To simply the map binary data, remove height & width data to the
manifest
## Please complete the following:
- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors
## Please put your Discord username so you can be contacted if a bug or
regression is found:
evan
## Description:
Move map generation outside of main repo, it has been rewritten in Go
and is much faster. Also refactor how maps are stored, one dir per map.
The map binaries are basically identical to before. Some maps like
Africa have 1% difference in bytes, but playing it looks exactly the
same.
Use lazy loading for map data access so only needed files are accessed.
Unit tests now load map binary instead of regenerating it from scratch,
speeding them up.
## Please complete the following:
- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors
## Please put your Discord username so you can be contacted if a bug or
regression is found:
evan
