Resolves#4450
## Description:
- Cosmetic updates to some existing maps using the new impassable
feature. This PR is focused on maps that require no resizing (no
increase in size) to accommodate decorative impassable map outlines. A
future PR will focus on maps that require resizing.
- Form follows function. Established "metro" map style by removing
excessive water off of maps, but going no further. Edits are simple and
repeatable, but also flow with the terrain of the map. This is NOT about
the removal of rectangular maps.
- Show off impassable feature on existing maps without changing game
play.
https://youtu.be/e1gsvjl-CGE
Maps Updated
baja
bosphoruss
didier
gateway
golfofstlawrence
iceland
juandefuca
lisbon
newyork
niledelta
northwestpass
oceania
san fran
south america
straitofmalacca
surrounded
tourney 1-4
## Please complete the following:
- [X] I have added screenshots for all UI updates
- [X] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [X] I have added relevant tests to the test directory
## Please put your Discord username so you can be contacted if a bug or
regression is found:
PlaysBadly
---------
Co-authored-by: RickD004 <realtacoco@gmail.com>
## Description:
QoL changes for the Bosphorus map.
The base image for the map had a little aliasing which resulted in some
rivers being cut off.
<img width="673" height="386" alt="image"
src="https://github.com/user-attachments/assets/b8ed181f-fbeb-4d6f-b7ab-a8b0ea300a22"
/>
All of the nations except istanbul also had absolutely nothing to do
with the region. For example, Varna is a city in Northeast bulgaria and
the aegean isles are also nowhere near. There was also a nation that did
not spawn because its coordinates were in the sea.
<img width="626" height="413" alt="image"
src="https://github.com/user-attachments/assets/a6537f79-3785-4316-8fd4-a99f55faff71"
/>
All of these poor designs are probably the result of the map being
resized, originally being a larger map. It probably explains why this is
the smallest map by land area (not counting Oceania)
Fixes:
- Fixed landlocked rivers and added More accurate bodies of water
- Complete remake of the nations. Nations are now far more accurately
placed districts of the region, and more evenly placed
<img width="664" height="407" alt="image"
src="https://github.com/user-attachments/assets/ff5a34fc-dea0-4a3d-b798-39d5711b91af"
/>
The data and gamestyle of this map should not change much, as the
landmasses remain in practice the same
## Please complete the following:
- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
## Please put your Discord username so you can be contacted if a bug or
regression is found:
tri.star1011
## Description:
Adds a new Bosphorus Map (Turkey). One of the key strategic locations in
the world and control access to the Black Sea. Smaller map that most to
facilitate smaller FFA and Team games. Added are a selection of nations
that correspond to the location.
<img width="1000" height="612" alt="image"
src="https://github.com/user-attachments/assets/27a6debc-a33b-4b54-b522-69ab814c39f0"
/>
## Please complete the following:
- [X] I have added screenshots for all UI updates
- [X] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [X] I have added relevant tests to the test directory
- [X] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
## Please put your Discord username so you can be contacted if a bug or
regression is found:
TSProphet
---------
Co-authored-by: Ryan <7389646+ryanbarlow97@users.noreply.github.com>
Co-authored-by: iamlewis <lewismmmm@gmail.com>
Patrick Plays Badly