alois/OpenFrontIO
1
0
Fork 0
mirror of https://github.com/openfrontio/OpenFrontIO.git synced 2026-06-21 16:30:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: crash when spectating (#232)

Browse Source 
Nuke icon patch added a crash when spectating game (myPlayer is NULL)
This commit is contained in:
Ilan Schemoul
2025-03-12 22:17:11 +01:00
committed by GitHub
parent 439f5af2bd
commit cef8a61d9c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/client/graphics/layers/NameLayer.ts
+3 -3
View File
@@ -418,7 +418,7 @@ export class NameLayer implements Layer {
const nukesSentByOtherPlayer = this.game.units().filter((unit) => {
const isSendingNuke = render.player.id() == unit.owner().id();
const notMyPlayer = unit.owner().id() != myPlayer.id();
const notMyPlayer = !myPlayer || unit.owner().id() != myPlayer.id();
return (
nukeTypes.includes(unit.type()) &&
isSendingNuke &&
@@ -429,7 +429,7 @@ export class NameLayer implements Layer {
const isMyPlayerTarget = nukesSentByOtherPlayer.find((unit) => {
const detonationDst = unit.detonationDst();
const targetId = this.game.owner(detonationDst).id();
return targetId == this.myPlayer.id();
return myPlayer && targetId == this.myPlayer.id();
});
const existingNuke = iconsDiv.querySelector(
'[data-icon="nuke"]',
@@ -449,7 +449,7 @@ export class NameLayer implements Layer {
) {
existingNuke.src = this.nukeWhiteIconImage.src;
}
} else if (myPlayer && nukesSentByOtherPlayer.length > 0) {
} else if (nukesSentByOtherPlayer.length > 0) {
if (!existingNuke) {
const icon = isMyPlayerTarget
? this.nukeRedIconImage.src