alois/OpenFrontIO
1
0
Fork 0
mirror of https://github.com/openfrontio/OpenFrontIO.git synced 2026-06-21 09:30:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: optimize terrain recomputation in TerritoryRenderer

Browse Source 
Updated the terrain recomputation logic to trigger asynchronously, improving performance by allowing rendering to continue without blocking. This change ensures that the terrain will be ready for the next frame, which may result in displaying stale terrain for one frame but enhances overall rendering efficiency.
This commit is contained in:
scamiv
2026-01-16 22:00:21 +01:00
parent d149ff48dd
commit c26acbda3a
1 changed files with 6 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/client/graphics/webgpu/TerritoryRenderer.ts
+6 -23
View File
@@ -425,31 +425,14 @@ export class TerritoryRenderer {
return;
}
// Check if terrain needs recomputation (e.g., theme changed)
// If so, compute it in the same command buffer before rendering
// If terrain needs recomputation, trigger it asynchronously (no blocking)
// It will be ready for the next frame, acceptable trade-off for performance
if (this.terrainComputePass?.needsUpdate()) {
this.resources.uploadTerrainParams();
// Use a single encoder to ensure compute completes before render
const encoder = this.device.device.createCommandEncoder();
// Execute terrain compute first
this.terrainComputePass.execute(encoder, this.resources);
// Then execute render passes in the same command buffer
// The render pass will rebuild its bind group, which will now use the updated terrain texture
const textureView = this.device.context.getCurrentTexture().createView();
for (const pass of this.renderPassOrder) {
if (!pass.needsUpdate()) {
continue;
}
pass.execute(encoder, this.resources, textureView);
}
// Submit single command buffer with both compute and render
// This ensures compute completes before render reads the terrain texture
this.device.device.queue.submit([encoder.finish()]);
return;
const computeEncoder = this.device.device.createCommandEncoder();
this.terrainComputePass.execute(computeEncoder, this.resources);
this.device.device.queue.submit([computeEncoder.finish()]);
// Continue with render - may show stale terrain for one frame, but better performance
}
const encoder = this.device.device.createCommandEncoder();