alois/OpenFrontIO
1
0
Fork 0
mirror of https://github.com/openfrontio/OpenFrontIO.git synced 2026-06-27 03:54:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable the no-undef eslint rule (#1848)

Browse Source 
## Description:

Enable the `no-undef` eslint rule.

Fixes #1786

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
This commit is contained in:
Scott Anderson
2025-08-17 19:42:45 -04:00
committed by GitHub
parent 002d450e8d
commit 62c08e25c2
15 changed files with 67 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
eslint.config.js
+15 -1
View File
@@ -3,6 +3,7 @@ import globals from "globals";
import path from "node:path";
import pluginJs from "@eslint/js";
import stylistic from "@stylistic/eslint-plugin";
import jest from "eslint-plugin-jest";
import tseslint from "typescript-eslint";
import { fileURLToPath } from "node:url";
import { includeIgnoreFile } from "@eslint/compat";
@@ -112,7 +113,7 @@ export default [
"object-curly-newline": ["error", { multiline: true, consistent: true }],
"object-curly-spacing": ["error", "always"],
"object-property-newline": ["error", { allowAllPropertiesOnSameLine: true }],
// "no-undef": "error", // TODO: Enable this rule, https://github.com/openfrontio/OpenFrontIO/issues/1786
"no-undef": "error",
"no-unused-vars": "off", // @typescript-eslint/no-unused-vars
"quote-props": ["error", "consistent-as-needed"],
// 'sort-imports': 'error', // TODO: Enable this rule, https://github.com/openfrontio/OpenFrontIO/issues/1787
@@ -142,6 +143,19 @@ export default [
"sort-keys": "off",
},
},
{
languageOptions: {
globals: {
...globals.jest,
},
},
files: [
"**/*.test.{js,ts,jsx,tsx}",
"tests/**/*.{js,ts,jsx,tsx}",
],
plugins: ["jest"],
...jest.configs['flat/style'],
},
{
files: [
"src/client/**/*.{js,ts,jsx,tsx}",
package-lock.json
Generated
+35 -19
View File
@@ -43,6 +43,7 @@
"@eslint/compat": "^1.2.7",
"@eslint/js": "^9.21.0",
"@stylistic/eslint-plugin": "^5.2.3",
"@swc/core": "^1.13.3",
"@swc/jest": "^0.2.39",
"@total-typescript/ts-reset": "^0.6.1",
"@types/benchmark": "^2.1.5",
@@ -74,6 +75,7 @@
"eslint": "^9.21.0",
"eslint-config-prettier": "^10.1.1",
"eslint-formatter-gha": "^1.5.2",
"eslint-plugin-jest": "^29.0.1",
"eslint-webpack-plugin": "^5.0.0",
"file-loader": "^6.2.0",
"globals": "^16.0.0",
@@ -3600,13 +3602,13 @@
}
},
"node_modules/@eslint/plugin-kit": {
"version": "0.3.2",
"resolved": "https://registry.npmjs.org/@eslint/plugin-kit/-/plugin-kit-0.3.2.tgz",
"integrity": "sha512-4SaFZCNfJqvk/kenHpI8xvN42DMaoycy4PzKc5otHxRswww1kAt82OlBuwRVLofCACCTZEcla2Ydxv8scMXaTg==",
"version": "0.3.5",
"resolved": "https://registry.npmjs.org/@eslint/plugin-kit/-/plugin-kit-0.3.5.tgz",
"integrity": "sha512-Z5kJ+wU3oA7MMIqVR9tyZRtjYPr4OC004Q4Rw7pgOKUOKkJfZ3O24nz3WYfGRpMDNmcOi3TwQOmgm7B7Tpii0w==",
"dev": true,
"license": "Apache-2.0",
"dependencies": {
"@eslint/core": "^0.15.0",
"@eslint/core": "^0.15.2",
"levn": "^0.4.1"
},
"engines": {
@@ -3614,9 +3616,9 @@
}
},
"node_modules/@eslint/plugin-kit/node_modules/@eslint/core": {
"version": "0.15.0",
"resolved": "https://registry.npmjs.org/@eslint/core/-/core-0.15.0.tgz",
"integrity": "sha512-b7ePw78tEWWkpgZCDYkbqDOP8dmM6qe+AOC6iuJqlq1R/0ahMAeH3qynpnqKFGkMltrp44ohV4ubGyvLX28tzw==",
"version": "0.15.2",
"resolved": "https://registry.npmjs.org/@eslint/core/-/core-0.15.2.tgz",
"integrity": "sha512-78Md3/Rrxh83gCxoUc0EiciuOHsIITzLy53m3d9UyiW8y9Dj2D29FeETqyKA+BRK76tnTp6RXWb3pCay8Oyomg==",
"dev": true,
"license": "Apache-2.0",
"dependencies": {
@@ -6415,7 +6417,6 @@
"devOptional": true,
"hasInstallScript": true,
"license": "Apache-2.0",
"peer": true,
"dependencies": {
"@swc/counter": "^0.1.3",
"@swc/types": "^0.1.23"
@@ -6460,7 +6461,6 @@
"os": [
"darwin"
],
"peer": true,
"engines": {
"node": ">=10"
}
@@ -6477,7 +6477,6 @@
"os": [
"darwin"
],
"peer": true,
"engines": {
"node": ">=10"
}
@@ -6494,7 +6493,6 @@
"os": [
"linux"
],
"peer": true,
"engines": {
"node": ">=10"
}
@@ -6511,7 +6509,6 @@
"os": [
"linux"
],
"peer": true,
"engines": {
"node": ">=10"
}
@@ -6528,7 +6525,6 @@
"os": [
"linux"
],
"peer": true,
"engines": {
"node": ">=10"
}
@@ -6545,7 +6541,6 @@
"os": [
"linux"
],
"peer": true,
"engines": {
"node": ">=10"
}
@@ -6562,7 +6557,6 @@
"os": [
"linux"
],
"peer": true,
"engines": {
"node": ">=10"
}
@@ -6579,7 +6573,6 @@
"os": [
"win32"
],
"peer": true,
"engines": {
"node": ">=10"
}
@@ -6596,7 +6589,6 @@
"os": [
"win32"
],
"peer": true,
"engines": {
"node": ">=10"
}
@@ -6613,7 +6605,6 @@
"os": [
"win32"
],
"peer": true,
"engines": {
"node": ">=10"
}
@@ -6649,7 +6640,6 @@
"integrity": "sha512-u1iIVZV9Q0jxY+yM2vw/hZGDNudsN85bBpTqzAQ9rzkxW9D+e3aEM4Han+ow518gSewkXgjmEK0BD79ZcNVgPw==",
"devOptional": true,
"license": "Apache-2.0",
"peer": true,
"dependencies": {
"@swc/counter": "^0.1.3"
}
@@ -11168,6 +11158,32 @@
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
}
},
"node_modules/eslint-plugin-jest": {
"version": "29.0.1",
"resolved": "https://registry.npmjs.org/eslint-plugin-jest/-/eslint-plugin-jest-29.0.1.tgz",
"integrity": "sha512-EE44T0OSMCeXhDrrdsbKAhprobKkPtJTbQz5yEktysNpHeDZTAL1SfDTNKmcFfJkY6yrQLtTKZALrD3j/Gpmiw==",
"dev": true,
"license": "MIT",
"dependencies": {
"@typescript-eslint/utils": "^8.0.0"
},
"engines": {
"node": "^20.12.0 || ^22.0.0 || >=24.0.0"
},
"peerDependencies": {
"@typescript-eslint/eslint-plugin": "^8.0.0",
"eslint": "^8.57.0 || ^9.0.0",
"jest": "*"
},
"peerDependenciesMeta": {
"@typescript-eslint/eslint-plugin": {
"optional": true
},
"jest": {
"optional": true
}
}
},
"node_modules/eslint-scope": {
"version": "8.4.0",
"resolved": "https://registry.npmjs.org/eslint-scope/-/eslint-scope-8.4.0.tgz",
package.json
+2
View File
@@ -30,6 +30,7 @@
"@eslint/compat": "^1.2.7",
"@eslint/js": "^9.21.0",
"@stylistic/eslint-plugin": "^5.2.3",
"@swc/core": "^1.13.3",
"@swc/jest": "^0.2.39",
"@total-typescript/ts-reset": "^0.6.1",
"@types/benchmark": "^2.1.5",
@@ -61,6 +62,7 @@
"eslint": "^9.21.0",
"eslint-config-prettier": "^10.1.1",
"eslint-formatter-gha": "^1.5.2",
"eslint-plugin-jest": "^29.0.1",
"eslint-webpack-plugin": "^5.0.0",
"file-loader": "^6.2.0",
"globals": "^16.0.0",
src/client/ClientGameRunner.ts
+1 -1
View File
@@ -193,7 +193,7 @@ export class ClientGameRunner {
private lastMousePosition: { x: number; y: number } | null = null;
private lastMessageTime = 0;
private connectionCheckInterval: NodeJS.Timeout | null = null;
private connectionCheckInterval: ReturnType<typeof setTimeout> | null = null;
constructor(
private lobby: LobbyConfig,
src/client/HostLobbyModal.ts
+1 -1
View File
@@ -55,7 +55,7 @@ export class HostLobbyModal extends LitElement {
@state() private lobbyCreatorClientID = "";
@state() private lobbyIdVisible = true;
private playersInterval: NodeJS.Timeout | null = null;
private playersInterval: ReturnType<typeof setTimeout> | null = null;
// Add a new timer for debouncing bot changes
private botsUpdateTimer: number | null = null;
private userSettings: UserSettings = new UserSettings();
src/client/InputHandler.ts
+1 -1
View File
@@ -129,7 +129,7 @@ export class InputHandler {
private alternateView = false;
private moveInterval: NodeJS.Timeout | null = null;
private moveInterval: ReturnType<typeof setTimeout> | null = null;
private activeKeys = new Set<string>();
private keybinds: Record<string, string> = {};
src/client/JoinPrivateLobbyModal.ts
+1 -1
View File
@@ -23,7 +23,7 @@ export class JoinPrivateLobbyModal extends LitElement {
@state() private hasJoined = false;
@state() private players: string[] = [];
private playersInterval: NodeJS.Timeout | null = null;
private playersInterval: ReturnType<typeof setTimeout> | null = null;
connectedCallback() {
super.connectedCallback();
src/client/LocalServer.ts
+1 -1
View File
@@ -35,7 +35,7 @@ export class LocalServer {
private turnsExecuted = 0;
private turnStartTime = 0;
private turnCheckInterval: NodeJS.Timeout;
private turnCheckInterval: ReturnType<typeof setTimeout>;
constructor(
private lobbyConfig: LobbyConfig,
src/client/graphics/TransformHandler.ts
+1 -1
View File
@@ -20,7 +20,7 @@ export class TransformHandler {
private lastGoToCallTime: number | null = null;
private target: Cell | null;
private intervalID: NodeJS.Timeout | null = null;
private intervalID: ReturnType<typeof setTimeout> | null = null;
private changed = false;
constructor(
tests/MissileSilo.test.ts
+2 -2
View File
@@ -91,7 +91,7 @@ describe("MissileSilo", () => {
});
test("missilesilo should have increased level after upgrade", async () => {
expect(attacker.units(UnitType.MissileSilo)[0].level()).toEqual(1);
expect(attacker.units(UnitType.MissileSilo)[0].level()).toBe(1);
const upgradeStructureExecution = new UpgradeStructureExecution(
attacker,
@@ -100,6 +100,6 @@ describe("MissileSilo", () => {
game.addExecution(upgradeStructureExecution);
executeTicks(game, 2);
expect(attacker.units(UnitType.MissileSilo)[0].level()).toEqual(2);
expect(attacker.units(UnitType.MissileSilo)[0].level()).toBe(2);
});
});
tests/PlayerImpl.test.ts
+1 -1
View File
@@ -96,7 +96,7 @@ describe("PlayerImpl", () => {
const ports = player.tradingPorts(playerPort);
expect(ports.length).toBe(3);
expect(ports).toHaveLength(3);
});
test("Can't send alliance requests when dead", () => {
tests/TeamAssignment.test.ts
+2 -2
View File
@@ -83,7 +83,7 @@ describe("assignTeams", () => {
expect(result.get(players[1])).toEqual(ColoredTeams.Red);
expect(result.get(players[2])).toEqual(ColoredTeams.Red);
expect(result.get(players[3])).toEqual("kicked");
expect(result.get(players[3])).toBe("kicked");
expect(result.get(players[4])).toEqual(ColoredTeams.Blue);
expect(result.get(players[5])).toEqual(ColoredTeams.Blue);
@@ -151,7 +151,7 @@ describe("assignTeams", () => {
expect(result.get(players[0])).toEqual(ColoredTeams.Red);
expect(result.get(players[1])).toEqual(ColoredTeams.Red);
expect(result.get(players[2])).toEqual("kicked");
expect(result.get(players[2])).toBe("kicked");
expect(result.get(players[3])).toEqual(ColoredTeams.Blue);
expect(result.get(players[4])).toEqual(ColoredTeams.Blue);
expect(result.get(players[5])).toEqual(ColoredTeams.Yellow);
tests/UnitGrid.test.ts
+1 -1
View File
@@ -90,7 +90,7 @@ describe("Unit Grid range tests", () => {
range,
units, // remove readonly
);
expect(result.length).toBe(expectedResult);
expect(result).toHaveLength(expectedResult);
},
);
tests/core/executions/SAMLauncherExecution.test.ts
+2 -2
View File
@@ -230,7 +230,7 @@ describe("SAM", () => {
test("SAM should have increased level after upgrade", async () => {
defender.buildUnit(UnitType.SAMLauncher, game.ref(1, 1), {});
expect(defender.units(UnitType.SAMLauncher)[0].level()).toEqual(1);
expect(defender.units(UnitType.SAMLauncher)[0].level()).toBe(1);
const upgradeStructureExecution = new UpgradeStructureExecution(
defender,
@@ -239,6 +239,6 @@ describe("SAM", () => {
game.addExecution(upgradeStructureExecution);
executeTicks(game, 2);
expect(defender.units(UnitType.SAMLauncher)[0].level()).toEqual(2);
expect(defender.units(UnitType.SAMLauncher)[0].level()).toBe(2);
});
});
tests/core/game/RailNetwork.test.ts
+1 -1
View File
@@ -42,7 +42,7 @@ describe("StationManagerImpl", () => {
const station = createMockStation(1);
manager.addStation(station);
manager.removeStation(station);
expect(manager.findStation(station.unit)).toBe(null);
expect(manager.findStation(station.unit)).toBeNull();
});
});