alois/OpenFrontIO
1
0
Fork 0
mirror of https://github.com/openfrontio/OpenFrontIO.git synced 2026-06-26 01:34:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix null vs undefined trade ship check

Browse Source
This commit is contained in:
evanpelle
2025-05-28 11:40:37 -07:00
parent 4fa31acc51
commit 5446620788
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/execution/TradeShipExecution.ts
+5 -5
View File
@@ -18,7 +18,7 @@ export class TradeShipExecution implements Execution {
private active = true;
private mg: Game;
private origOwner: Player;
private tradeShip: Unit;
private tradeShip: Unit | undefined;
private wasCaptured = false;
private pathFinder: PathFinder;
@@ -35,7 +35,7 @@ export class TradeShipExecution implements Execution {
}
tick(ticks: number): void {
if (this.tradeShip === null) {
if (this.tradeShip === undefined) {
const spawn = this.origOwner.canBuild(
UnitType.TradeShip,
this.srcPort.tile(),
@@ -126,7 +126,7 @@ export class TradeShipExecution implements Execution {
private complete() {
this.active = false;
this.tradeShip.delete(false);
this.tradeShip!.delete(false);
const gold = this.mg
.config()
.tradeShipGold(
@@ -134,11 +134,11 @@ export class TradeShipExecution implements Execution {
);
if (this.wasCaptured) {
this.tradeShip.owner().addGold(gold);
this.tradeShip!.owner().addGold(gold);
this.mg.displayMessage(
`Received ${renderNumber(gold)} gold from ship captured from ${this.origOwner.displayName()}`,
MessageType.SUCCESS,
this.tradeShip.owner().id(),
this.tradeShip!.owner().id(),
);
} else {
this.srcPort.owner().addGold(gold);