fixed giantworldmap key (#1188)

## Description:
Fixed an issue where key was being displayed in a place it shouldn’t
have been.

https://discord.com/channels/1284581928254701718/1284581928833388619/1383774883472740433

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

## Please put your Discord username so you can be contacted if a bug or
regression is found:

aotumuri

resources/lang/en.json

@@ -128,7 +128,7 @@
   "map": {
     "map": "Map",
     "world": "World",
-    "worldmapgiant": "Giant World Map",
+    "giantworldmap": "Giant World Map",
     "europe": "Europe",
     "mena": "MENA",
     "northamerica": "North America",

src/client/components/Maps.ts

@@ -6,7 +6,7 @@ import { getMapsImage } from "../utilities/Maps";
 // Add map descriptions
 export const MapDescription: Record<keyof typeof GameMapType, string> = {
   World: "World",
-  WorldMapGiant: "Giant World Map",
+  GiantWorldMap: "Giant World Map",
   Europe: "Europe",
   EuropeClassic: "Europe Classic",
   Mena: "MENA",

src/client/utilities/Maps.ts

@@ -29,7 +29,7 @@ export function getMapsImage(map: GameMapType): string {
   switch (map) {
     case GameMapType.World:
       return world;
-    case GameMapType.WorldMapGiant:
+    case GameMapType.GiantWorldMap:
       return worldmapgiant;
     case GameMapType.Oceania:
       return oceania;

src/core/configuration/DefaultConfig.ts

@@ -61,7 +61,7 @@ const numPlayersConfig = {
   [GameMapType.BlackSea]: [40, 50, 30],
   [GameMapType.Pangaea]: [40, 20, 30],
   [GameMapType.World]: [150, 80, 50],
-  [GameMapType.WorldMapGiant]: [150, 100, 60],
+  [GameMapType.GiantWorldMap]: [150, 100, 60],
   [GameMapType.Halkidiki]: [50, 40, 30],
 } as const satisfies Record<GameMapType, [number, number, number]>;
 

src/core/game/Game.ts

@@ -54,7 +54,7 @@ export const ColoredTeams: Record<string, Team> = {
 
 export enum GameMapType {
   World = "World",
-  WorldMapGiant = "Giant World Map",
+  GiantWorldMap = "Giant World Map",
   Europe = "Europe",
   EuropeClassic = "Europe Classic",
   Mena = "Mena",
@@ -82,7 +82,7 @@ export enum GameMapType {
 export const mapCategories: Record<string, GameMapType[]> = {
   continental: [
     GameMapType.World,
-    GameMapType.WorldMapGiant,
+    GameMapType.GiantWorldMap,
     GameMapType.NorthAmerica,
     GameMapType.SouthAmerica,
     GameMapType.Europe,

src/core/game/TerrainMapFileLoader.ts

@@ -24,7 +24,7 @@ interface NationMapModule {
 // Mapping from GameMap enum values to file names
 const MAP_FILE_NAMES: Record<GameMapType, string> = {
   [GameMapType.World]: "WorldMap",
-  [GameMapType.WorldMapGiant]: "WorldMapGiant",
+  [GameMapType.GiantWorldMap]: "WorldMapGiant",
   [GameMapType.Europe]: "Europe",
   [GameMapType.Mena]: "Mena",
   [GameMapType.NorthAmerica]: "NorthAmerica",