Strait of Malacca map adition (#3599)

## Description:
Adition of Strait of Malacca map

It adds a new map, requested by
Coolson
awildcoolson
Describe the PR.
The map added is a map inspired by the strait of Malacca, it contains
two large landmasses and some islands
## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced

## Please put your Discord username so you can be contacted if a bug or
regression is found:

lerithmercano

---------

Co-authored-by: Ricky G.P. <realtacoco@gmail.com>
Co-authored-by: VariableVince <24507472+VariableVince@users.noreply.github.com>

CREDITS.md

@@ -64,6 +64,14 @@ Licensed under [CC0 1.0.](https://creativecommons.org/publicdomain/zero/1.0/lega
 [NASA/JPL-Caltech](https://www.jpl.nasa.gov/images/pia10748-our-milky-way-gets-a-makeover-artist-concept/)
 [Public Domain](https://www.jpl.nasa.gov/jpl-image-use-policy/)
 
+### Strait Of Malacca Map
+
+[https://commons.wikimedia.org/wiki/User:Sadalmelik#/media/File:Sumatra_Topography.png](https://commons.wikimedia.org/wiki/File:Sumatra_Topography.png#/media/File:Sumatra_Topography.png)
+Sadalmelik - Own work
+Topographic map of Sumatra. Created with GMT from publicly released SRTM data. For locator version, see Image:Sumatra Locator Topography.png
+CC BY-SA 3.0
+File:Sumatra Topography.png
+
 ## Icons
 
 ### [The Noun Project](https://thenounproject.com/)

map-generator/assets/maps/straitofmalacca/info.json

@@ -0,0 +1,50 @@
+{
+  "name": "straitofmalacca",
+  "nations": [
+    {
+      "coordinates": [1268, 730],
+      "name": "Singapore",
+      "flag": "sg"
+    },
+    {
+      "coordinates": [862, 41],
+      "name": "Thailand",
+      "flag": "th"
+    },
+    {
+      "coordinates": [1328, 1284],
+      "name": "Sumatra",
+      "flag": "id"
+    },
+    {
+      "coordinates": [1141, 1090],
+      "name": "Burmese Pythons",
+      "flag": "mm"
+    },
+    {
+      "coordinates": [210, 243],
+      "name": "Aceh",
+      "flag": "id"
+    },
+    {
+      "coordinates": [1011, 736],
+      "name": "Riau",
+      "flag": "id"
+    },
+    {
+      "coordinates": [600, 565],
+      "name": "Samosir",
+      "flag": "id"
+    },
+    {
+      "coordinates": [827, 999],
+      "name": "Barisan",
+      "flag": "id"
+    },
+    {
+      "coordinates": [1053, 333],
+      "name": "Malaysia",
+      "flag": "my"
+    }
+  ]
+}

map-generator/main.go

@@ -50,6 +50,7 @@ var maps = []struct {
 	{Name: "japan"},
 	{Name: "lisbon"},
 	{Name: "manicouagan"},
+    {Name: "straitofmalacca"},
 	{Name: "mars"},
 	{Name: "mena"},
 	{Name: "montreal"},
@@ -86,7 +87,7 @@ var maps = []struct {
 	{Name: "milkyway"},
 	{Name: "mediterranean"},
 	{Name: "greatlakes"},
-  {Name: "dyslexdria"},
+    {Name: "dyslexdria"},
 	{Name: "big_plains", IsTest: true},
 	{Name: "half_land_half_ocean", IsTest: true},
 	{Name: "ocean_and_land", IsTest: true},

resources/lang/en.json

@@ -355,7 +355,8 @@
     "milkyway": "Milky Way",
     "mediterranean": "Mediterranean",
     "dyslexdria": "Dyslexdria",
-    "greatlakes": "Great Lakes"
+    "greatlakes": "Great Lakes",
+    "straitofmalacca": "Strait Of Malacca"
   },
   "map_categories": {
     "featured": "Featured",

resources/maps/straitofmalacca/manifest.json

@@ -0,0 +1,65 @@
+{
+  "map": {
+    "height": 1644,
+    "num_land_tiles": 867389,
+    "width": 1832
+  },
+  "map16x": {
+    "height": 411,
+    "num_land_tiles": 51062,
+    "width": 458
+  },
+  "map4x": {
+    "height": 822,
+    "num_land_tiles": 212395,
+    "width": 916
+  },
+  "name": "straitofmalacca",
+  "nations": [
+    {
+      "coordinates": [1268, 730],
+      "flag": "sg",
+      "name": "Singapore"
+    },
+    {
+      "coordinates": [862, 41],
+      "flag": "th",
+      "name": "Thailand"
+    },
+    {
+      "coordinates": [1328, 1284],
+      "flag": "id",
+      "name": "Sumatra"
+    },
+    {
+      "coordinates": [1141, 1090],
+      "flag": "mm",
+      "name": "Burmese Pythons"
+    },
+    {
+      "coordinates": [210, 243],
+      "flag": "id",
+      "name": "Aceh"
+    },
+    {
+      "coordinates": [1011, 736],
+      "flag": "id",
+      "name": "Riau"
+    },
+    {
+      "coordinates": [600, 565],
+      "flag": "id",
+      "name": "Samosir"
+    },
+    {
+      "coordinates": [827, 999],
+      "flag": "id",
+      "name": "Barisan"
+    },
+    {
+      "coordinates": [1053, 333],
+      "flag": "my",
+      "name": "Malaysia"
+    }
+  ]
+}

src/core/game/Game.ts

@@ -147,6 +147,7 @@ export enum GameMapType {
   Mediterranean = "Mediterranean",
   Dyslexdria = "Dyslexdria",
   GreatLakes = "Great Lakes",
+  StraitOfMalacca = "Strait Of Malacca",
 }
 
 export type GameMapName = keyof typeof GameMapType;
@@ -200,6 +201,7 @@ export const mapCategories: Record<string, GameMapType[]> = {
     GameMapType.Aegean,
     GameMapType.Mediterranean,
     GameMapType.GreatLakes,
+    GameMapType.StraitOfMalacca,
   ],
   fantasy: [
     GameMapType.Pangaea,

src/server/MapPlaylist.ts

@@ -88,6 +88,7 @@ const frequency: Partial<Record<GameMapName, number>> = {
   Mediterranean: 6,
   Dyslexdria: 8,
   GreatLakes: 6,
+  StraitOfMalacca: 4,
 };
 
 const TEAM_WEIGHTS: { config: TeamCountConfig; weight: number }[] = [