Multiple terrain changes and fixes for maps (#4502)

## Description:

Multiple changes for maps:

Mississippi - Fix some landlocked lakes, near the main coast. Players
would sometimes accidentally put a port in the dead lakes

North America - Re-add the Azores and Cape verde (accidentally removed
when the map generator got updated to delete small islands)

Africa - Re-add Ascencion and Saint Helena Islands, same case as NA

Danish Straits - replace german empire flag , as agreed in the leads
channel

Giant World Map - Coast fixes, including adding Suez Canal which greatly
affected trade routes

Great Lakes - fix landlocked lake

Two Lakes - New Terrain combining both old and recent versions

World - Add strait of malacca

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory

## Please put your Discord username so you can be contacted if a bug or
regression is found:

tri.star1011

map-generator/assets/maps/africa/info.json

@@ -185,6 +185,46 @@
       "coordinates": [876, 1049],
       "name": "Gabon",
       "flag": "ga"
+    },
+    {
+      "coordinates": [355, 1500],
+      "name": "Saint Helena",
+      "flag": "sh"
+    },
+    {
+      "coordinates": [127, 279],
+      "name": "Canary Islands",
+      "flag": "ic"
+    },
+    {
+      "coordinates": [1428, 90],
+      "name": "Cyprus",
+      "flag": "cy"
+    },
+    {
+      "coordinates": [1707, 1381],
+      "name": "Comoros",
+      "flag": "km"
+    },
+    {
+      "coordinates": [1758, 1411],
+      "name": "Mayotte",
+      "flag": "yt"
+    },
+    {
+      "coordinates": [117, 1278],
+      "name": "Ascension Island",
+      "flag": "sh-ac"
+    },
+    {
+      "coordinates": [756, 964],
+      "name": "Equatorial Guinea",
+      "flag": "gq"
+    },
+    {
+      "coordinates": [697, 1053],
+      "name": "Sao Tome and Principe",
+      "flag": "st"
     }
   ]
 }

map-generator/assets/maps/danishstraits/info.json

@@ -78,7 +78,7 @@
     {
       "coordinates": [585, 1182],
       "name": "Mecklenburg-Schwerin",
-      "flag": "German Empire"
+      "flag": "German Confederation"
     },
     {
       "coordinates": [846, 1131],
@@ -88,12 +88,12 @@
     {
       "coordinates": [59, 1201],
       "name": "Oldenburg",
-      "flag": "German Empire"
+      "flag": "German Confederation"
     },
     {
       "coordinates": [302, 1143],
       "name": "Hamburg",
-      "flag": "German Empire"
+      "flag": "German Confederation"
     },
     {
       "coordinates": [219, 1205],

map-generator/assets/maps/northamerica/info.json

@@ -350,6 +350,16 @@
       "coordinates": [1811, 782],
       "name": "Massachusetts",
       "flag": "Massachusetts"
+    },
+    {
+      "coordinates": [2719, 1264],
+      "name": "Cabo Verde",
+      "flag": "cv"
+    },
+    {
+      "coordinates": [2638, 840],
+      "name": "Azores",
+      "flag": "pt-azores"
     }
   ]
 }

map-generator/assets/maps/twolakes/info.json

@@ -3,7 +3,7 @@
   "name": "Two Lakes",
   "translation_key": "map.twolakes",
   "categories": ["europe"],
-  "multiplayer_frequency": 6,
+  "multiplayer_frequency": 4,
   "nations": [
     {
       "coordinates": [1025, 750],

resources/countries.json

@@ -134,8 +134,14 @@
   },
   {
     "code": "aq",
+    "continent": "Antarctica",
     "name": "Antarctica"
   },
+  {
+    "code": "Antarctica (True South)",
+    "continent": "Antarctica",
+    "name": "True South"
+  },
   {
     "code": "antipope",
     "continent": "Europe",
@@ -246,6 +252,11 @@
     "continent": "Asia",
     "name": "Azerbaijan SSR"
   },
+  {
+    "code": "pt-azores",
+    "continent": "Europe",
+    "name": "Azores"
+  },
   {
     "code": "Aztec Empire",
     "continent": "North America",
@@ -354,6 +365,11 @@
     "continent": "South America",
     "name": "Brazil"
   },
+  {
+    "code": "British Antarctic Territory",
+    "continent": "Antarctica",
+    "name": "British Antarctic Territory"
+  },
   {
     "code": "britishcolumbia",
     "continent": "North America",
@@ -1015,6 +1031,11 @@
     "continent": "Asia",
     "name": "Georgian SSR"
   },
+  {
+    "code": "German Confederation",
+    "continent": "Europe",
+    "name": "German Confederation"
+  },
   {
     "code": "German Empire",
     "continent": "Europe",

resources/maps/africa/manifest.json

@@ -4,7 +4,7 @@
   "id": "Africa",
   "map": {
     "height": 2032,
-    "num_land_tiles": 2183186,
+    "num_land_tiles": 2183279,
     "width": 1948
   },
   "map16x": {
@@ -199,6 +199,46 @@
       "coordinates": [876, 1049],
       "flag": "ga",
       "name": "Gabon"
+    },
+    {
+      "coordinates": [355, 1500],
+      "flag": "sh",
+      "name": "Saint Helena"
+    },
+    {
+      "coordinates": [127, 279],
+      "flag": "ic",
+      "name": "Canary Islands"
+    },
+    {
+      "coordinates": [1428, 90],
+      "flag": "cy",
+      "name": "Cyprus"
+    },
+    {
+      "coordinates": [1707, 1381],
+      "flag": "km",
+      "name": "Comoros"
+    },
+    {
+      "coordinates": [1758, 1411],
+      "flag": "yt",
+      "name": "Mayotte"
+    },
+    {
+      "coordinates": [117, 1278],
+      "flag": "sh-ac",
+      "name": "Ascension Island"
+    },
+    {
+      "coordinates": [756, 964],
+      "flag": "gq",
+      "name": "Equatorial Guinea"
+    },
+    {
+      "coordinates": [697, 1053],
+      "flag": "st",
+      "name": "Sao Tome and Principe"
     }
   ],
   "translation_key": "map.africa"

resources/maps/danishstraits/manifest.json

@@ -91,7 +91,7 @@
     },
     {
       "coordinates": [585, 1182],
-      "flag": "German Empire",
+      "flag": "German Confederation",
       "name": "Mecklenburg-Schwerin"
     },
     {
@@ -101,12 +101,12 @@
     },
     {
       "coordinates": [59, 1201],
-      "flag": "German Empire",
+      "flag": "German Confederation",
       "name": "Oldenburg"
     },
     {
       "coordinates": [302, 1143],
-      "flag": "German Empire",
+      "flag": "German Confederation",
       "name": "Hamburg"
     },
     {

resources/maps/giantworldmap/manifest.json

@@ -3,17 +3,17 @@
   "id": "GiantWorldMap",
   "map": {
     "height": 1948,
-    "num_land_tiles": 2333974,
+    "num_land_tiles": 2335403,
     "width": 4108
   },
   "map16x": {
     "height": 487,
-    "num_land_tiles": 132854,
+    "num_land_tiles": 132766,
     "width": 1027
   },
   "map4x": {
     "height": 974,
-    "num_land_tiles": 563340,
+    "num_land_tiles": 563303,
     "width": 2054
   },
   "multiplayer_frequency": 10,

resources/maps/greatlakes/manifest.json

@@ -3,17 +3,17 @@
   "id": "GreatLakes",
   "map": {
     "height": 1300,
-    "num_land_tiles": 1938066,
+    "num_land_tiles": 1938051,
     "width": 2000
   },
   "map16x": {
     "height": 325,
-    "num_land_tiles": 115500,
+    "num_land_tiles": 115497,
     "width": 500
   },
   "map4x": {
     "height": 650,
-    "num_land_tiles": 476275,
+    "num_land_tiles": 476259,
     "width": 1000
   },
   "multiplayer_frequency": 6,

resources/maps/mississippiriver/manifest.json

@@ -260,17 +260,17 @@
   "id": "MississippiRiver",
   "map": {
     "height": 4200,
-    "num_land_tiles": 1499924,
+    "num_land_tiles": 1500944,
     "width": 400
   },
   "map16x": {
     "height": 1050,
-    "num_land_tiles": 90268,
+    "num_land_tiles": 90334,
     "width": 100
   },
   "map4x": {
     "height": 2100,
-    "num_land_tiles": 369917,
+    "num_land_tiles": 370175,
     "width": 200
   },
   "multiplayer_frequency": 3,

resources/maps/northamerica/manifest.json

@@ -4,7 +4,7 @@
   "id": "NorthAmerica",
   "map": {
     "height": 1448,
-    "num_land_tiles": 1243623,
+    "num_land_tiles": 1243929,
     "width": 2800
   },
   "map16x": {
@@ -364,6 +364,16 @@
       "coordinates": [1811, 782],
       "flag": "Massachusetts",
       "name": "Massachusetts"
+    },
+    {
+      "coordinates": [2719, 1264],
+      "flag": "cv",
+      "name": "Cabo Verde"
+    },
+    {
+      "coordinates": [2638, 840],
+      "flag": "pt-azores",
+      "name": "Azores"
     }
   ],
   "translation_key": "map.northamerica"

resources/maps/twolakes/manifest.json

@@ -3,20 +3,20 @@
   "id": "TwoLakes",
   "map": {
     "height": 1840,
-    "num_land_tiles": 3423870,
+    "num_land_tiles": 3426935,
     "width": 2100
   },
   "map16x": {
     "height": 460,
-    "num_land_tiles": 211651,
+    "num_land_tiles": 211859,
     "width": 525
   },
   "map4x": {
     "height": 920,
-    "num_land_tiles": 852792,
+    "num_land_tiles": 853578,
     "width": 1050
   },
-  "multiplayer_frequency": 6,
+  "multiplayer_frequency": 4,
   "name": "Two Lakes",
   "nations": [
     {

resources/maps/world/manifest.json

@@ -4,17 +4,17 @@
   "id": "World",
   "map": {
     "height": 1000,
-    "num_land_tiles": 651609,
+    "num_land_tiles": 651569,
     "width": 2000
   },
   "map16x": {
     "height": 250,
-    "num_land_tiles": 37580,
+    "num_land_tiles": 37575,
     "width": 500
   },
   "map4x": {
     "height": 500,
-    "num_land_tiles": 158086,
+    "num_land_tiles": 158068,
     "width": 1000
   },
   "multiplayer_frequency": 20,

src/core/game/Maps.gen.ts

@@ -835,7 +835,7 @@ export const maps: readonly MapInfo[] = [
     type: GameMapType.TwoLakes,
     translationKey: "map.twolakes",
     categories: ["europe"],
-    multiplayerFrequency: 6,
+    multiplayerFrequency: 4,
   },
   {
     id: "UnitedStates",