fix ally request svg aspect ratio (#1731)

## Description:

The alliance icon was appearing squished in the radial menu because the
SVG was being forced into a 32x32 square without proper aspect ratio
preservation.

Change:
Added `viewBox="0 0 834 528"` and `preserveAspectRatio="xMidYMid meet"`
to the SVG element, which maintains the original aspect ratio (1.58:1)
when scaled to fit the allocated space.

After changes:
[
<img width="166" height="184" alt="Screenshot 2025-08-07 at 4 52 15 PM"
src="https://github.com/user-attachments/assets/c1438b4d-9302-4a2b-8e25-c6d289e7148e"
/>
](url)

Refer to the issue for before.

Fixes #1730 

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I have read and accepted the CLA agreement (only required once).

## Please put your Discord username so you can be contacted if a bug or
regression is found:

phantom845

Co-authored-by: Kanishk-T <kanishk.tyagi@yugen.ai>
This commit is contained in:
kanishk tyagi
2025-08-18 12:48:16 +05:30
committed by GitHub
parent 53fbde07dc
commit 21c4a76c16
+1 -1
View File
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg xmlns="http://www.w3.org/2000/svg" version="1.1" width="834px" height="528px" style="shape-rendering:geometricPrecision; text-rendering:geometricPrecision; image-rendering:optimizeQuality; fill-rule:evenodd; clip-rule:evenodd" xmlns:xlink="http://www.w3.org/1999/xlink">
<svg xmlns="http://www.w3.org/2000/svg" version="1.1" width="834px" height="528px" viewBox="0 0 834 528" preserveAspectRatio="xMidYMid meet" style="shape-rendering:geometricPrecision; text-rendering:geometricPrecision; image-rendering:optimizeQuality; fill-rule:evenodd; clip-rule:evenodd" xmlns:xlink="http://www.w3.org/1999/xlink">
<g><path style="opacity:1" fill="#fdfdfd" d="M 135.5,-0.5 C 137.167,-0.5 138.833,-0.5 140.5,-0.5C 159.768,12.1427 179.434,24.3094 199.5,36C 201.584,37.5007 202.917,39.5007 203.5,42C 159.221,122.06 114.554,201.893 69.5,281.5C 67.9991,282.752 66.3325,283.752 64.5,284.5C 42.3037,271.908 20.637,258.575 -0.5,244.5C -0.5,242.833 -0.5,241.167 -0.5,239.5C 44.818,159.535 90.1513,79.5352 135.5,-0.5 Z"/></g>
<g><path style="opacity:1" fill="#fdfdfd" d="M 692.5,-0.5 C 694.167,-0.5 695.833,-0.5 697.5,-0.5C 742.849,79.5352 788.182,159.535 833.5,239.5C 833.5,241.167 833.5,242.833 833.5,244.5C 812.581,258.234 791.248,271.401 769.5,284C 767.536,284.624 765.869,284.124 764.5,282.5C 718.86,202.722 673.86,122.555 629.5,42C 630.083,39.5007 631.416,37.5007 633.5,36C 653.566,24.3094 673.232,12.1427 692.5,-0.5 Z"/></g>
<g><path style="opacity:1" fill="#fdfdfd" d="M 432.5,64.5 C 454.565,63.9178 476.565,64.7512 498.5,67C 526.867,72.5085 555.2,78.1752 583.5,84C 589.167,84.6667 594.833,84.6667 600.5,84C 610.347,82.4512 620.014,80.4512 629.5,78C 665.047,139.944 699.88,202.11 734,264.5C 723.137,275.697 711.971,286.53 700.5,297C 693.085,302.46 685.252,307.293 677,311.5C 597.446,244.776 511.279,187.609 418.5,140C 414.302,137.486 409.802,135.653 405,134.5C 390.991,138.461 377.158,142.961 363.5,148C 349.788,168.712 332.455,185.712 311.5,199C 297.958,206.51 283.458,210.677 268,211.5C 264.417,210.942 260.917,210.109 257.5,209C 255.418,206.591 254.418,203.757 254.5,200.5C 255.061,194.256 256.561,188.256 259,182.5C 280.319,148.023 303.486,114.856 328.5,83C 339.522,77.3271 351.188,73.6604 363.5,72C 386.537,68.431 409.537,65.931 432.5,64.5 Z"/></g>

Before

Width:  |  Height:  |  Size: 5.1 KiB

After

Width:  |  Height:  |  Size: 5.1 KiB