alois/OpenFrontIO
1
0
Fork 0
mirror of https://github.com/openfrontio/OpenFrontIO.git synced 2026-06-21 09:30:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address namelayer asset builder review nits

Browse Source 
Pass the pinned Twemoji font path to FontLibrary.use as an explicit path array, name the color-detection threshold used by atlas validation, and make SVG viewBox width/height extraction easier to read.

Validated with the namelayer asset build and eslint for scripts/build-namelayer-assets.mjs.
This commit is contained in:
scamiv
2026-05-09 15:32:43 +02:00
parent 28bae2d7eb
commit 199ef64a19
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/build-namelayer-assets.mjs
+8 -9
View File
@@ -17,6 +17,7 @@ const emojiFontFamily = "NameLayerEmoji";
const emojiFontPath = require.resolve("twemoji-colr-font/twemoji.woff2");
const emojiFontSize = 96;
const atlasFramePaddingRatio = 1 / 16;
const colorDetectionThreshold = 12;
const fontSourceCandidates = [
"overpass-regular.otf",
"overpass-regular.ttf",
@@ -51,7 +52,7 @@ const iconSources = [
fs.mkdirSync(fontsDir, { recursive: true });
fs.mkdirSync(imagesDir, { recursive: true });
FontLibrary.use(emojiFontFamily, emojiFontPath);
FontLibrary.use(emojiFontFamily, [emojiFontPath]);
await buildMsdfFont();
await buildIconAtlas();
@@ -188,14 +189,12 @@ async function loadIconImage(sourcePath) {
let svg = fs.readFileSync(sourcePath, "utf8");
if (!/<svg[^>]*\swidth=/i.test(svg) || !/<svg[^>]*\sheight=/i.test(svg)) {
const [, , , width, height] =
svg.match(
/viewBox=["']\s*([-\d.]+)\s+([-\d.]+)\s+([-\d.]+)\s+([-\d.]+)\s*["']/i,
) ?? [];
svg = svg.replace(
/<svg\b/i,
`<svg width="${width ?? 64}" height="${height ?? 64}"`,
const viewBoxMatch = svg.match(
/viewBox=["']\s*([-\d.]+)\s+([-\d.]+)\s+([-\d.]+)\s+([-\d.]+)\s*["']/i,
);
const width = viewBoxMatch?.[3] ?? 64;
const height = viewBoxMatch?.[4] ?? 64;
svg = svg.replace(/<svg\b/i, `<svg width="${width}" height="${height}"`);
}
return loadImage(Buffer.from(svg, "utf8"));
@@ -357,7 +356,7 @@ function validateAtlasFramesPixels(
continue;
}
alphaPixels++;
if (Math.max(r, g, b) - Math.min(r, g, b) > 12) {
if (Math.max(r, g, b) - Math.min(r, g, b) > colorDetectionThreshold) {
colorfulPixels++;
}
}