mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 07:50:45 +00:00
Generate a single MapInfo list; move SPECIAL_TEAM_MAPS and en.json map names into info.json (#4231)
**Add approved & assigned issue number here:** N/A — maintainer follow-up to #4227. ## Description: Follow-up to #4227, finishing the "info.json is the single source of truth" refactor. **Maps.gen.ts now generates one `MapInfo` interface and a `maps` list** instead of parallel lookup records. `mapCategories`, `mapTranslationKeys`, and `multiplayerFrequency` are gone — consumers read the list directly (`map.categories`, `map.translationKey`, `map.multiplayerFrequency`). MapPicker got simpler in the process: it renders from `MapInfo` objects, so the reverse `Object.entries(GameMapType)` lookup to recover the enum key is gone. The featured-rank sort moved out of the Go codegen into the picker, where the presentation concern belongs. **`SPECIAL_TEAM_MAPS` moves into info.json** as an optional `special_team_count` field (set on the same 17 maps with the same values). MapPlaylist derives its map from the generated list; `SPECIAL_TEAM_FORCE_CHANCE` and the frequency multiplier behavior are unchanged. **The en.json `map` section is now generated.** A new optional `display_name` field in info.json (defaulting to `name`) is written to `resources/lang/en.json` by the generator, preserving the section's non-map UI keys (`map`, `featured`, `all`, `favorites`, `random`). The 8 maps whose English display name intentionally differs from the frozen enum value (e.g. `MENA`, `Milky Way`, `Europe (Classic)`, `Baikal (Nuke Wars)`) declare it via `display_name`, so no display text changes. The section is emitted alphabetically; since #4232 already sorted en.json and every value matches, regeneration is byte-identical and this PR has no en.json diff. Other languages remain Crowdin-managed. The generator also now validates `translation_key` is exactly `map.<folder>` and `special_team_count >= 2`. MapConsistency tests compare info.json directly against the generated list and the en.json section, and fail with a "run `npm run gen-maps`" message on drift. No behavior changes: enum values, playlist frequencies, special-team counts, featured order, and display names are all byte-identical. ## Please complete the following: - [x] I have added screenshots for all UI updates (no UI changes — internal refactor, rendering output identical) - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory ## Please put your Discord username so you can be contacted if a bug or regression is found: evanpelle 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -140,6 +140,7 @@
|
||||
"name": "Carpathos"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
{
|
||||
"categories": ["europe"],
|
||||
"display_name": "Archipelago Sea",
|
||||
"id": "ArchipelagoSea",
|
||||
"map": {
|
||||
"height": 1508,
|
||||
|
||||
@@ -75,6 +75,7 @@
|
||||
"name": "Listvyanka"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
{
|
||||
"categories": ["other"],
|
||||
"display_name": "Baikal (Nuke Wars)",
|
||||
"id": "BaikalNukeWars",
|
||||
"map": {
|
||||
"height": 1564,
|
||||
|
||||
@@ -140,6 +140,7 @@
|
||||
"name": "Magadan"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -30,6 +30,7 @@
|
||||
"name": "Russia"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -130,6 +130,7 @@
|
||||
"name": "Esenyurt"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
{
|
||||
"categories": ["europe"],
|
||||
"display_name": "Britannia (Classic)",
|
||||
"id": "BritanniaClassic",
|
||||
"map": {
|
||||
"height": 1396,
|
||||
|
||||
@@ -323,6 +323,7 @@
|
||||
"name": "Keeko"
|
||||
}
|
||||
],
|
||||
"special_team_count": 4,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -120,6 +120,7 @@
|
||||
"name": "Dioumaya"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
{
|
||||
"categories": ["other"],
|
||||
"display_name": "Didier (France)",
|
||||
"id": "DidierFrance",
|
||||
"map": {
|
||||
"height": 2248,
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
{
|
||||
"categories": ["europe"],
|
||||
"display_name": "Europe (Classic)",
|
||||
"id": "EuropeClassic",
|
||||
"map": {
|
||||
"height": 1000,
|
||||
|
||||
@@ -80,6 +80,7 @@
|
||||
"name": "San Carlos"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -40,6 +40,7 @@
|
||||
"name": "Myrkwind"
|
||||
}
|
||||
],
|
||||
"special_team_count": 4,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -150,6 +150,7 @@
|
||||
"name": "Yarmouth"
|
||||
}
|
||||
],
|
||||
"special_team_count": 3,
|
||||
"teamGameSpawnAreas": {
|
||||
"3": [
|
||||
{
|
||||
|
||||
@@ -322,6 +322,7 @@
|
||||
"name": "Arlington"
|
||||
}
|
||||
],
|
||||
"special_team_count": 3,
|
||||
"teamGameSpawnAreas": {
|
||||
"3": [
|
||||
{
|
||||
|
||||
@@ -145,6 +145,7 @@
|
||||
"name": "ΜΟΝΟʟΙȚΗ"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
{
|
||||
"categories": ["asia", "africa"],
|
||||
"display_name": "MENA",
|
||||
"id": "Mena",
|
||||
"map": {
|
||||
"height": 964,
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
{
|
||||
"categories": ["cosmic"],
|
||||
"display_name": "Milky Way",
|
||||
"id": "MilkyWay",
|
||||
"map": {
|
||||
"height": 1500,
|
||||
|
||||
@@ -100,6 +100,7 @@
|
||||
"name": "Free Pluto State"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -157,6 +157,7 @@
|
||||
}
|
||||
],
|
||||
"categories": ["asia"],
|
||||
"display_name": "Southeast Asia",
|
||||
"id": "SoutheastAsia",
|
||||
"map": {
|
||||
"height": 1672,
|
||||
|
||||
@@ -52,6 +52,7 @@
|
||||
"name": "Andalusia"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -125,6 +125,7 @@
|
||||
"name": "Bahrain"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -60,6 +60,7 @@
|
||||
"name": "Rugged Islander"
|
||||
}
|
||||
],
|
||||
"special_team_count": 4,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
@@ -85,6 +85,7 @@
|
||||
"name": "Harborwick"
|
||||
}
|
||||
],
|
||||
"special_team_count": 2,
|
||||
"teamGameSpawnAreas": {
|
||||
"2": [
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user