mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 09:20:47 +00:00
Remove unused Structure Sprites setting
The structureSprites toggle was only read by the toggle UIs themselves — no rendering code ever consulted it. Drops the getter/setter from UserSettings, both toggle rows (SettingsModal + UserSettingModal), and the en.json keys. Other-language entries are left for Crowdin to reap.
This commit is contained in:
@@ -800,8 +800,6 @@
|
||||
"alert_frame_desc": "Toggle the alert frame. When enabled, the frame will be displayed when you are betrayed or attacked over land.",
|
||||
"special_effects_label": "Special effects",
|
||||
"special_effects_desc": "Toggle special effects. Deactivate to improve performances",
|
||||
"structure_sprites_label": "Structure Sprites",
|
||||
"structure_sprites_desc": "Toggle structure sprites",
|
||||
"cursor_cost_label_label": "Cursor Build Cost",
|
||||
"cursor_cost_label_desc": "Show a cost pill under the build cursor icon",
|
||||
"anonymous_names_label": "Hidden Names",
|
||||
|
||||
@@ -230,15 +230,6 @@ export class UserSettingModal extends BaseModal {
|
||||
);
|
||||
}
|
||||
|
||||
private toggleStructureSprites() {
|
||||
this.userSettings.toggleStructureSprites();
|
||||
|
||||
console.log(
|
||||
"🏠 Structure sprites:",
|
||||
this.userSettings.structureSprites() ? "ON" : "OFF",
|
||||
);
|
||||
}
|
||||
|
||||
private toggleCursorCostLabel() {
|
||||
this.userSettings.toggleCursorCostLabel();
|
||||
|
||||
@@ -787,15 +778,6 @@ export class UserSettingModal extends BaseModal {
|
||||
@change=${this.toggleFxLayer}
|
||||
></setting-toggle>
|
||||
|
||||
<!-- 🏠 Structure Sprites -->
|
||||
<setting-toggle
|
||||
label="${translateText("user_setting.structure_sprites_label")}"
|
||||
description="${translateText("user_setting.structure_sprites_desc")}"
|
||||
id="structure_sprites-toggle"
|
||||
.checked=${this.userSettings.structureSprites()}
|
||||
@change=${this.toggleStructureSprites}
|
||||
></setting-toggle>
|
||||
|
||||
<!-- 💰 Cursor Price Pill -->
|
||||
<setting-toggle
|
||||
label="${translateText("user_setting.cursor_cost_label_label")}"
|
||||
|
||||
@@ -17,7 +17,6 @@ import {
|
||||
SetSoundEffectsVolumeEvent,
|
||||
} from "../../sound/Sounds";
|
||||
import { ShowGraphicsSettingsModalEvent } from "./GraphicsSettingsModal";
|
||||
const structureIcon = assetUrl("images/CityIconWhite.svg");
|
||||
const cursorPriceIcon = assetUrl("images/CursorPriceIconWhite.svg");
|
||||
const darkModeIcon = assetUrl("images/DarkModeIconWhite.svg");
|
||||
const emojiIcon = assetUrl("images/EmojiIconWhite.svg");
|
||||
@@ -133,11 +132,6 @@ export class SettingsModal extends LitElement implements Controller {
|
||||
this.requestUpdate();
|
||||
}
|
||||
|
||||
private onToggleStructureSpritesButtonClick() {
|
||||
this.userSettings.toggleStructureSprites();
|
||||
this.requestUpdate();
|
||||
}
|
||||
|
||||
private onToggleSpecialEffectsButtonClick() {
|
||||
this.userSettings.toggleFxLayer();
|
||||
this.requestUpdate();
|
||||
@@ -410,31 +404,6 @@ export class SettingsModal extends LitElement implements Controller {
|
||||
</div>
|
||||
</button>
|
||||
|
||||
<button
|
||||
class="flex gap-3 items-center w-full text-left p-3 hover:bg-slate-700 rounded-sm text-white transition-colors"
|
||||
@click="${this.onToggleStructureSpritesButtonClick}"
|
||||
>
|
||||
<img
|
||||
src=${structureIcon}
|
||||
alt="structureSprites"
|
||||
width="20"
|
||||
height="20"
|
||||
/>
|
||||
<div class="flex-1">
|
||||
<div class="font-medium">
|
||||
${translateText("user_setting.structure_sprites_label")}
|
||||
</div>
|
||||
<div class="text-sm text-slate-400">
|
||||
${translateText("user_setting.structure_sprites_desc")}
|
||||
</div>
|
||||
</div>
|
||||
<div class="text-sm text-slate-400">
|
||||
${this.userSettings.structureSprites()
|
||||
? translateText("user_setting.on")
|
||||
: translateText("user_setting.off")}
|
||||
</div>
|
||||
</button>
|
||||
|
||||
<button
|
||||
class="flex gap-3 items-center w-full text-left p-3 hover:bg-slate-700 rounded-sm text-white transition-colors"
|
||||
@click="${this.onToggleAttackingTroopsOverlayButtonClick}"
|
||||
|
||||
@@ -158,10 +158,6 @@ export class UserSettings {
|
||||
return this.getBool("settings.specialEffects", true);
|
||||
}
|
||||
|
||||
structureSprites() {
|
||||
return this.getBool("settings.structureSprites", true);
|
||||
}
|
||||
|
||||
darkMode() {
|
||||
return this.getBool(DARK_MODE_KEY, false);
|
||||
}
|
||||
@@ -227,10 +223,6 @@ export class UserSettings {
|
||||
this.setBool("settings.specialEffects", !this.fxLayer());
|
||||
}
|
||||
|
||||
toggleStructureSprites() {
|
||||
this.setBool("settings.structureSprites", !this.structureSprites());
|
||||
}
|
||||
|
||||
toggleCursorCostLabel() {
|
||||
this.setBool("settings.cursorCostLabel", !this.cursorCostLabel());
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user