* Rename `checkSecondaryEmailConfirmationCode` to `checkAddSecondaryEmailConfirmationCode` * Create function `sendCodeAndStoreInSession` * Create function `sendExistingSecondaryEmailConfirmationCode` * Create function `_checkConfirmationCode` * Create function `checkExistingEmailConfirmationCode` * Rename `resendSecondaryEmailConfirmationCode` to `resendAddSecondaryEmailConfirmationCode` * Create function `_resendConfirmationCode` * Create function `resendExistingSecondaryEmailConfirmationCode` * Add `ResendConfirmationCodeModal` * Remove `ResendConfirmationEmailButton` * `bin/run web npm run extract-translations` * Update frontend test * Fix: don't throw on render when send-confirmation-code fails! * Update phrasing in the UI Per https://docs.google.com/document/d/1PE1vlZWQN--PjmXpyHR9rV2YPd7OIPIsUbnZaHj0cDI/edit?usp=sharing * Add unit test * Don't share the "send-confirmation" and "resend-confirmation" rate-limits * Update frontend test after copy change * Rename `checkAddSecondaryEmailConfirmationCode` to `checkNewSecondaryEmailConfirmationCode` and `resendAddSecondaryEmailConfirmationCode` to `resendNewSecondaryEmailConfirmationCode` * Rename `cb` to `beforeConfirmEmail` Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com> * Return `422` on missing session data Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com> * Add `userId` to log * Replace `isSecondary` param by `welcomeUser` Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com> * Rename `resend-confirm-email-code`'s `existingEmail` to `email` * Remove "secondary" from rate-limiters Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com> * Remove unnecessary `userId` check behind `AuthenticationController.requireLogin()` * Only open the modal if the code was sent successfully --------- Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com> GitOrigin-RevId: df892064641d9f722785699777383b2d863124e1
164 lines
4.7 KiB
TypeScript
164 lines
4.7 KiB
TypeScript
import {
|
|
render,
|
|
screen,
|
|
within,
|
|
fireEvent,
|
|
waitFor,
|
|
waitForElementToBeRemoved,
|
|
} from '@testing-library/react'
|
|
import EmailsSection from '../../../../../../frontend/js/features/settings/components/emails-section'
|
|
import { expect } from 'chai'
|
|
import fetchMock from 'fetch-mock'
|
|
import {
|
|
confirmedUserData,
|
|
fakeUsersData,
|
|
professionalUserData,
|
|
unconfirmedUserData,
|
|
} from '../../fixtures/test-user-email-data'
|
|
import getMeta from '@/utils/meta'
|
|
|
|
describe('<EmailsSection />', function () {
|
|
beforeEach(function () {
|
|
Object.assign(getMeta('ol-ExposedSettings'), {
|
|
hasAffiliationsFeature: true,
|
|
})
|
|
fetchMock.reset()
|
|
})
|
|
|
|
afterEach(function () {
|
|
fetchMock.reset()
|
|
})
|
|
|
|
it('renders translated heading', function () {
|
|
render(<EmailsSection />)
|
|
|
|
screen.getByRole('heading', { name: /emails and affiliations/i })
|
|
})
|
|
|
|
it('renders translated description', function () {
|
|
render(<EmailsSection />)
|
|
|
|
screen.getByText(/add additional email addresses/i)
|
|
screen.getByText(/to change your primary email/i)
|
|
})
|
|
|
|
it('renders a loading message when loading', async function () {
|
|
render(<EmailsSection />)
|
|
|
|
await screen.findByText(/loading/i)
|
|
})
|
|
|
|
it('renders an error message and hides loading message on error', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', 500)
|
|
render(<EmailsSection />)
|
|
|
|
await screen.findByText(
|
|
/an error has occurred while performing your request/i
|
|
)
|
|
expect(screen.queryByText(/loading/i)).to.be.null
|
|
})
|
|
|
|
it('renders user emails', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', fakeUsersData)
|
|
render(<EmailsSection />)
|
|
|
|
await waitFor(() => {
|
|
fakeUsersData.forEach(userData => {
|
|
screen.getByText(new RegExp(userData.email, 'i'))
|
|
})
|
|
})
|
|
})
|
|
|
|
it('renders primary status', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [professionalUserData])
|
|
render(<EmailsSection />)
|
|
|
|
await screen.findByText(`${professionalUserData.email}`)
|
|
screen.getByText('Primary')
|
|
})
|
|
|
|
it('shows confirmation status for unconfirmed users', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [unconfirmedUserData])
|
|
render(<EmailsSection />)
|
|
|
|
await screen.findByText(/unconfirmed/i)
|
|
})
|
|
|
|
it('hides confirmation status for confirmed users', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [confirmedUserData])
|
|
render(<EmailsSection />)
|
|
await waitForElementToBeRemoved(() => screen.getByText(/loading/i))
|
|
|
|
expect(screen.queryByText(/please check your inbox/i)).to.be.null
|
|
})
|
|
|
|
it('renders resend link', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [unconfirmedUserData])
|
|
render(<EmailsSection />)
|
|
|
|
await screen.findByRole('button', { name: /resend confirmation code/i })
|
|
})
|
|
|
|
it('renders professional label', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [professionalUserData])
|
|
render(<EmailsSection />)
|
|
|
|
const node = await screen.findByText(professionalUserData.email, {
|
|
exact: false,
|
|
})
|
|
expect(within(node).getByText(/professional/i)).to.exist
|
|
})
|
|
|
|
it('shows loader when resending email', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [unconfirmedUserData])
|
|
|
|
render(<EmailsSection />)
|
|
await waitForElementToBeRemoved(() => screen.getByText(/loading/i))
|
|
|
|
fetchMock.post('/user/emails/send-confirmation-code', 200)
|
|
|
|
const button = screen.getByRole('button', {
|
|
name: /resend confirmation code/i,
|
|
})
|
|
fireEvent.click(button)
|
|
|
|
expect(
|
|
screen.queryByRole('button', {
|
|
name: /resend confirmation code/i,
|
|
})
|
|
).to.be.null
|
|
|
|
await waitForElementToBeRemoved(() => screen.getByText(/sending/i))
|
|
|
|
expect(
|
|
screen.queryByText(/an error has occurred while performing your request/i)
|
|
).to.be.null
|
|
|
|
await screen.findByRole('button', {
|
|
name: /resend confirmation code/i,
|
|
})
|
|
})
|
|
|
|
it('shows error when resending email fails', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [unconfirmedUserData])
|
|
|
|
render(<EmailsSection />)
|
|
await waitForElementToBeRemoved(() => screen.getByText(/loading/i))
|
|
|
|
fetchMock.post('/user/emails/send-confirmation-code', 503)
|
|
|
|
const button = screen.getByRole('button', {
|
|
name: /resend confirmation code/i,
|
|
})
|
|
fireEvent.click(button)
|
|
|
|
expect(screen.queryByRole('button', { name: /resend confirmation code/i }))
|
|
.to.be.null
|
|
|
|
await waitForElementToBeRemoved(() => screen.getByText(/sending/i))
|
|
|
|
screen.getByText(/sorry, something went wrong/i)
|
|
screen.getByRole('button', { name: /resend confirmation code/i })
|
|
})
|
|
})
|