Alasdair Smith
85ceab5310
Tear down Ace session when aceEditor is destroyed
...
This cleans up the Ace worker that parses syntax, preventing a memory leak
2018-02-23 10:13:24 +00:00
Alasdair Smith and GitHub
5e39e61c9b
Merge pull request #348 from sharelatex/as-fix-cm-share
...
Fix CodeMirror/ShareJS binding when switching docs
2018-02-23 10:12:12 +00:00
Alasdair Smith and GitHub
92260e7b52
Merge pull request #340 from sharelatex/ja-remove-brand
...
Remove the public/brand folder
2018-02-23 10:11:47 +00:00
Alasdair Smith
2be37795bd
TODO for cleaning up sharejs callbacks
2018-02-22 11:44:09 +00:00
Alasdair Smith
598837e17c
Use applyAsync to prevent issue when switching docs
2018-02-22 11:44:09 +00:00
Alasdair Smith
c5735a31df
Remove unused listener
2018-02-22 11:44:09 +00:00
Alasdair Smith
e1187f3d8a
Listen for changes to the CodeMirror Doc, instead of all changes to the editor
...
This prevents an issue where switching docs (i.e. files) would cause the newly
opened doc from being inserted into the old doc.
This approach is similar to Ace's sessions.
2018-02-22 11:44:09 +00:00
Alasdair Smith
c85e9ba3b1
Instead of setting value of CM, swap Docs
...
This allows for tracking changes on individual docs (i.e. files), instead of
just changes to the editor. This is similar to how Ace works with sessions
2018-02-22 11:44:09 +00:00
Alasdair Smith and GitHub
eae8b5a592
Merge pull request #330 from sharelatex/as-karma-tests
...
Karma tests
2018-02-22 11:06:56 +00:00
Paulo Reis and James Allen
f1a36919f9
Make sure the widget does not overlap the footer.
2018-02-21 13:39:39 +00:00
Alasdair Smith
0b77e97df2
Added angular mocks for testing and stub out globals
2018-02-20 14:01:02 +00:00
Brian Gough and GitHub
fc1e94b14a
Merge pull request #343 from sharelatex/bg-block-javascript-property-names
...
block javascript property names being used as file names
2018-02-16 14:07:12 +00:00
Brian Gough and GitHub
2ba7db603f
Merge pull request #337 from sharelatex/ja-allow-javascript-property-names
...
Use bare objects without prototypes for tracking filenames
2018-02-16 14:05:21 +00:00
Brian Gough
8a10e98b56
block javascript property names being used as file names
2018-02-16 10:31:47 +00:00
Paulo Reis
3f14a727e3
Make sure the hamburger menu plays well with the brand.
2018-02-16 10:26:26 +00:00
James Allen
6f143603a3
Remove unused brand folder
2018-02-15 14:54:34 +00:00
Paulo Reis
51b14e412f
Increase hamburguer menu max-height; 340px was less than SL menu fully expanded.
2018-02-15 11:51:45 +00:00
Paulo Reis
e2874998b3
Improve hamburguer menu in v2, still not perfect.
2018-02-15 11:46:40 +00:00
Paulo Reis
f01b027da0
Make sure the menu behaviour does not change in desktop resolutions.
2018-02-15 11:29:29 +00:00
Paulo Reis
058a58d099
Only apply horizontal paddings (to align with the header).
2018-02-15 11:12:32 +00:00
Paulo Reis
ebad9091c7
Create class to scope main header changes (avoids overriding too much Bootstrap stuff); apply styles.
2018-02-15 11:08:12 +00:00
James Allen
4754f1e78a
Use bare objects without prototypes for tracking filenames
2018-02-15 11:06:40 +00:00
Paulo Reis
f1717bfa1f
Allow header content to be on top of main content.
2018-02-15 10:58:36 +00:00
James Allen and GitHub
a7fabb8e43
Merge pull request #321 from sharelatex/ja-recompile-tweaks
...
Animate toolbar for auto-compile and consolidate trigger logic
2018-02-14 09:34:16 +00:00
James Allen
29d2b408ad
Don't error when detaching from history with no sharejsDoc
2018-02-13 08:43:00 +00:00
James Allen
5d3ecdb924
Add explicit editor init event
2018-02-13 08:27:48 +00:00
James Allen
3802df5cfa
Use popup instance variable like Ace autocompleter does
2018-02-13 08:27:41 +00:00
James Allen
5d6925921c
Fix read only links
2018-02-12 10:42:57 +00:00
James Allen
92e59f7008
Remove unneeded apply
2018-02-09 17:58:19 +00:00
James Allen
ab940fb462
Fix typo in comment
2018-02-09 17:54:58 +00:00
James Allen
9e86abbb04
Remove unneeded webkit prefix in css
2018-02-09 17:54:42 +00:00
Alasdair Smith and GitHub
6088fcf82b
Merge pull request #310 from sharelatex/ja-link-sharing-tweaks
...
Link sharing UX improvments
2018-02-09 11:23:28 +00:00
Alasdair Smith and GitHub
7ff0f40477
Merge pull request #266 from sharelatex/as-cm
...
CodeMirror
2018-02-09 11:23:11 +00:00
Alasdair Smith
b7200066e9
Inject rich text variable to conditionally show rich text styles
2018-02-09 10:42:11 +00:00
Alasdair Smith
bfda9c595b
Hide rich text behind feature flag
2018-02-09 10:42:11 +00:00
Alasdair Smith
4c23a3c8f0
Fix bug where spell check cache would error when toggling between ace & cm
2018-02-09 10:42:11 +00:00
Alasdair Smith
d15efc6fb6
Create cmEditor directive to connect to ShareJS
2018-02-09 10:42:11 +00:00
Alasdair Smith
b9327cb2d4
Add toolbar with button to toggle rich text
2018-02-09 10:42:00 +00:00
Alasdair Smith
7783e18a50
Allow Documents to be attached to CM
2018-02-09 10:38:51 +00:00
Alasdair Smith
09fbafa1f6
Include ShareJS CM adapter in compiled lib and fix bug with CM adapter
...
Because the CM & Ace scripts are naively concat-ed together, the Ace
applyToShareJS function would be overwritten by the CM version.
Also fixes bugs where adapter was calling old version of ShareJS api
and the old CM api
2018-02-09 10:38:51 +00:00
Alasdair Smith
f5b6d3ff3e
Load basic CM instance with dummy content
2018-02-09 10:38:51 +00:00
Henry Oswald and GitHub
ba1e45d12c
Merge pull request #317 from sharelatex/ho-nice-recaptcha-message
...
improved recaptcha error message
2018-02-09 10:26:33 +00:00
Alasdair Smith
d8e87997c1
Install codemirror
2018-02-09 10:02:36 +00:00
James Allen
bd9f30d858
Adjust icon spacing in PDF toolbar
2018-02-08 14:41:39 +00:00
James Allen
7866a91d21
Refactor auto-compile trigger logic
2018-02-08 13:39:59 +00:00
James Allen
5bf2ff0a47
Show animated bar while auto-compile is pending
2018-02-08 13:39:56 +00:00
Henry Oswald
696e9d27d6
send invalid_email error type down when sharing project
2018-02-08 10:35:18 +00:00
Brian Gough and GitHub
9224e164fe
Merge pull request #315 from sharelatex/bg-validate-filenames-client
...
validate filenames on the client
2018-02-08 09:16:05 +00:00
Brian Gough
b083e4bc5f
remove redundant MAX_PATH definition
2018-02-07 16:14:56 +00:00
Brian Gough
c14380d563
use the SafePath.coffee file in the client too
2018-02-07 15:50:29 +00:00
Alasdair Smith