Commit Graph
68 Commits
Author SHA1 Message Date
Jessica LawsheandCopybot 5e0dced989 Merge pull request #22966 from overleaf/jel-saml-error
[web] Check for requester errors in SAML callback

GitOrigin-RevId: 491d7c85e859c503bade3b225a4596656dbfe84f
2025-02-05 09:06:38 +00:00
Jessica LawsheandCopybot bcd61354a8 Merge pull request #22803 from overleaf/jel-sso-error-handling
[web] Better error when for missing user SAML callback data

GitOrigin-RevId: 0f781bc46a8684e183d4a860df00c29d6dc9193e
2025-02-05 09:06:31 +00:00
Andrew RumbleandCopybot 6cb1528495 Merge pull request #23020 from overleaf/ar-prevent-rootFolder-deletion
[web] Prevent deletes on a project's rootFolder

GitOrigin-RevId: 6d0506f207425f65d3de990a78bb1ea9b136ed1e
2025-01-23 09:05:42 +00:00
Jakob AckermannandCopybot 577497b655 Merge pull request #19842 from overleaf/jpa-ro-mirror-on-client
[misc] add readonly mirror of full project content on the client

GitOrigin-RevId: 940bd93bfd587f83ca383d10fc44579b38fc3e88
2024-08-22 08:05:13 +00:00
DavidandCopybot d7357b4d62 Merge pull request #19400 from overleaf/dp-duplicate-file-folder-name
Improvements to handling of file/folder upload conflicts

GitOrigin-RevId: 526edf30dfbaec7ee1e03ffd156365f09be25e86
2024-07-25 08:05:08 +00:00
Eric Mc SweenandCopybot 194d778c28 Merge pull request #19242 from overleaf/em-api-error-handlers
Handle more errors in the global API error handler

GitOrigin-RevId: add31e2de067e8534f2eb3932623c2413c4ce6d8
2024-07-04 08:05:31 +00:00
f4454cfe7e [web] Make SamlLogHandler.log() calls asynchronous (#17207)
* [web] Refactor exports in ErrorController

* [web] Make SamlLogHandler.log() async

* [web] await for SamlLogHandler.log() in ErrorController

* [web] await for SamlLogHandler.log() in SAMLMiddleware

* [web] await for SamlLogHandler.log() async controllers

* [web] await for SamlLogHandler.log() in SAMLManager

* [web] Remove explicit wait when testing SAML logs

After making the logs asynchronouse the wait
is no longer needed

* [web] Avoid using async with SamlLogHandler.log on callbacks

* Add expressifyErrorHandler to promise-utils

* Tighten assertion in SAMLMiddlewareTests

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Updated SamlLogHandler.log to await for promise

---------

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 3645923fae8096a9ba25dc9087f1a36231528569
2024-02-23 09:03:14 +00:00
Jessica LawsheandCopybot 3748621bcd Merge pull request #16791 from overleaf/jel-saml-audience
[web] Handle the SAML error of a SP entity ID mismatch in the response

GitOrigin-RevId: d8168d4ce77f4e810df193dae98046da07e6c0ae
2024-02-02 09:03:51 +00:00
Alexandre BourdinandCopybot 77de72f43f Merge pull request #16071 from overleaf/ab-group-sso-test-flow-2
[web] Group SSO test flow - Error handling (part 1)

GitOrigin-RevId: bf41ef2a0f1a33331fc9d122e6004c10e8094881
2023-12-18 09:04:50 +00:00
Brian GoughandCopybot 114149ddf6 Merge pull request #16175 from overleaf/bg-group-sso-restrict-login
restrict login methods to group SSO for managed users with group SSO linked

GitOrigin-RevId: d0a92f9dc16cc08a3afacb4ad4b9ce19b1fd1330
2023-12-15 09:03:42 +00:00
Jessica LawsheandCopybot c2f8099793 Merge pull request #16146 from overleaf/jel-sso-login-invalid-email-error
[web] Show error message for invalid emails on SSO log in page

GitOrigin-RevId: 511cd05754f9019bf755ff4909b4579c6dcd7fbb
2023-12-08 09:04:33 +00:00
Brian GoughandCopybot 29871caf2b Merge pull request #16035 from overleaf/bg-group-sso-login-errors
add an error for unrecognised email on saml login

GitOrigin-RevId: 7102cde8b2b9ccb510f913394c555efc39dd9016
2023-12-06 09:05:16 +00:00
Brian GoughandCopybot 011609b345 Merge pull request #15913 from overleaf/bg-group-sso-fix-signature-error
fix the error message for an invalid saml signature

GitOrigin-RevId: 2987f84f6ff2bea168887ff3e6ad621fb257aeed
2023-11-28 09:04:58 +00:00
Brian GoughandCopybot 3e5273144e Merge pull request #15656 from overleaf/bg-group-sso-login-acceptance-tests
add acceptance tests for group sso login

GitOrigin-RevId: 046d142ab478e45619b3a76d88eac73a808dfa08
2023-11-22 09:04:07 +00:00
Brian GoughandCopybot a12699133d Merge pull request #15420 from overleaf/bg-group-sso-handle-errors
handle errors in group sso login

GitOrigin-RevId: dcfba6bc4f7aec8aa9d27945b297154594368d92
2023-10-31 09:04:48 +00:00
Jessica LawsheandCopybot 8a0f2dbe1d Merge pull request #15419 from overleaf/em-error-request-logging
Use the request logger for errors in web

GitOrigin-RevId: f654fc69e0bbdab8b16d23b007aefbad08925358
2023-10-31 09:04:36 +00:00
Eric Mc SweenandCopybot 75a86bab87 Merge pull request #13537 from overleaf/em-promisify-clsi-manager-2
Promisify ClsiManager

GitOrigin-RevId: e785cdb1989b433f7baa1a4d974b09ba3a93fcbd
2023-07-17 10:54:40 +00:00
Brian GoughandCopybot f0420000c5 Merge pull request #13583 from overleaf/bg-add-permissions-middleware
add permissions middleware for managed users

GitOrigin-RevId: debd2398a3b75ce71023463ad3c0781750983b53
2023-07-17 10:51:52 +00:00
Eric Mc SweenandCopybot 0830760f0f Merge pull request #11702 from overleaf/em-headers-sent
Don't send an error response when headers have already been sent

GitOrigin-RevId: a9832022a4f47562d31134d34bfd8c52e1eb4d7e
2023-02-09 09:06:06 +00:00
Jessica LawsheandCopybot f1ee27a518 Merge pull request #9074 from overleaf/jel-saml-log-tests
[web] Add tests for SAML log

GitOrigin-RevId: 7bc5b25461063b32d3471b7f4ab966f2caa4e70c
2022-08-09 08:03:05 +00:00
Jakob AckermannandCopybot f0bd6dda23 Merge pull request #7986 from overleaf/jpa-eslint-8
[misc] upgrade eslint packages to the latest version everywhere

GitOrigin-RevId: f1480d4a171acef82fb26c4aa54be3a6088b0ab3
2022-05-17 08:05:59 +00:00
Jakob AckermannandCopybot d720d6affa Merge pull request #6317 from overleaf/jpa-send-explicit-content-type
[web] send explicit content type in responses

GitOrigin-RevId: d5aeaba57a7d2fc053fbf5adc2299fb46e435341
2022-01-18 09:03:18 +00:00
Alf EatonandCopybot 50df230846 [web] Upgrade Prettier to match version in monorepo root (#6231)
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
2022-01-11 09:03:23 +00:00
Eric Mc SweenandCopybot 5fc6d7dcb3 Merge pull request #5740 from overleaf/em-gcp-logging-web
Improve GCP logging for web

GitOrigin-RevId: b304c87a3fe46c29189f665eb3daf22c23d6eb8f
2021-11-11 09:03:09 +00:00
Eric Mc SweenandCopybot e5676a9643 Merge pull request #5648 from overleaf/em-revert-gcp-logging-web
Revert "Improve GCP logging for web"

GitOrigin-RevId: 92d446baf62108da1df92146eec12a2fe69d30ee
2021-11-02 09:03:29 +00:00
Eric Mc SweenandCopybot 641b10cceb Merge pull request #5632 from overleaf/em-gcp-logging-web
Improve GCP logging for web

GitOrigin-RevId: 1198fab2e821a55563058171cfa435605216e337
2021-11-02 09:03:22 +00:00
Alexandre BourdinandCopybot 9468e5cb4f Merge pull request #4338 from overleaf/ab-session-manager
Extract functions from AuthenticationController to SessionManager

GitOrigin-RevId: 86870ce03a762e1a837dcf493759e8851e759883
2021-07-28 12:36:22 +00:00
Jakob AckermannandCopybot 5e773ce950 Merge pull request #4101 from overleaf/ae-settings-module
Migrate from `settings-sharelatex` to `@overleaf/settings`

GitOrigin-RevId: 9a298ba26382180c1351683c5fddc9004418c1e6
2021-07-08 02:08:28 +00:00
Alf EatonandCopybot 1be43911b4 Merge pull request #3942 from overleaf/prettier-trailing-comma
Set Prettier's "trailingComma" setting to "es5"

GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00
Timothée AlbyandCopybot 6e8a4e70dd Merge pull request #3641 from overleaf/ta-saml-integration
SAML Misc Changes

GitOrigin-RevId: 89fe8704d8effb6299d841be00efc653f6800fab
2021-02-19 03:04:18 +00:00
Eric Mc SweenandCopybot 1c0b897835 Merge pull request #3638 from overleaf/em-dropbox-duplicate-projects
Unlink Dropbox when two projects have the same name

GitOrigin-RevId: b16dbeb6841eaebd8553884eebc87e681d17a9c8
2021-02-18 03:05:12 +00:00
Alf EatonandCopybot 2ff1cf43d6 Merge pull request #3470 from overleaf/eslint
Upgrade and configure ESLint

GitOrigin-RevId: ad5aeaf85e72c847a125ff3a9db99a12855e38aa
2020-12-16 03:08:28 +00:00
Brian GoughandCopybot cde6160973 Merge pull request #3421 from overleaf/bg-fix-health-checks-for-web-closed
fix load balancer health checks for web-closed

GitOrigin-RevId: f46ecec4539740bc4f0324944b2b4d6273025211
2020-12-01 03:04:08 +00:00
Timothée AlbyandCopybot f5471481d9 Merge pull request #3166 from overleaf/msm-server-message-async-form
Using server messages in asyncForm for 400 errors

GitOrigin-RevId: 1cf1bae7d5ac61051f8ed923631ae7874984572c
2020-09-16 02:04:52 +00:00
Timothée AlbyandCopybot d9c435a77a Merge pull request #2957 from overleaf/ew-validate-saml-email
Validate saml email before register

GitOrigin-RevId: 6dcf3bccd280abd7bd3ced2d4fd2f69c590f74c1
2020-09-02 02:05:07 +00:00
Timothée AlbyandCopybot 82a0df1fad Merge pull request #3147 from overleaf/jel-sso-email-missing-error
Update default missing SSO email error message

GitOrigin-RevId: 03410a9b5c0f894c236f62148f03cb6243abad7a
2020-09-02 02:04:26 +00:00
Timothée AlbyandCopybot 1ff2c6ce00 Merge pull request #3117 from overleaf/sk-block-tpds-update-on-archived-project
Block TPDS update on archived/trashed project

GitOrigin-RevId: 7db41a313b03721b93cbb601add6f91ae31f3f2a
2020-08-25 02:04:17 +00:00
Miguel SerranoandCopybot d2845d9a38 Merge pull request #3074 from overleaf/msm-update-oerror-logger-v3
Update o-error to v3 and logger-sharelatex to v3

GitOrigin-RevId: 5e6386f65b7893949336aa4ff021212aebd98f4a
2020-08-12 02:06:58 +00:00
Miguel SerranoandCopybot 42c917d909 Merge pull request #3046 from overleaf/msm-cleanup-oerror-http
Finish o-error/http cleanup

GitOrigin-RevId: 1f8cf7f1e0503d1071c51b41ac136f7fb7f38872
2020-08-12 02:06:53 +00:00
Ersun WarnckeandCopybot 88683e9fec refactor SAMLController to use async throughout
GitOrigin-RevId: dafd76042f460cd34596c8c9023e2378145105e8
2020-08-10 15:54:15 +00:00
Jakob AckermannandCopybot 1f6499b5ea Merge pull request #3053 from overleaf/jpa-spd-accepts
[misc] reland 3004: unify detection of json requests and skip issuing of redirects

GitOrigin-RevId: fa43b3b4d23deb581496ed70ae8f28b805555d64
2020-07-28 02:06:27 +00:00
Miguel SerranoandCopybot b0dc73a61c Remove HttpErrors.InternalServerError (#3027)
* Added legacyInternal() 500 to HttpErrorHandler
* replaced HttpErrors.InternalServerError being thrown with calls to HttpHandler.legacyInternal()

GitOrigin-RevId: 0b7086a9693b57cdf93976d4221b90315960e8bb
2020-07-23 02:06:50 +00:00
Eric Mc SweenandCopybot f251d661ed Merge pull request #3021 from overleaf/msm-oerror-remove-conflict-error
Replace ConflictError thrown with calls to HttpErrorHandler.conflict()

GitOrigin-RevId: 3b4d98af1b31e49ceab4b1b55b94b8f0323c8a9b
2020-07-21 02:06:18 +00:00
Miguel SerranoandCopybot 244709df5e Merge pull request #2988 from overleaf/msm-oerror-remove-not-found-error
Replace HTTPErrors.NotFoundError with calls to notFound() handler

GitOrigin-RevId: c98582a5bd3d862b3c17fb03d863c75f64851aba
2020-07-17 02:07:18 +00:00
Miguel SerranoandCopybot 63503f2079 Merge pull request #2984 from overleaf/msm-oerror-remove-bad-request-error
Replace HTTPErrors.BadRequestError with calls to badRequest() handler

GitOrigin-RevId: 57a91a13bde942ee373e235ee925f1c76a0f4e88
2020-07-17 02:07:12 +00:00
Miguel SerranoandCopybot 6562f3003d Merge pull request #2985 from overleaf/msm-oerror-remove-unprocessable-entity-error
Replace UnprocessableEntityError with calls to unprocessableEntity() handler

GitOrigin-RevId: 4bba389c8cdf87a40137d49db571fa81aaac4239
2020-07-17 02:06:19 +00:00
Miguel SerranoandCopybot d8d3ac82e9 Replace HTTPErrors.ForbiddenError with calls to forbidden() handler (#2972)
GitOrigin-RevId: 2a0c8fdaef9ba62b97cebad84603e6f076d770c0
2020-07-11 02:04:21 +00:00
Timothée AlbyandCopybot 345adb8ad2 Merge pull request #2862 from overleaf/spd-flaky-oio-test
Fix flaky Open-in-Overleaf tests

GitOrigin-RevId: 7badb0e88b5c01478406e0cea3564d46e1b7a881
2020-05-26 03:11:18 +00:00
Jessica LawsheandCopybot 4a1ac4649c Change "email" to "email address" in error message
GitOrigin-RevId: a9b4720a006aedabacd37ee9fc9bc16f0b948b3c
2020-04-02 03:19:53 +00:00
Timothée AlbyandCopybot 1d7b454c96 Merge pull request #2691 from overleaf/ta-4xx-error-page
Enhance 4xx HTML Response Page

GitOrigin-RevId: 620f84cd6cdc0571bd68bbd2c3164b08f7fe5598
2020-04-02 03:19:35 +00:00