684cb3903c
[WebsocketController] handle redis subscribe error on joinProject
...
joinProject should not complete when the redis pub/sub subscribe request
failed.
2020-05-12 13:03:50 +02:00
5c28da1031
add metric for pendingUpdates queue
2020-04-07 11:53:54 +01:00
56628a16c6
[misc] track redis pub/sub payload sizes on publish
2020-03-30 11:31:44 +02:00
af53d3b603
[misc] skip duplicate JSON serialization for size check
2020-03-24 11:22:28 +01:00
cb675d38c2
[misc] SafeJsonParse: align the size limit with the frontend->rt limit
...
frontend -> real-time and doc-updater -> real-time should be in sync.
Otherwise we can send a payload to doc-updater, but can not receive the
confirmation of it -- and the client will send it again in a loop.
Also log the size of the payload.
2020-03-24 09:14:15 +01:00
15244a54be
[misc] WebsocketController: limit the update size to 7mb
...
bail out early on -- especially do not push the update into redis for
doc-updater to discard it.
Confirm the update silently, otherwise the frontend will send it again.
Broadcast a 'otUpdateError' message and disconnect the client, like
doc-updater would do.
2020-03-24 09:12:12 +01:00
6df88ebc49
Filter "comments" if restricted user.
2019-10-30 13:54:40 +00:00
403caa65e8
Revert "Revert "Track the isRestrictedUser flag on clients""
...
This reverts commit 651e392a7c644403f199e1b03e7494b61ce71d0c.
2019-10-30 13:52:36 +00:00
925a8651c1
Revert "Track the isRestrictedUser flag on clients"
2019-10-22 10:17:38 +01:00
06aa578bdc
Make it an error when we get no data from joinProject
2019-10-11 09:57:16 +01:00
df6cd4a054
Also block getConnectedUsers for restricted users.
...
Plus refactor to use a pass list instead of a deny list.
2019-10-04 13:41:49 +01:00
6765d03339
Track the isRestrictedUser flag on clients
...
Then, don't send new chat messages and new comments to those restricted clients.
We do this because we don't want to leak private information (email addresses
and names) to "restricted" users, those who have read-only access via a
shared token.
2019-10-04 10:30:24 +01:00
21e294c6eb
Generate retryable error when hitting rate limits in web
2019-09-02 11:27:04 +01:00
fe2e7b3065
minimal fix for undefined connected users
2019-08-16 10:07:30 +01:00
fa94e3d5e3
Merge pull request #69 from overleaf/ho-drain-connections-timewindow
...
add shutdownDrainTimeWindow, drains all connections within time range
2019-08-15 09:22:10 +01:00
d57b229e17
update tests
2019-08-14 13:03:14 +01:00
7db882f339
fix unit tests
2019-08-13 17:26:49 +01:00
00cca29d9e
add shutdownDrainTimeWindow, drains all connections within time range
2019-08-13 14:21:47 +01:00
478a727c61
ignore spurious requests to leave other docs
2019-07-29 15:19:08 +01:00
22d722f3e8
add metric for RoomEvents listeners
2019-07-24 16:25:45 +01:00
e14a94906a
update naming from Set -> Map
2019-07-24 14:18:15 +01:00
61b3a000b4
fix whitespace
2019-07-24 09:52:20 +01:00
159b39c491
ensure redis channel is subscribed when joining room
2019-07-23 17:02:09 +01:00
bb629c27a1
rename unit test ChannelManager to ChannelManagerTests
2019-07-22 11:28:49 +01:00
1afebd12a1
unit tests
2019-07-22 11:23:43 +01:00
9f7df5f10c
wip unit tests
2019-07-19 11:58:40 +01:00
40353a410f
fix unit tests
2019-07-19 08:49:57 +01:00
dd54789e2b
fix build problems
2019-07-09 12:20:59 +01:00
b5f9bc422b
support multple redis instances for pubsub
2019-07-08 15:56:25 +01:00
46dfe56b05
Downgraded unathorised log to warning
2019-06-21 07:30:12 +02:00
a579a83389
Merge pull request #53 from overleaf/em-doc-updater-404s
...
Do not log error on doc updater 404
2019-06-03 10:55:04 +01:00
40f3456b1c
update unit test
2019-06-03 10:34:59 +01:00
acf850bce9
Do not log error on doc updater 404
...
Document updater 404s are not indicative of a problem, but just of the client
trying to connect to a deleted document, which is easy to trigger. We
log a warning instead.
2019-05-31 17:32:21 -04:00
20d5cc69a4
filter invalid updates
2019-05-24 10:19:02 +01:00
2dbdcf5bc8
add health check to pubsub channels
2019-04-15 14:17:55 +01:00
6374a641d5
fix unit tests
2019-04-11 15:07:42 +01:00
893515e83f
handle duplicate entries in io.sockets.clients
2019-04-09 14:48:00 +01:00
936311f1fb
fix eventlogger tests to use name with dashes
2019-03-22 11:20:38 +00:00
efa83b4cde
stub out eventlogger in unit test
2019-03-22 11:19:31 +00:00
befe4be517
add check for duplicate events
2019-03-19 14:22:11 +00:00
0b88a63444
Merge pull request #35 from sharelatex/cmg-anonymous-display-name
...
Nameless logged in user labelled as anonymous
2019-02-15 14:53:18 +00:00
bb06f82e04
Still send cursorData for logged in users
2019-02-12 14:00:47 +00:00
cb12e1c6f6
Send an empty string for every nameless user
2019-02-08 15:39:51 +00:00
bbd88e75eb
fix broken tests
2018-12-05 15:41:12 +00:00
675814f1b1
Handle the case where the user has only a last_name set
2017-12-13 10:28:35 +00:00
06c8729ce7
If a user has only their first_name set, don't label as Anonymous
2017-12-12 15:27:50 +00:00
c8ad331551
fix unit tests
2017-11-13 09:41:04 +00:00
3b39464aa5
Merge branch 'master' into sk-unlisted-projects
2017-11-02 10:58:41 +00:00
d4c735c3ea
Pass anonymous-read token along as header to web-api
2017-09-26 14:21:41 +01:00
785d6e2eea
Add tests for comment & change encoding
2017-09-22 10:56:08 +01:00
Jakob Ackermann