Merge pull request #3949 from overleaf/msm-reenable-eslint-const-rule

Reenable eslint `prefer-const` rule

GitOrigin-RevId: 4f3825be8b8dff381095209085a36eaab76260d5
This commit is contained in:
Miguel Serrano
2021-05-06 02:09:14 +00:00
committed by Copybot
parent 0874fcb8ca
commit f9871103bf
129 changed files with 353 additions and 358 deletions
@@ -463,7 +463,7 @@ describe('ProjectDeleter', function () {
describe('archiveProject', function () {
beforeEach(function () {
let archived = [ObjectId(this.user._id)]
const archived = [ObjectId(this.user._id)]
this.ProjectHelper.calculateArchivedArray.returns(archived)
this.ProjectMock.expects('findOne')
@@ -505,7 +505,7 @@ describe('ProjectDeleter', function () {
describe('unarchiveProject', function () {
beforeEach(function () {
let archived = [ObjectId(this.user._id)]
const archived = [ObjectId(this.user._id)]
this.ProjectHelper.calculateArchivedArray.returns(archived)
this.ProjectMock.expects('findOne')
@@ -541,7 +541,7 @@ describe('ProjectDeleter', function () {
describe('trashProject', function () {
beforeEach(function () {
let archived = [ObjectId(this.user._id)]
const archived = [ObjectId(this.user._id)]
this.ProjectHelper.calculateArchivedArray.returns(archived)
this.ProjectMock.expects('findOne')
@@ -171,7 +171,7 @@ describe('ProjectEditorHandler', function () {
it('should gather readOnly_refs and collaberators_refs into a list of members', function () {
const findMember = id => {
for (let member of Array.from(this.result.members)) {
for (const member of Array.from(this.result.members)) {
if (member._id === id) {
return member
}