Merge pull request #7986 from overleaf/jpa-eslint-8

[misc] upgrade eslint packages to the latest version everywhere

GitOrigin-RevId: f1480d4a171acef82fb26c4aa54be3a6088b0ab3

services/web/test/unit/src/BrandVariations/BrandVariationsHandlerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Chat/ChatControllerTests.js

@@ -1,6 +1,6 @@
 /* eslint-disable
     camelcase,
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Collaborators/CollaboratorsInviteControllerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Collaborators/CollaboratorsInviteHandlerTests.js

@@ -1,6 +1,6 @@
 /* eslint-disable
     chai-friendly/no-unused-expressions,
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Compile/ClsiCookieManagerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,
@@ -221,7 +221,7 @@ describe('ClsiCookieManager', function () {
       delete this.settings.clsiCookie.key
       this.ClsiCookieManager = SandboxedModule.require(modulePath, {
         globals: {
-          console: console,
+          console,
         },
         requires: this.requires,
       })()
@@ -265,7 +265,7 @@ describe('ClsiCookieManager', function () {
         .returns(this.redis_secondary)
       this.ClsiCookieManager = SandboxedModule.require(modulePath, {
         globals: {
-          console: console,
+          console,
         },
         requires: this.requires,
       })()
@@ -320,7 +320,7 @@ describe('ClsiCookieManager', function () {
       delete this.settings.clsiCookie.key
       this.ClsiCookieManager = SandboxedModule.require(modulePath, {
         globals: {
-          console: console,
+          console,
         },
         requires: this.requires,
       })()

services/web/test/unit/src/Compile/ClsiFormatCheckerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Compile/ClsiStateManagerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Compile/CompileManagerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Cooldown/CooldownManagerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
 */

services/web/test/unit/src/Editor/EditorControllerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/InactiveData/InactiveProjectManagerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Metadata/MetaHandlerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
 */

services/web/test/unit/src/Notifications/NotificationsHandlerTests.js

@@ -1,6 +1,6 @@
 /* eslint-disable
     camelcase,
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/PasswordReset/PasswordResetHandlerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Project/ProjectDeleterTests.js

@@ -145,9 +145,9 @@ describe('ProjectDeleter', function () {
       requires: {
         '../../infrastructure/Features': this.Features,
         '../Editor/EditorRealTimeController': this.EditorRealTimeController,
-        '../../models/Project': { Project: Project },
+        '../../models/Project': { Project },
         './ProjectHelper': this.ProjectHelper,
-        '../../models/DeletedProject': { DeletedProject: DeletedProject },
+        '../../models/DeletedProject': { DeletedProject },
         '../DocumentUpdater/DocumentUpdaterHandler':
           this.DocumentUpdaterHandler,
         '../Tags/TagsHandler': this.TagsHandler,
@@ -611,7 +611,7 @@ describe('ProjectDeleter', function () {
         .withArgs(
           { _id: this.project._id },
           {
-            $set: { archived: archived },
+            $set: { archived },
             $pull: { trashed: ObjectId(this.user._id) },
           }
         )
@@ -650,7 +650,7 @@ describe('ProjectDeleter', function () {
         .resolves(this.project)
 
       this.ProjectMock.expects('updateOne')
-        .withArgs({ _id: this.project._id }, { $set: { archived: archived } })
+        .withArgs({ _id: this.project._id }, { $set: { archived } })
         .resolves()
     })
 
@@ -690,7 +690,7 @@ describe('ProjectDeleter', function () {
           { _id: this.project._id },
           {
             $addToSet: { trashed: ObjectId(this.user._id) },
-            $set: { archived: archived },
+            $set: { archived },
           }
         )
         .resolves()

services/web/test/unit/src/Project/ProjectOptionsHandlerTests.js

@@ -1,6 +1,6 @@
 /* eslint-disable
     camelcase,
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Project/ProjectUpdateHandlerTests.js

@@ -1,6 +1,6 @@
 /* eslint-disable
     camelcase,
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Publishers/PublishersGetterTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/References/ReferencesHandlerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     mocha/no-identical-title,
     no-return-assign,

services/web/test/unit/src/Security/LoginRateLimiterTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
 */

services/web/test/unit/src/Security/SessionAutostartMiddlewareTests.js

@@ -13,7 +13,7 @@ describe('SessionAutostartMiddleware', function () {
 
   beforeEach(function () {
     Settings = {
-      cookieName: cookieName,
+      cookieName,
     }
 
     SessionAutostartMiddleware = SandboxedModule.require(modulePath, {

services/web/test/unit/src/Subscription/RecurlyClientTests.js

@@ -54,7 +54,7 @@ describe('RecurlyClient', function () {
 
     return (this.RecurlyClient = SandboxedModule.require(modulePath, {
       globals: {
-        console: console,
+        console,
       },
       requires: {
         '@overleaf/settings': this.settings,

services/web/test/unit/src/Subscription/RecurlyWrapperTests.js

@@ -1,6 +1,6 @@
 /* eslint-disable
     camelcase,
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Subscription/SubscriptionGroupHandlerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-dupe-keys,
     no-return-assign,

services/web/test/unit/src/Subscription/SubscriptionLocatorTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Subscription/V1SusbcriptionManagerTests.js

@@ -1,6 +1,6 @@
 /* eslint-disable
     camelcase,
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Tags/TagsHandlerTests.js

@@ -17,13 +17,13 @@ describe('TagsHandler', function () {
     this.tagId = ObjectId().toString()
     this.projectId = ObjectId().toString()
 
-    this.mongodb = { ObjectId: ObjectId }
+    this.mongodb = { ObjectId }
     this.TagMock = sinon.mock(Tag)
 
     this.TagsHandler = SandboxedModule.require(modulePath, {
       requires: {
         '../../infrastructure/mongodb': this.mongodb,
-        '../../models/Tag': { Tag: Tag },
+        '../../models/Tag': { Tag },
       },
     })
   })

services/web/test/unit/src/TokenAccess/TokenAccessHandlerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/Uploads/ArchiveManagerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/User/UserDeleterTests.js

@@ -86,8 +86,8 @@ describe('UserDeleter', function () {
 
     this.UserDeleter = SandboxedModule.require(modulePath, {
       requires: {
-        '../../models/User': { User: User },
-        '../../models/DeletedUser': { DeletedUser: DeletedUser },
+        '../../models/User': { User },
+        '../../models/DeletedUser': { DeletedUser },
         '../Newsletter/NewsletterManager': this.NewsletterManager,
         './UserSessionsManager': this.UserSessionsManager,
         '../Subscription/SubscriptionHandler': this.SubscriptionHandler,

services/web/test/unit/src/User/UserGetterTests.js

@@ -25,7 +25,7 @@ describe('UserGetter', function () {
         {
           email: 'email1@foo.bar',
           reversedHostname: 'rab.oof',
-          confirmedAt: confirmedAt,
+          confirmedAt,
           lastConfirmedAt: confirmedAt,
         },
         { email: 'email2@foo.bar', reversedHostname: 'rab.oof' },
@@ -454,21 +454,21 @@ describe('UserGetter', function () {
                 email: email1,
                 reversedHostname: 'rab.oss',
                 confirmedAt: new Date('2019-09-24'),
-                reconfirmedAt: reconfirmedAt,
+                reconfirmedAt,
                 default: true,
               },
               {
                 email: email2,
                 reversedHostname: 'rab.oss',
                 confirmedAt: new Date('2019-09-24'),
-                reconfirmedAt: reconfirmedAt,
+                reconfirmedAt,
                 samlProviderId: institutionSSO.id,
               },
               {
                 email: email3,
                 reversedHostname: 'rab.oss',
                 confirmedAt: new Date('2019-09-24'),
-                reconfirmedAt: reconfirmedAt,
+                reconfirmedAt,
               },
             ],
             samlIdentifiers: [

services/web/test/unit/src/User/UserRegistrationHandlerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/User/UserSessionsManagerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/UserMembership/UserMembershipHandlerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,

services/web/test/unit/src/UserMembership/UserMembershipViewModelTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
 */

services/web/test/unit/src/UserMembership/UserMembershipsHandlerTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
 */

services/web/test/unit/src/helpers/MockModel.js

@@ -32,7 +32,7 @@ module.exports = (modelName, requires = {}) => {
   }
 
   SandboxedModule.require('../../../../app/src/models/' + modelName, {
-    requires: requires,
+    requires,
   })
 
   return model

services/web/test/unit/src/infrastructure/CsrfTests.js

@@ -97,7 +97,7 @@ describe('Csrf', function () {
         let err
         this.Csrf = SandboxedModule.require(modulePath, {
           globals: {
-            console: console,
+            console,
           },
           requires: {
             csurf: (this.csurf = sinon
@@ -131,7 +131,7 @@ describe('Csrf', function () {
       it('calls the callback without an error', function () {
         this.Csrf = SandboxedModule.require(modulePath, {
           globals: {
-            console: console,
+            console,
           },
           requires: {
             csurf: (this.csurf = sinon
@@ -159,7 +159,7 @@ describe('Csrf', function () {
       it('calls the callback with `true`', function () {
         this.Csrf = SandboxedModule.require(modulePath, {
           globals: {
-            console: console,
+            console,
           },
           requires: {
             csurf: (this.csurf = sinon
@@ -177,7 +177,7 @@ describe('Csrf', function () {
       it('calls the callback with an error', function () {
         this.Csrf = SandboxedModule.require(modulePath, {
           globals: {
-            console: console,
+            console,
           },
           requires: {
             csurf: (this.csurf = sinon

services/web/test/unit/src/infrastructure/LockManager/getLockTests.js

@@ -1,5 +1,5 @@
 /* eslint-disable
-    node/handle-callback-err,
+    n/handle-callback-err,
     max-len,
     no-return-assign,
     no-unused-vars,