From e096bf051a4b22c593779b4b09741595f47bc354 Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Fri, 22 Apr 2022 10:44:26 +0100 Subject: [PATCH] Open the correct doc on tracked change click in overview (#7622) GitOrigin-RevId: 7bef9341c315f350c5428f8c94ce84cbc4f850c5 --- services/web/app/views/project/editor/review-panel.pug | 2 +- .../js/ide/review-panel/controllers/ReviewPanelController.js | 1 - .../js/ide/review-panel/directives/reviewPanelSorted.js | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/services/web/app/views/project/editor/review-panel.pug b/services/web/app/views/project/editor/review-panel.pug index 93f9cc9cd6..d0fdafe569 100644 --- a/services/web/app/views/project/editor/review-panel.pug +++ b/services/web/app/views/project/editor/review-panel.pug @@ -208,7 +208,7 @@ aggregate-change-entry( entry="entry" user="users[entry.metadata.user_id]" - ng-click="gotoEntry(editor.open_doc_id, entry)" + ng-click="gotoEntry(doc.doc.id, entry)" permissions="permissions" ) diff --git a/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js b/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js index 52f565fbf5..e40b570136 100644 --- a/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js +++ b/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js @@ -134,7 +134,6 @@ export default App.controller( $timeout(() => $scope.$broadcast('review-panel:layout')) ) - // TODO: unused? $scope.$on('review-panel:sizes', (e, sizes) => $scope.$broadcast('editor:set-scroll-size', sizes) ) diff --git a/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js b/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js index bbbcdda987..20a857f175 100644 --- a/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js +++ b/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js @@ -184,7 +184,6 @@ export default App.directive('reviewPanelSorted', $timeout => ({ overflowTop = 0 } - // TODO: unused? return scope.$emit('review-panel:sizes', { overflowTop, height: previousBottom + OVERVIEW_TOGGLE_HEIGHT,