From d53fa5de474104ca7ca39ab682157b6cfcf2c029 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Wed, 13 Jul 2016 14:14:51 +0100 Subject: [PATCH] avoid exception in pdf viewer when no visible pages --- .../ide/pdfng/directives/pdfViewer.coffee | 29 ++++++++++--------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/services/web/public/coffee/ide/pdfng/directives/pdfViewer.coffee b/services/web/public/coffee/ide/pdfng/directives/pdfViewer.coffee index 531749f519..80306771df 100644 --- a/services/web/public/coffee/ide/pdfng/directives/pdfViewer.coffee +++ b/services/web/public/coffee/ide/pdfng/directives/pdfViewer.coffee @@ -275,20 +275,21 @@ define [ getExtraPages = (visiblePages) -> extra = [] - firstVisiblePage = visiblePages[0].pageNum - firstVisiblePageIdx = firstVisiblePage - 1 - len = visiblePages.length - lastVisiblePage = visiblePages[len-1].pageNum - lastVisiblePageIdx = lastVisiblePage - 1 - # first page after - if lastVisiblePageIdx + 1 < scope.pages.length - extra.push scope.pages[lastVisiblePageIdx + 1] - # page before - if firstVisiblePageIdx > 0 - extra.push scope.pages[firstVisiblePageIdx - 1] - # second page after - if lastVisiblePageIdx + 2 < scope.pages.length - extra.push scope.pages[lastVisiblePageIdx + 2] + if visiblePages.length > 0 + firstVisiblePage = visiblePages[0].pageNum + firstVisiblePageIdx = firstVisiblePage - 1 + len = visiblePages.length + lastVisiblePage = visiblePages[len-1].pageNum + lastVisiblePageIdx = lastVisiblePage - 1 + # first page after + if lastVisiblePageIdx + 1 < scope.pages.length + extra.push scope.pages[lastVisiblePageIdx + 1] + # page before + if firstVisiblePageIdx > 0 + extra.push scope.pages[firstVisiblePageIdx - 1] + # second page after + if lastVisiblePageIdx + 2 < scope.pages.length + extra.push scope.pages[lastVisiblePageIdx + 2] return visiblePages.concat extra rescaleTimer = null