Merge pull request #16393 from overleaf/em-typescript-libraries

Add type checking to libraries

GitOrigin-RevId: bed79f5123081773d6ac6e27698246726184c5e6

libraries/overleaf-editor-core/package.json

@@ -3,13 +3,17 @@
   "version": "1.0.0",
   "description": "Library shared between the editor server and clients.",
   "main": "index.js",
+  "types": "types/index.js",
   "scripts": {
-    "test": "mocha",
-    "format": "prettier --list-different $PWD/'**/*.js'",
-    "format:fix": "prettier --write $PWD/'**/*.js'",
-    "lint": "eslint --max-warnings 0 --format unix lib test && tsc",
-    "lint:fix": "eslint --fix lib test",
-    "test:ci": "npm run test"
+    "test": "npm run lint && npm run format && npm run typecheck && npm run test:unit",
+    "format": "prettier --list-different $PWD/'**/*.{js,cjs}'",
+    "format:fix": "prettier --write $PWD/'**/*.{js,cjs}'",
+    "lint": "eslint --ext .js --ext .cjs --max-warnings 0 --format unix .",
+    "lint:fix": "eslint --fix --ext .js --ext .cjs .",
+    "test:ci": "npm run test:unit",
+    "typecheck": "tsc --noEmit",
+    "test:unit": "mocha --exit test/**/*.{js,cjs}",
+    "update-types": "rm -rf types && tsc --emitDeclarationOnly"
   },
   "author": "team@overleaf.com",
   "license": "Proprietary",

libraries/overleaf-editor-core/test/operation.test.js

@@ -62,8 +62,8 @@ describe('Operation', function () {
 
     return {
       snapshot: snapshotA,
-      operations: operations,
-      primeOperations: primeOperations,
+      operations,
+      primeOperations,
 
       log() {
         console.log(this)

libraries/overleaf-editor-core/tsconfig.json

@@ -1,14 +1,7 @@
 {
-  "compilerOptions": {
-    "allowJs": true,
-    "allowSyntheticDefaultImports": true,
-    "checkJs": true,
-    "esModuleInterop": true,
-    "lib": ["es2022"],
-    "module": "commonjs",
-    "noEmit": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true
-  },
-  "include": ["lib/**/*", "typings/**/*"]
+  "extends": "../../tsconfig.backend.json",
+  "include": [
+    "**/*.js",
+    "**/*.cjs"
+  ]
 }