diff --git a/services/web/app/src/Features/Compile/CompileController.js b/services/web/app/src/Features/Compile/CompileController.js index 20356f7a7a..34d92a4e59 100644 --- a/services/web/app/src/Features/Compile/CompileController.js +++ b/services/web/app/src/Features/Compile/CompileController.js @@ -72,13 +72,6 @@ async function _getSplitTestOptions(req, res) { // Lookup the clsi-cache flag in the backend. // We may need to turn off the feature on a short notice, without requiring // all users to reload their editor page to disable the feature. - const { variant: compileFromClsiCacheVariant } = - await SplitTestHandler.promises.getAssignment( - editorReq, - res, - 'compile-from-clsi-cache' - ) - const compileFromClsiCache = compileFromClsiCacheVariant === 'enabled' const { variant: populateClsiCacheVariant } = await SplitTestHandler.promises.getAssignment( editorReq, @@ -86,6 +79,7 @@ async function _getSplitTestOptions(req, res) { 'populate-clsi-cache' ) const populateClsiCache = populateClsiCacheVariant === 'enabled' + const compileFromClsiCache = populateClsiCache // use same split-test const pdfDownloadDomain = Settings.pdfDownloadDomain diff --git a/services/web/app/src/Features/Project/ProjectController.js b/services/web/app/src/Features/Project/ProjectController.js index c82c65c5da..2d949a8753 100644 --- a/services/web/app/src/Features/Project/ProjectController.js +++ b/services/web/app/src/Features/Project/ProjectController.js @@ -338,8 +338,7 @@ const _ProjectController = { 'external-socket-heartbeat', 'full-project-search', 'null-test-share-modal', - 'fall-back-to-clsi-cache', - 'initial-compile-from-clsi-cache', + 'populate-clsi-cache', 'pdf-caching-cached-url-lookup', 'pdf-caching-mode', 'pdf-caching-prefetch-large', diff --git a/services/web/frontend/js/features/pdf-preview/util/pdf-caching-flags.js b/services/web/frontend/js/features/pdf-preview/util/pdf-caching-flags.js index dd7ed2c1b5..fb2a5b12b2 100644 --- a/services/web/frontend/js/features/pdf-preview/util/pdf-caching-flags.js +++ b/services/web/frontend/js/features/pdf-preview/util/pdf-caching-flags.js @@ -30,4 +30,4 @@ export const projectOwnerHasPremiumOnPageLoad = getMeta( 'ol-projectOwnerHasPremiumOnPageLoad' ) export const fallBackToClsiCache = - projectOwnerHasPremiumOnPageLoad && isFlagEnabled('fall-back-to-clsi-cache') + projectOwnerHasPremiumOnPageLoad && isFlagEnabled('populate-clsi-cache') diff --git a/services/web/frontend/js/shared/context/local-compile-context.tsx b/services/web/frontend/js/shared/context/local-compile-context.tsx index ba63b406bd..e16fc53114 100644 --- a/services/web/frontend/js/shared/context/local-compile-context.tsx +++ b/services/web/frontend/js/shared/context/local-compile-context.tsx @@ -204,7 +204,7 @@ export const LocalCompileProvider: FC = ({ // fetch initial compile response from cache const [initialCompileFromCache, setInitialCompileFromCache] = useState( getMeta('ol-projectOwnerHasPremiumOnPageLoad') && - isSplitTestEnabled('initial-compile-from-clsi-cache') && + isSplitTestEnabled('populate-clsi-cache') && // Avoid fetching the initial compile from cache in PDF detach tab role !== 'detached' ) diff --git a/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx b/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx index db637c1f77..fd2075236c 100644 --- a/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx +++ b/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx @@ -47,7 +47,7 @@ describe('', function () { 'https://compiles-user.dev-overleaf.com' ) window.metaAttributesCache.set('ol-splitTestVariants', { - 'initial-compile-from-clsi-cache': 'enabled', + 'populate-clsi-cache': 'enabled', }) window.metaAttributesCache.set('ol-projectOwnerHasPremiumOnPageLoad', true) cy.interceptEvents()