From afa011c813ffde77681a1e2b466f951f90d92abe Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Tue, 6 Jun 2017 16:11:00 +0100 Subject: [PATCH] Avoid flickering when elements enter the review panel. --- .../directives/reviewPanelSorted.coffee | 15 ++++++++++++--- .../stylesheets/app/editor/review-panel.less | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/services/web/public/coffee/ide/review-panel/directives/reviewPanelSorted.coffee b/services/web/public/coffee/ide/review-panel/directives/reviewPanelSorted.coffee index 236668c5ab..5178178387 100644 --- a/services/web/public/coffee/ide/review-panel/directives/reviewPanelSorted.coffee +++ b/services/web/public/coffee/ide/review-panel/directives/reviewPanelSorted.coffee @@ -63,7 +63,10 @@ define [ # Put the focused entry as close to where it wants to be as possible focused_entry_top = Math.max(focused_entry.scope.entry.screenPos.y, TOOLBAR_HEIGHT) - focused_entry.$box_el.css(top: focused_entry_top) + focused_entry.$box_el.css( + top: focused_entry_top + visibility: "visible" + ) focused_entry.$indicator_el.css(top: focused_entry_top) positionLayoutEl(focused_entry.$callout_el, focused_entry.scope.entry.screenPos.y, focused_entry_top) @@ -73,7 +76,10 @@ define [ height = entry.height top = Math.max(original_top, previousBottom + PADDING) previousBottom = top + height - entry.$box_el.css(top: top) + entry.$box_el.css( + top: top + visibility: "visible" + ) entry.$indicator_el.css(top: top) positionLayoutEl(entry.$callout_el, original_top, top) sl_console.log "ENTRY", {entry: entry.scope.entry, top} @@ -89,7 +95,10 @@ define [ bottom = Math.min(original_bottom, previousTop - PADDING) top = bottom - height previousTop = top - entry.$box_el.css(top: top) + entry.$box_el.css( + top: top + visibility: "visible" + ) entry.$indicator_el.css(top: top) positionLayoutEl(entry.$callout_el, original_top, top) sl_console.log "ENTRY", {entry: entry.scope.entry, top} diff --git a/services/web/public/stylesheets/app/editor/review-panel.less b/services/web/public/stylesheets/app/editor/review-panel.less index 4a5ca516ea..312b933b85 100644 --- a/services/web/public/stylesheets/app/editor/review-panel.less +++ b/services/web/public/stylesheets/app/editor/review-panel.less @@ -261,6 +261,7 @@ } } .rp-state-current-file-expanded & { + visibility: hidden; left: 5px; right: 5px; width: auto;