Merge pull request #17748 from overleaf/bg-node-security-upgrade-2024-04-05
upgrade node version to 18.20.1 GitOrigin-RevId: 28f8f7c7f63285f7b7355e65713d9ed2dbda8a0e
This commit is contained in:
@@ -1 +1 @@
|
||||
18.19.1
|
||||
18.20.1
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
# Instead run bin/update_build_scripts from
|
||||
# https://github.com/overleaf/internal/
|
||||
|
||||
FROM node:18.19.1 as base
|
||||
FROM node:18.20.1 as base
|
||||
|
||||
WORKDIR /overleaf/services/chat
|
||||
|
||||
|
||||
@@ -31,10 +31,10 @@ HERE=$(shell pwd)
|
||||
MONOREPO=$(shell cd ../../ && pwd)
|
||||
# Run the linting commands in the scope of the monorepo.
|
||||
# Eslint and prettier (plus some configs) are on the root.
|
||||
RUN_LINTING = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(HERE) node:18.19.1 npm run --silent
|
||||
RUN_LINTING = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(HERE) node:18.20.1 npm run --silent
|
||||
|
||||
# Same but from the top of the monorepo
|
||||
RUN_LINTING_MONOREPO = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(MONOREPO) node:18.19.1 npm run --silent
|
||||
RUN_LINTING_MONOREPO = docker run --rm -v $(MONOREPO):$(MONOREPO) -w $(MONOREPO) node:18.20.1 npm run --silent
|
||||
|
||||
format:
|
||||
$(RUN_LINTING) format
|
||||
|
||||
@@ -4,6 +4,6 @@ chat
|
||||
--env-add=
|
||||
--env-pass-through=
|
||||
--esmock-loader=False
|
||||
--node-version=18.19.1
|
||||
--node-version=18.20.1
|
||||
--public-repo=False
|
||||
--script-version=4.5.0
|
||||
|
||||
@@ -6,7 +6,7 @@ version: "2.3"
|
||||
|
||||
services:
|
||||
test_unit:
|
||||
image: node:18.19.1
|
||||
image: node:18.20.1
|
||||
volumes:
|
||||
- .:/overleaf/services/chat
|
||||
- ../../node_modules:/overleaf/node_modules
|
||||
@@ -20,7 +20,7 @@ services:
|
||||
user: node
|
||||
|
||||
test_acceptance:
|
||||
image: node:18.19.1
|
||||
image: node:18.20.1
|
||||
volumes:
|
||||
- .:/overleaf/services/chat
|
||||
- ../../node_modules:/overleaf/node_modules
|
||||
|
||||
Reference in New Issue
Block a user