Upgrade async package to 3.2.2 (#8447)

* Revert "Revert "Bump async to 3.2.2 (#7618)""

This reverts commit 75153a555211d654744c2e61e27fe21085826c22.

* [web] fix usage of async.queue.drain in script

* [clsi] fix usage of async.queue.drain

* [spelling] fix usage of async.queue.drain

* [redis-wrapper] fix usage of async.queue.drain

* [web] Test that LockManager queue is cleared

This protects against a regression found when upgrading the
async package. Here we test that the `queue.drain` callback
is really getting called, and the lock is being removed from
the LOCK_QUEUES map.

* [redis-wrapper] Upgrade async to 3.2.2

GitOrigin-RevId: df921e6d7f1d505bd467f22e58600ba1aff48869

services/track-changes/app/js/UpdatesManager.js

@@ -591,11 +591,13 @@ module.exports = UpdatesManager = {
             }
             // repeatedly get updates and pass them through the summariser to get an final output with user info
             return async.whilst(
-              () =>
+              cb =>
                 // console.log "checking iterator.done", iterator.done()
-                summarizedUpdates.length < options.min_count &&
-                !iterator.done(),
-
+                cb(
+                  null,
+                  summarizedUpdates.length < options.min_count &&
+                    !iterator.done()
+                ),
               cb =>
                 iterator.next(function (err, partialUpdates) {
                   if (err != null) {
@@ -651,7 +653,7 @@ module.exports = UpdatesManager = {
         const accumulatedUserIds = new Set()
 
         async.whilst(
-          () => !iterator.done(),
+          cb => cb(null, !iterator.done()),
 
           cb =>
             iterator.next((err, updatesFromASinglePack) => {