From a42cc48be8f959faef34be71f138511beafd6db1 Mon Sep 17 00:00:00 2001 From: James Allen Date: Thu, 12 Jan 2017 13:44:54 +0100 Subject: [PATCH] Fix doc names and sort order in resolved comments dropdown --- services/web/app/views/project/editor/review-panel.jade | 2 +- .../ide/review-panel/directives/resolvedCommentsDropdown.coffee | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/services/web/app/views/project/editor/review-panel.jade b/services/web/app/views/project/editor/review-panel.jade index fca2022bfa..f3e9457558 100644 --- a/services/web/app/views/project/editor/review-panel.jade +++ b/services/web/app/views/project/editor/review-panel.jade @@ -289,7 +289,7 @@ script(type='text/ng-template', id='resolvedCommentsDropdownTemplate') ng-if="!isLoading" ) resolved-comment-entry( - ng-repeat="thread in resolvedComments | orderBy:'-resolved_at'" + ng-repeat="thread in resolvedComments | orderBy:'resolved_at':true" thread="thread" on-unresolve="handleUnresolve(threadId);" on-delete="handleDelete(entryId, threadId);" diff --git a/services/web/public/coffee/ide/review-panel/directives/resolvedCommentsDropdown.coffee b/services/web/public/coffee/ide/review-panel/directives/resolvedCommentsDropdown.coffee index 251db60df1..f161338324 100644 --- a/services/web/public/coffee/ide/review-panel/directives/resolvedCommentsDropdown.coffee +++ b/services/web/public/coffee/ide/review-panel/directives/resolvedCommentsDropdown.coffee @@ -33,7 +33,7 @@ define [ scope.onDelete({ entryId, threadId }) getDocNameById = (docId) -> - doc = _.find(scope.docs, (doc) -> doc.doc.id = docId) + doc = _.find(scope.docs, (doc) -> doc.doc.id == docId) if doc? return doc.path else