Merge pull request #3830 from overleaf/em-upgrade-node-12

Upgrade to Node 12

GitOrigin-RevId: 19870922884b7c98e7e5f2c94df21829672d2db5

services/web/modules/launchpad/test/unit/src/LaunchpadControllerTests.js

@@ -12,7 +12,6 @@
  */
 const SandboxedModule = require('sandboxed-module')
 const assert = require('assert')
-require('chai').should()
 const { expect } = require('chai')
 const sinon = require('sinon')
 const modulePath = require('path').join(
@@ -31,17 +30,8 @@ describe('LaunchpadController', function() {
 
     this.User = {}
     this.LaunchpadController = SandboxedModule.require(modulePath, {
-      globals: {
-        console: console
-      },
       requires: {
         'settings-sharelatex': (this.Settings = {}),
-        'logger-sharelatex': (this.Logger = {
-          log() {},
-          warn() {},
-          err() {},
-          error() {}
-        }),
         '@overleaf/metrics': (this.Metrics = {}),
         '../../../../app/src/Features/User/UserRegistrationHandler': (this.UserRegistrationHandler = {}),
         '../../../../app/src/Features/Email/EmailHandler': (this.EmailHandler = {}),

services/web/modules/user-activate/test/unit/src/UserActivateControllerTests.js

@@ -19,9 +19,6 @@ describe('UserActivateController', function() {
     this.UserGetter = { getUser: sinon.stub() }
     this.ErrorController = { notFound: sinon.stub() }
     this.UserActivateController = SandboxedModule.require(MODULE_PATH, {
-      globals: {
-        console: console
-      },
       requires: {
         '../../../../app/src/Features/User/UserGetter': this.UserGetter,
         '../../../../app/src/Features/Errors/ErrorController': this