From 9c7a10aa39da85b13d25b2fcbd1a290bf0d33995 Mon Sep 17 00:00:00 2001 From: claude Date: Wed, 10 Jun 2026 08:06:00 +0000 Subject: [PATCH] fix: correct import path and minor issues in quartoFlavor update MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix wrong import path '../models/Project.mjs' → '../../models/Project.mjs' (from Features/Compile/, '..' is Features/, not src/; the server would crash on startup with ERR_MODULE_NOT_FOUND in Node.js ESM) - Log MongoDB errors instead of silently swallowing them - Remove null from Mongoose String enum (not a valid enum value for strings) Co-Authored-By: Claude Sonnet 4.6 --- services/web/app/src/Features/Compile/CompileController.mjs | 6 ++++-- services/web/app/src/models/Project.mjs | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/services/web/app/src/Features/Compile/CompileController.mjs b/services/web/app/src/Features/Compile/CompileController.mjs index 12609b055d..7af92f7e63 100644 --- a/services/web/app/src/Features/Compile/CompileController.mjs +++ b/services/web/app/src/Features/Compile/CompileController.mjs @@ -1,7 +1,7 @@ import { pipeline } from 'node:stream/promises' import Metrics from '@overleaf/metrics' import ProjectGetter from '../Project/ProjectGetter.mjs' -import { Project } from '../models/Project.mjs' +import { Project } from '../../models/Project.mjs' import CompileManager from './CompileManager.mjs' import ClsiManager from './ClsiManager.mjs' import logger from '@overleaf/logger' @@ -308,7 +308,9 @@ const _CompileController = { Project.updateOne( { _id: projectId }, { quartoFlavor: isHtml ? 'revealjs' : 'pdf' } - ).exec().catch(() => {}) + ).exec().catch(err => + logger.warn({ err, projectId }, 'failed to update quartoFlavor') + ) } res.json({ diff --git a/services/web/app/src/models/Project.mjs b/services/web/app/src/models/Project.mjs index 8415fb4fda..db497eecf6 100644 --- a/services/web/app/src/models/Project.mjs +++ b/services/web/app/src/models/Project.mjs @@ -38,7 +38,7 @@ export const ProjectSchema = new Schema( version: { type: Number }, // incremented for every change in the project structure (folders and filenames) publicAccesLevel: { type: String, default: 'private' }, compiler: { type: String, default: settings.defaultLatexCompiler }, - quartoFlavor: { type: String, enum: ['revealjs', 'pdf', null] }, + quartoFlavor: { type: String, enum: ['revealjs', 'pdf'] }, spellCheckLanguage: { type: String, default: 'en' }, deletedByExternalDataSource: { type: Boolean, default: false }, description: { type: String, default: '' },