From 8e53d660798b39fe1709655227cb89c656c9314c Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Tue, 12 Jan 2016 10:36:14 +0000 Subject: [PATCH] log the key for lock timeouts --- services/track-changes/app/coffee/LockManager.coffee | 4 +++- .../test/unit/coffee/LockManager/LockManagerTests.coffee | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/services/track-changes/app/coffee/LockManager.coffee b/services/track-changes/app/coffee/LockManager.coffee index 9ed089ed47..89a194e5de 100644 --- a/services/track-changes/app/coffee/LockManager.coffee +++ b/services/track-changes/app/coffee/LockManager.coffee @@ -36,7 +36,9 @@ module.exports = LockManager = startTime = Date.now() do attempt = () -> if Date.now() - startTime > LockManager.MAX_LOCK_WAIT_TIME - return callback(new Error("Timeout")) + e = new Error("Timeout") + e.key = key + return callback(e) LockManager.tryLock key, (error, gotLock, lockValue) -> return callback(error) if error? diff --git a/services/track-changes/test/unit/coffee/LockManager/LockManagerTests.coffee b/services/track-changes/test/unit/coffee/LockManager/LockManagerTests.coffee index 266b12b120..d6744137ed 100644 --- a/services/track-changes/test/unit/coffee/LockManager/LockManagerTests.coffee +++ b/services/track-changes/test/unit/coffee/LockManager/LockManagerTests.coffee @@ -129,7 +129,7 @@ describe "LockManager", -> done() it "should return the callback with an error", -> - @callback.calledWith(new Error("timeout")).should.equal true + @callback.calledWith(sinon.match.instanceOf(Error)).should.equal true describe "runWithLock", -> describe "with successful run", ->