alois/Verso
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2241 from overleaf/ta-file-preview-footer

Browse Source 
Move File Preview Footer to Header

GitOrigin-RevId: b6c8d09f82520ceaebf0c6ee414445e4487e8894
This commit is contained in:
Simon Detheridge
2019-10-18 16:41:19 +00:00
committed by sharelatex
parent e502b80116
commit 8a46a385f7
4 changed files with 70 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/public/src/ide/binary-files/controllers/BinaryFileController.js
+2 -2
View File
@@ -184,8 +184,8 @@ define(['base', 'moment'], (App, moment) =>
function setPreviewHeight() {
const $preview = $element.find('.text-preview .scroll-container')
const $footer = $element.find('.binary-file-footer')
const maxHeight = $element.height() - $footer.height() - 14 // borders + margin
const $header = $element.find('.binary-file-header')
const maxHeight = $element.height() - $header.height() - 14 // borders + margin
$preview.css({ 'max-height': maxHeight })
// Don't show the preview until we've set the height, otherwise we jump around
$scope.textPreview.loading = false
services/web/public/stylesheets/app/editor/binary-file.less
+4 -3
View File
@@ -8,7 +8,7 @@
max-height: 90%;
display: block;
margin: auto;
margin-bottom: @line-height-computed / 2;
margin-top: @line-height-computed / 2;
border: 1px solid @gray;
.box-shadow(0 2px 3px @gray;);
background-color: white;
@@ -19,16 +19,17 @@
min-height: 200px;
}
p.no-preview {
margin-top: @line-height-computed / 2;
font-size: 24px;
color: @gray;
}
.text-loading {
margin-top: @line-height-computed / 2;
font-size: 24px;
color: @gray;
margin-bottom: 12px;
}
.text-preview {
margin-bottom: 12px;
margin-top: @line-height-computed / 2;
.scroll-container {
background-color: white;
font-size: 0.8em;