Add recaptch to share endpoint

2017-12-11 11:57:59 +00:00
parent 74cc13a888
commit 83086e4a79
7 changed files with 104 additions and 34 deletions
@@ -38,6 +38,7 @@ describe "CollaboratorsInviteController", ->
 			'../Authentication/AuthenticationController': @AuthenticationController
 			'settings-sharelatex': @settings = {}
 			"../../infrastructure/RateLimiter":@RateLimiter
+			'request': @request = {}
 		@res = new MockResponse()
 		@req = new MockRequest()

@@ -96,6 +97,7 @@ describe "CollaboratorsInviteController", ->
 			@req.body =
 				email: @targetEmail
 				privileges: @privileges = "readAndWrite"
+				'g-recaptcha-response': @grecaptchaResponse = 'grecaptcha response'
 			@res.json = sinon.stub()
 			@res.sendStatus = sinon.stub()
 			@invite = {
@@ -108,6 +110,8 @@ describe "CollaboratorsInviteController", ->
 			}
 			@LimitationsManager.canAddXCollaborators = sinon.stub().callsArgWith(2, null, true)
 			@CollaboratorsInviteHandler.inviteToProject = sinon.stub().callsArgWith(4, null, @invite)
+			@CollaboratorsInviteController._validateCaptcha = sinon.stub()
+			@CollaboratorsInviteController._validateCaptcha.withArgs(@grecaptchaResponse).yields(null, true)
 			@callback = sinon.stub()
 			@next = sinon.stub()

@@ -285,6 +289,17 @@ describe "CollaboratorsInviteController", ->
 			it 'should not call emitToRoom', ->
 				@EditorRealTimeController.emitToRoom.called.should.equal false

+		describe "when recaptcha is not valid", ->
+			beforeEach ->
+				@CollaboratorsInviteController._validateCaptcha = sinon.stub().yields(null, false)
+				@CollaboratorsInviteController.inviteToProject @req, @res, @next
+
+			it "should return 400", ->
+				@res.sendStatus.calledWith(400).should.equal true
+
+			it "should not inviteToProject", ->
+				@CollaboratorsInviteHandler.inviteToProject.called.should.equal false
+
 	describe "viewInvite", ->

 		beforeEach ->