Merge pull request #23372 from overleaf/ls-update-pricing-logic-for-seats-adding

Update pricing logic for seats adding

GitOrigin-RevId: 8312941c88ade2e5ee83c806939628714880b416

services/web/test/unit/src/Subscription/RecurlyClientTests.js

@@ -50,7 +50,6 @@ describe('RecurlyClient', function () {
       total: 16.5,
       periodStart: new Date(),
       periodEnd: new Date(),
-      createdAt: new Date(),
       collectionMethod: 'automatic',
     })
 
@@ -81,7 +80,6 @@ describe('RecurlyClient', function () {
       currency: this.subscription.currency,
       currentPeriodStartedAt: this.subscription.periodStart,
       currentPeriodEndsAt: this.subscription.periodEnd,
-      createdAt: this.subscription.createdAt,
       collectionMethod: this.subscription.collectionMethod,
     }
 

services/web/test/unit/src/Subscription/RecurlyEntitiesTest.js

@@ -372,7 +372,6 @@ describe('RecurlyEntities', function () {
           total: 11.5,
           periodStart: new Date(),
           periodEnd: new Date(),
-          createdAt: new Date(),
           collectionMethod: 'automatic',
         })
         const change = new RecurlySubscriptionChange({

services/web/test/unit/src/Subscription/SubscriptionGroupHandlerTests.js

@@ -50,7 +50,6 @@ describe('SubscriptionGroupHandler', function () {
       getRequestForFlexibleLicensingGroupPlanUpgrade: sinon
         .stub()
         .returns(this.changeRequest),
-      createdAt: '2025-01-01T00:00:00Z',
       currency: 'USD',
       hasAddOn(code) {
         return this.addOns.some(addOn => addOn.code === code)
@@ -472,7 +471,10 @@ describe('SubscriptionGroupHandler', function () {
         })
 
         it('should return the subscription change preview with legacy add-on price', async function () {
-          this.recurlySubscription.createdAt = '2025-01-01T00:00:00Z'
+          this.recurlySubscription.planPrice =
+            this.GroupPlansData.enterprise.collaborator.USD[5].price_in_cents /
+              100 -
+            1
 
           preview =
             await this.Handler.promises.previewAddSeatsSubscriptionChange(
@@ -490,7 +492,9 @@ describe('SubscriptionGroupHandler', function () {
         })
 
         it('should return the subscription change preview with non-legacy add-on price', async function () {
-          this.recurlySubscription.createdAt = '2030-01-01T00:00:00Z'
+          this.recurlySubscription.planPrice =
+            this.GroupPlansData.enterprise.collaborator.USD[5].price_in_cents /
+            100
 
           preview =
             await this.Handler.promises.previewAddSeatsSubscriptionChange(