From 6a679023d30bc13cbc9fb18a1ba96f7547363cd3 Mon Sep 17 00:00:00 2001 From: Simon Detheridge Date: Sat, 4 Jan 2020 17:15:21 +0000 Subject: [PATCH] Fix order of .status().send() --- services/filestore/app.js | 2 +- services/filestore/app/js/ExceptionHandler.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/services/filestore/app.js b/services/filestore/app.js index d80514738c..1e84440eb6 100644 --- a/services/filestore/app.js +++ b/services/filestore/app.js @@ -143,7 +143,7 @@ app.get('/status', function(req, res) { res.send('filestore sharelatex up') } else { logger.log('app is not ok - shutting down') - res.send('server is being shut down').status(500) + res.status(500).send('server is being shut down') } }) diff --git a/services/filestore/app/js/ExceptionHandler.js b/services/filestore/app/js/ExceptionHandler.js index 122e78805c..d52c00bb2c 100644 --- a/services/filestore/app/js/ExceptionHandler.js +++ b/services/filestore/app/js/ExceptionHandler.js @@ -57,7 +57,7 @@ class ExceptionHandler { // request a shutdown to prevent memory leaks this.beginShutdown() if (!res.headerSent) { - res.send('uncaught exception').status(500) + res.status(500).send('uncaught exception') } req = { body: req.body,