diff --git a/services/chat/.eslintrc b/services/chat/.eslintrc index 17fc388ece..a35d42c503 100644 --- a/services/chat/.eslintrc +++ b/services/chat/.eslintrc @@ -20,11 +20,6 @@ "mocha": true }, "rules": { - // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) - // START of temporary overrides - "prefer-regex-literals": "off", - // END of temporary overrides - // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error", diff --git a/services/clsi/.eslintrc b/services/clsi/.eslintrc index 17fc388ece..a35d42c503 100644 --- a/services/clsi/.eslintrc +++ b/services/clsi/.eslintrc @@ -20,11 +20,6 @@ "mocha": true }, "rules": { - // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) - // START of temporary overrides - "prefer-regex-literals": "off", - // END of temporary overrides - // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error", diff --git a/services/contacts/.eslintrc b/services/contacts/.eslintrc index 17fc388ece..a35d42c503 100644 --- a/services/contacts/.eslintrc +++ b/services/contacts/.eslintrc @@ -20,11 +20,6 @@ "mocha": true }, "rules": { - // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) - // START of temporary overrides - "prefer-regex-literals": "off", - // END of temporary overrides - // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error", diff --git a/services/docstore/.eslintrc b/services/docstore/.eslintrc index 17fc388ece..a35d42c503 100644 --- a/services/docstore/.eslintrc +++ b/services/docstore/.eslintrc @@ -20,11 +20,6 @@ "mocha": true }, "rules": { - // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) - // START of temporary overrides - "prefer-regex-literals": "off", - // END of temporary overrides - // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error", diff --git a/services/document-updater/.eslintrc b/services/document-updater/.eslintrc index 17fc388ece..a35d42c503 100644 --- a/services/document-updater/.eslintrc +++ b/services/document-updater/.eslintrc @@ -20,11 +20,6 @@ "mocha": true }, "rules": { - // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) - // START of temporary overrides - "prefer-regex-literals": "off", - // END of temporary overrides - // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error", diff --git a/services/filestore/.eslintrc b/services/filestore/.eslintrc index 17fc388ece..a35d42c503 100644 --- a/services/filestore/.eslintrc +++ b/services/filestore/.eslintrc @@ -20,11 +20,6 @@ "mocha": true }, "rules": { - // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) - // START of temporary overrides - "prefer-regex-literals": "off", - // END of temporary overrides - // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error", diff --git a/services/filestore/test/acceptance/js/TestConfig.js b/services/filestore/test/acceptance/js/TestConfig.js index 97791f0e51..61ea09361f 100644 --- a/services/filestore/test/acceptance/js/TestConfig.js +++ b/services/filestore/test/acceptance/js/TestConfig.js @@ -26,7 +26,7 @@ function gcsConfig() { apiScheme: process.env.GCS_API_SCHEME, projectId: 'fake', }, - directoryKeyRegex: new RegExp('^[0-9a-fA-F]{24}/[0-9a-fA-F]{24}'), + directoryKeyRegex: /^[0-9a-fA-F]{24}\/[0-9a-fA-F]{24}/, unlockBeforeDelete: false, // fake-gcs does not support this deletedBucketSuffix: '-deleted', } diff --git a/services/notifications/.eslintrc b/services/notifications/.eslintrc index 17fc388ece..a35d42c503 100644 --- a/services/notifications/.eslintrc +++ b/services/notifications/.eslintrc @@ -20,11 +20,6 @@ "mocha": true }, "rules": { - // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) - // START of temporary overrides - "prefer-regex-literals": "off", - // END of temporary overrides - // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error", diff --git a/services/real-time/.eslintrc b/services/real-time/.eslintrc index 17fc388ece..a35d42c503 100644 --- a/services/real-time/.eslintrc +++ b/services/real-time/.eslintrc @@ -20,11 +20,6 @@ "mocha": true }, "rules": { - // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) - // START of temporary overrides - "prefer-regex-literals": "off", - // END of temporary overrides - // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error", diff --git a/services/spelling/.eslintrc b/services/spelling/.eslintrc index 17fc388ece..a35d42c503 100644 --- a/services/spelling/.eslintrc +++ b/services/spelling/.eslintrc @@ -20,11 +20,6 @@ "mocha": true }, "rules": { - // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) - // START of temporary overrides - "prefer-regex-literals": "off", - // END of temporary overrides - // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error", diff --git a/services/spelling/app/js/ASpellWorker.js b/services/spelling/app/js/ASpellWorker.js index 761fccdedf..8cb55a9551 100644 --- a/services/spelling/app/js/ASpellWorker.js +++ b/services/spelling/app/js/ASpellWorker.js @@ -113,7 +113,7 @@ class ASpellWorker { this.pipe.stdout.setEncoding('utf8') // ensure utf8 output is handled correctly let output = '' - const endMarkerRegex = new RegExp('^[a-z][a-z]', 'gm') + const endMarkerRegex = /^[a-z]{2}/gm this.pipe.stdout.on('data', data => { // We receive the language code from Aspell as the end of data marker in // the data. The input is a utf8 encoded string. diff --git a/services/track-changes/.eslintrc b/services/track-changes/.eslintrc index 17fc388ece..a35d42c503 100644 --- a/services/track-changes/.eslintrc +++ b/services/track-changes/.eslintrc @@ -20,11 +20,6 @@ "mocha": true }, "rules": { - // TODO(das7pad): remove overrides after fixing all the violations manually (https://github.com/overleaf/issues/issues/3882#issuecomment-878999671) - // START of temporary overrides - "prefer-regex-literals": "off", - // END of temporary overrides - // Swap the no-unused-expressions rule with a more chai-friendly one "no-unused-expressions": 0, "chai-friendly/no-unused-expressions": "error",