alois/Verso
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #16062 from overleaf/jdt-ieee-eslint-fix

Browse Source 
fix: missing setting on test causing eslint failure
GitOrigin-RevId: fff96acd389cfe30a1e89404a08a87543f503089
This commit is contained in:
Jimmy Domagala-Tang
2023-12-08 09:04:50 +00:00
committed by Copybot
parent 24261ac617
commit 5c84ea8895
6 changed files with 43 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/web/frontend/js/features/editor-left-menu/components/settings/settings-overall-theme.tsx
+6 -4
View File
@@ -6,6 +6,7 @@ import SettingsMenuSelect, { Option } from './settings-menu-select'
import { useProjectSettingsContext } from '../../context/project-settings-context'
import type { OverallThemeMeta } from '../../../../../../types/project-settings'
import type { OverallTheme } from '../../../source-editor/extensions/theme'
import { ExposedSettings } from '../../../../../../types/exposed-settings'
export default function SettingsOverallTheme() {
const { t } = useTranslation()
@@ -24,10 +25,11 @@ export default function SettingsOverallTheme() {
[overallThemes]
)
// TODO: check for IEEE brand by:
// - const brandVariation = getMeta('ol-brandVariation') as any[]
// - settings.overleaf != null && !isIEEE(brandVariation)
if (!overallThemes) {
const brandVariation = getMeta('ol-brandVariation') as any
const { ieeeBrandId } = getMeta('ol-ExposedSettings') as ExposedSettings
const isIEEEBranded = brandVariation?.brand_id === ieeeBrandId
if (!overallThemes || isIEEEBranded) {
return null
}