From 49b38c7075734a97c902d9a5415aa73e8e2a0400 Mon Sep 17 00:00:00 2001 From: M Fahru Date: Mon, 10 Jun 2024 07:10:11 -0700 Subject: [PATCH] Merge pull request #18750 from overleaf/mf-new-plans-page-content-border [web] Add border around new plans page main content GitOrigin-RevId: fb09e8b97b60281d0776f237eec0cf0e3e7c44f4 --- .../app/plans/plans-new-design.less | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/services/web/frontend/stylesheets/app/plans/plans-new-design.less b/services/web/frontend/stylesheets/app/plans/plans-new-design.less index 3381a9cc06..415ed0868e 100644 --- a/services/web/frontend/stylesheets/app/plans/plans-new-design.less +++ b/services/web/frontend/stylesheets/app/plans/plans-new-design.less @@ -1,14 +1,53 @@ +@z-index-plans-new-tabs: 1; +@z-index-plans-new-tabs-content: 0; + .plans-new-design { .plans-new-content { display: flex; flex-direction: column; align-items: center; + + @media (min-width: @screen-sm-min) { + border-left: 1px solid var(--neutral-20); + border-right: 1px solid var(--neutral-20); + border-bottom: 1px solid var(--neutral-20); + border-radius: 8px; + } + + // this is the border between the tabs and the content, specifically on the left and right side + // this is necessary to enable top border radius on the plans-new-content + &::before { + content: ''; + display: block; + z-index: @z-index-plans-new-tabs-content; + position: absolute; + top: -1px; // make border overlap with the border on .plans-new-tabs + width: 100%; + height: 20px; // arbitrary height since it's transparent, make sure that it's bigger than border radius + background: transparent; + border-top: 1px solid var(--neutral-20); + + @media (min-width: @screen-sm-min) { + border-top-left-radius: 8px; + border-top-right-radius: 8px; + } + } + } + + .plans-new-tabs-container { + z-index: @z-index-plans-new-tabs; + + // explicit padding to tell that the bottom left and bottom right + // does not have bottom border defined in .plans-new-tabs + // technically unnecessary because padding is already defined in bootstrap column + padding: 0 16px; } .plans-new-tabs { display: flex; justify-content: center; gap: 8px; + border-bottom: 1px solid var(--neutral-20); .plans-new-tab { cursor: pointer;