From 19f1a9ad82457eea53936f3e49aee3dd1980f3af Mon Sep 17 00:00:00 2001
From: Henry Oswald <henry.oswald@sharelatex.com>
Date: Tue, 2 Jun 2015 10:59:35 +0100
Subject: [PATCH] changed style of async jobs to map to use underscore which is
 like we use in the rest of the stack. Also removed a few => binds which are
 not needed

---
 .../docstore/app/coffee/DocManager.coffee     | 48 +++++++++----------
 1 file changed, 23 insertions(+), 25 deletions(-)

diff --git a/services/docstore/app/coffee/DocManager.coffee b/services/docstore/app/coffee/DocManager.coffee
index 205128a72f..aae71bc2d3 100644
--- a/services/docstore/app/coffee/DocManager.coffee
+++ b/services/docstore/app/coffee/DocManager.coffee
@@ -70,18 +70,17 @@ module.exports = DocManager =
 			else if !docs?
 				return callback new Errors.NotFoundError("No docs for project #{project_id}")
 
-			jobs = for doc in docs
-				do (doc) =>
-					(cb) => 
-						logger.log project_id: project_id, doc_id: doc._id, "sending doc to s3"
-						options = buildS3Options(doc.lines, project_id+"/"+doc._id)
-						request.put options, (err, res)->
-							if err? || res.statusCode != 200
-								logger.err err:err, res:res, "something went wrong archiving doc in aws"
-								cb(err)
-							MongoManager.markDocAsArchived doc._id, (error) ->
-								return cb(error) if error?
-								cb()
+			jobs = _.map docs, (doc) ->
+				(cb)->
+					logger.log project_id: project_id, doc_id: doc._id, "sending doc to s3"
+					options = buildS3Options(doc.lines, project_id+"/"+doc._id)
+					request.put options, (err, res)->
+						if err? || res.statusCode != 200
+							logger.err err:err, res:res, "something went wrong archiving doc in aws"
+							cb(err)
+						MongoManager.markDocAsArchived doc._id, (error) ->
+							return cb(error) if error?
+							cb()
 
 			async.series jobs, callback
 
@@ -92,21 +91,20 @@ module.exports = DocManager =
 			else if !docs?
 				return callback new Errors.NotFoundError("No docs for project #{project_id}")
 
-			jobs = for doc in docs
-				do (doc) =>
+			jobs = _.map docs, (doc) ->
+				(cb)->
 					if !doc.inS3?
-						(cb) => cb()
+						return cb()
 					else
-						(cb) => 
-							logger.log project_id: project_id, doc_id: doc._id, "getting doc from s3"
-							options = buildS3Options(true, project_id+"/"+doc._id)
-							request.get options, (err, res, lines)->
-								if err? || res.statusCode != 200
-									logger.err err:err, res:res, "something went wrong unarchiving doc from aws"
-									cb(err)
-								MongoManager.upsertIntoDocCollection project_id, doc._id.toString(), lines, (error) ->
-									return cb(error) if error?
-									cb()
+						logger.log project_id: project_id, doc_id: doc._id, "getting doc from s3"
+						options = buildS3Options(true, project_id+"/"+doc._id)
+						request.get options, (err, res, lines)->
+							if err? || res.statusCode != 200
+								logger.err err:err, res:res, "something went wrong unarchiving doc from aws"
+								cb(err)
+							MongoManager.upsertIntoDocCollection project_id, doc._id.toString(), lines, (error) ->
+								return cb(error) if error?
+								cb()
 
 			async.series jobs, callback