From 1541eb319c5357ead6b3dc9829b4103dc6147470 Mon Sep 17 00:00:00 2001 From: Henry Oswald Date: Wed, 2 Dec 2015 10:10:52 +0000 Subject: [PATCH] add more null checks to health check --- services/docstore/app/coffee/HealthChecker.coffee | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/services/docstore/app/coffee/HealthChecker.coffee b/services/docstore/app/coffee/HealthChecker.coffee index 3818afc822..d0c181143d 100644 --- a/services/docstore/app/coffee/HealthChecker.coffee +++ b/services/docstore/app/coffee/HealthChecker.coffee @@ -28,9 +28,11 @@ module.exports = if err? logger.err err:err, "docstore returned a error in health check get" cb(err) + else if !res? + cb("no response from docstore with get check") else if res?.statusCode != 200 cb("status code not 200, its #{res.statusCode}") - else if _.isEqual(body.lines, lines) and body._id == doc_id.toString() + else if _.isEqual(body?.lines, lines) and body?._id == doc_id.toString() cb() else cb("health check lines not equal #{body.lines} != #{lines}")