[web] remove deledFiles collection (#25750)

* [history-v1] remove processing of deleted files when back-filling hashes

* [web] remove deledFiles collection

GitOrigin-RevId: 7c080e564f7d7acb33ebe7ebe012f415a847d0df
This commit is contained in:
Jakob Ackermann
2025-05-23 08:05:01 +00:00
committed by Copybot
parent 52f1e46343
commit 11b94593c2
21 changed files with 155 additions and 809 deletions
@@ -99,10 +99,6 @@ describe('ProjectDeleter', function () {
}
this.db = {
deletedFiles: {
indexExists: sinon.stub().resolves(false),
deleteMany: sinon.stub(),
},
projects: {
insertOne: sinon.stub().resolves(),
},
@@ -4,7 +4,6 @@ const tk = require('timekeeper')
const Errors = require('../../../../app/src/Features/Errors/Errors')
const { ObjectId } = require('mongodb-legacy')
const SandboxedModule = require('sandboxed-module')
const { DeletedFile } = require('../helpers/models/DeletedFile')
const { Project } = require('../helpers/models/Project')
const MODULE_PATH =
@@ -77,7 +76,6 @@ describe('ProjectEntityMongoUpdateHandler', function () {
}
this.FolderModel = sinon.stub()
this.DeletedFileMock = sinon.mock(DeletedFile)
this.ProjectMock = sinon.mock(Project)
this.ProjectEntityHandler = {
getAllEntitiesFromProject: sinon.stub(),
@@ -197,7 +195,6 @@ describe('ProjectEntityMongoUpdateHandler', function () {
'../Cooldown/CooldownManager': this.CooldownManager,
'../../models/Folder': { Folder: this.FolderModel },
'../../infrastructure/LockManager': this.LockManager,
'../../models/DeletedFile': { DeletedFile },
'../../models/Project': { Project },
'./ProjectEntityHandler': this.ProjectEntityHandler,
'./ProjectLocator': this.ProjectLocator,
@@ -208,7 +205,6 @@ describe('ProjectEntityMongoUpdateHandler', function () {
})
afterEach(function () {
this.DeletedFileMock.restore()
this.ProjectMock.restore()
tk.reset()
})
@@ -374,17 +370,6 @@ describe('ProjectEntityMongoUpdateHandler', function () {
linkedFileData: { some: 'data' },
hash: 'some-hash',
}
// Add a deleted file record
this.DeletedFileMock.expects('create')
.withArgs({
projectId: this.project._id,
_id: this.file._id,
name: this.file.name,
linkedFileData: this.file.linkedFileData,
hash: this.file.hash,
deletedAt: sinon.match.date,
})
.resolves()
// Update the file in place
this.ProjectMock.expects('findOneAndUpdate')
.withArgs(
@@ -421,7 +406,6 @@ describe('ProjectEntityMongoUpdateHandler', function () {
})
it('updates the database', function () {
this.DeletedFileMock.verify()
this.ProjectMock.verify()
})
})
@@ -1059,29 +1043,6 @@ describe('ProjectEntityMongoUpdateHandler', function () {
})
})
describe('_insertDeletedFileReference', function () {
beforeEach(async function () {
this.DeletedFileMock.expects('create')
.withArgs({
projectId: this.project._id,
_id: this.file._id,
name: this.file.name,
linkedFileData: this.file.linkedFileData,
hash: this.file.hash,
deletedAt: sinon.match.date,
})
.resolves()
await this.subject.promises._insertDeletedFileReference(
this.project._id,
this.file
)
})
it('should update the database', function () {
this.DeletedFileMock.verify()
})
})
describe('createNewFolderStructure', function () {
beforeEach(function () {
this.mockRootFolder = 'MOCK_ROOT_FOLDER'
@@ -133,7 +133,6 @@ describe('ProjectEntityUpdateHandler', function () {
addFolder: sinon.stub(),
_confirmFolder: sinon.stub(),
_putElement: sinon.stub(),
_insertDeletedFileReference: sinon.stub(),
replaceFileWithNew: sinon.stub(),
mkdirp: sinon.stub(),
moveEntity: sinon.stub(),
@@ -2572,7 +2571,6 @@ describe('ProjectEntityUpdateHandler', function () {
this.ProjectEntityUpdateHandler.promises.unsetRootDoc = sinon
.stub()
.resolves()
this.ProjectEntityMongoUpdateHandler.promises._insertDeletedFileReference.resolves()
})
describe('a file', function () {
@@ -2592,12 +2590,6 @@ describe('ProjectEntityUpdateHandler', function () {
)
})
it('should insert the file into the deletedFiles collection', function () {
this.ProjectEntityMongoUpdateHandler.promises._insertDeletedFileReference
.calledWith(this.project._id, this.entity)
.should.equal(true)
})
it('should not delete the file from FileStoreHandler', function () {
this.FileStoreHandler.promises.deleteFile
.calledWith(projectId, this.entityId)
@@ -2696,7 +2688,6 @@ describe('ProjectEntityUpdateHandler', function () {
}
this.ProjectEntityUpdateHandler._cleanUpDoc = sinon.stub().resolves()
this.ProjectEntityUpdateHandler._cleanUpFile = sinon.stub().resolves()
const path = '/folder'
this.newProject = 'new-project'
this.subtreeListing =
@@ -2711,17 +2702,6 @@ describe('ProjectEntityUpdateHandler', function () {
)
})
it('should clean up all sub files', function () {
this.ProjectEntityUpdateHandler._cleanUpFile.should.have.been.calledWith(
this.project,
this.file1
)
this.ProjectEntityUpdateHandler._cleanUpFile.should.have.been.calledWith(
this.project,
this.file2
)
})
it('should clean up all sub docs', function () {
this.ProjectEntityUpdateHandler._cleanUpDoc
.calledWith(
@@ -1,3 +0,0 @@
const mockModel = require('../MockModel')
module.exports = mockModel('DeletedFile')